From 24c14153c545b2305ec86ebc55dfd1d2813416aa Mon Sep 17 00:00:00 2001 From: Andrew Borodin Date: Sun, 20 Apr 2014 19:05:00 +0400 Subject: [PATCH] (ftpfs_netrc_lookup): fix null check after dereference ...and simplify. Signed-off-by: Andrew Borodin --- src/vfs/ftpfs/ftpfs.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/vfs/ftpfs/ftpfs.c b/src/vfs/ftpfs/ftpfs.c index acd4b2cc1..bb87af681 100644 --- a/src/vfs/ftpfs/ftpfs.c +++ b/src/vfs/ftpfs/ftpfs.c @@ -2429,12 +2429,10 @@ ftpfs_netrc_lookup (const char *host, char **login, char **pass) /* Look up in the cache first */ for (rupp = rup_cache; rupp != NULL; rupp = rupp->next) { - if (!strcmp (host, rupp->host)) + if (strcmp (host, rupp->host) == 0) { - if (rupp->login) - *login = g_strdup (rupp->login); - if (pass && rupp->pass) - *pass = g_strdup (rupp->pass); + *login = g_strdup (rupp->login); + *pass = g_strdup (rupp->pass); return 0; } }