mirrors/mc
1
0
Fork 0
mirror of https://github.com/MidnightCommander/mc synced 2024-12-22 12:32:40 +03:00
Code Issues Packages Projects Releases Wiki Activity

Ticket #4616: (tar_read_header): fix double free.

Browse Source 
When tar data block unexpected end then header_copy get freed but
"goto ret:" freed header_copy again.

Do not free header_copy at exit from the loop of reading tar blocks.

Found by Clang-19 Static Analyzer.

The bug was introduced in 8223f82857.

Reported-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
This commit is contained in:
Andrew Borodin 2024-12-21 10:19:02 +03:00
parent d205be6f85
commit 152362bcb1
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/vfs/tar/tar.c
View File

@ -680,7 +680,6 @@ tar_read_header (struct vfs_class *me, struct vfs_s_super *archive)
data_block = tar_find_next_block (arch); data_block = tar_find_next_block (arch);
if (data_block == NULL) if (data_block == NULL)
{ {
g_free (header_copy);
message (D_ERROR, MSG_ERROR, _("Unexpected EOF on archive file")); message (D_ERROR, MSG_ERROR, _("Unexpected EOF on archive file"));
status = HEADER_FAILURE; status = HEADER_FAILURE;
goto ret; goto ret;