From 7348e99269c93b975dac3a4f4c68e58ebce078df Mon Sep 17 00:00:00 2001 From: ocornut Date: Mon, 15 May 2023 14:34:30 +0200 Subject: [PATCH] CI: temporarily use Emscripten 3.1.37 because 3.1.18 has a regression. Ref https://github.com/emscripten-core/emscripten/issues/19363 --- .github/workflows/build.yml | 4 ++-- imgui.h | 5 +++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 45688c470..57562ac4f 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -479,8 +479,8 @@ jobs: wget -q https://github.com/emscripten-core/emsdk/archive/master.tar.gz tar -xvf master.tar.gz emsdk-master/emsdk update - emsdk-master/emsdk install latest - emsdk-master/emsdk activate latest + emsdk-master/emsdk install 3.1.37 + emsdk-master/emsdk activate 3.1.37 - name: Build example_sdl2_opengl3 with Emscripten run: | diff --git a/imgui.h b/imgui.h index 3917ccb80..a549aec11 100644 --- a/imgui.h +++ b/imgui.h @@ -2344,8 +2344,9 @@ struct ImGuiListClipper IMGUI_API void End(); // Automatically called on the last call of Step() that returns false. IMGUI_API bool Step(); // Call until it returns false. The DisplayStart/DisplayEnd fields will be set and you can process/draw those items. - // Call IncludeRangeByIndices() before first call to Step() if you need a range of items to be displayed regardless of visibility. - IMGUI_API void IncludeRangeByIndices(int item_begin, int item_end); // item_end is exclusive e.g. use (42, 42+1) to make item 42 always visible BUT due to alignment/padding of certain items it is possible/likely that an extra item may be included on either end of the display range. + // Call IncludeRangeByIndices() *BEFORE* first call to Step() if you need a range of items to not be clipped, regardless of their visibility. + // (Due to alignment / padding of certain items it is possible that an extra item may be included on either end of the display range). + IMGUI_API void IncludeRangeByIndices(int item_begin, int item_end); // item_end is exclusive e.g. use (42, 42+1) to make item 42 never clipped. #ifndef IMGUI_DISABLE_OBSOLETE_FUNCTIONS inline void ForceDisplayRangeByIndices(int item_begin, int item_end) { IncludeRangeByIndices(item_begin, item_end); } // [renamed in 1.89.6]