![Albert Safin](/assets/img/avatar_default.png)
This commit should fix "move con to parent" trick (see below) in the case when con->parent->parent is a workspace. The trick: mark _a, focus parent, focus parent, mark _b, [con_mark=_a] move window to mark _b, [con_mark=_a] focus The trick got broken in commit 626af81232e6ca81abea22267f3330c16d804596 in order to fix an i3 crash (#2003). Reverting said commit fixes the trick. The crash is caused by the fact that empty workspace isn't considered a split (checked in src/con.c:1324), so the moved window ends up as a sibling of the target workspace, not as its child.
38 lines
1.1 KiB
Perl
38 lines
1.1 KiB
Perl
#!perl
|
|
# vim:ts=4:sw=4:expandtab
|
|
#
|
|
# Please read the following documents before working on tests:
|
|
# • https://build.i3wm.org/docs/testsuite.html
|
|
# (or docs/testsuite)
|
|
#
|
|
# • https://build.i3wm.org/docs/lib-i3test.html
|
|
# (alternatively: perldoc ./testcases/lib/i3test.pm)
|
|
#
|
|
# • https://build.i3wm.org/docs/ipc.html
|
|
# (or docs/ipc)
|
|
#
|
|
# • http://onyxneon.com/books/modern_perl/modern_perl_a4.pdf
|
|
# (unless you are already familiar with Perl)
|
|
#
|
|
# Make sure the trick used to move the container to its parent works.
|
|
# https://github.com/i3/i3/issues/1326#issuecomment-349082811
|
|
use i3test;
|
|
|
|
cmp_tree(
|
|
msg => 'Move to parent when the parent is a workspace',
|
|
layout_before => 'a H[b*] c',
|
|
layout_after => 'a b* c',
|
|
cb => sub {
|
|
cmd 'mark _a, focus parent, focus parent, mark _b, [con_mark=_a] move window to mark _b, [con_mark=_a] focus';
|
|
});
|
|
|
|
cmp_tree(
|
|
msg => 'Move to parent when the parent is a split',
|
|
layout_before => 'V[a H[b*] c]',
|
|
layout_after => 'V[a b* c]',
|
|
cb => sub {
|
|
cmd 'mark _a, focus parent, focus parent, mark _b, [con_mark=_a] move window to mark _b, [con_mark=_a] focus';
|
|
});
|
|
|
|
done_testing;
|