1ee963ede9
The crash was brought up in a comment in https://github.com/i3/i3/discussions/6076#discussioncomment-9536969 The cause is that the command criteria are matching a window in the scratchpad. In that case, the assertion in get_output_for_con() fails. That happens because there is no `Output` for the `Con` output of a scratchpad window. I've decided to *not* remove the offending assertion but rather rely on the caller not using the function with internal containers. My reasoning is: 1. If get_output_for_con can return NULL then the caller will either segfault (which is worse) or needs to check the return for NULL. 2. The case where the return can be NULL is already known, it happens for internal containers. 3. Therefore, the caller should already prevent the situation with a call to con_is_internal(). Thus, the `assert`ion can remain. There is also the potential fix of con_get_workspace returning some arbitrary output (e.g. first in the list or currently focused one) instead of NULL. This can lead to more tricky to catch bugs.
53 lines
914 B
Plaintext
53 lines
914 B
Plaintext
*.o
|
|
tags
|
|
include/GENERATED_*.h
|
|
include/all.h.pch
|
|
*~
|
|
*.swp
|
|
*.gcda
|
|
*.gcno
|
|
*.dSYM
|
|
test.commands_parser
|
|
test.config_parser
|
|
testcases/MYMETA.json
|
|
testcases/MYMETA.yml
|
|
testcases/blib/
|
|
testcases/pm_to_blib
|
|
AnyEvent-I3/Makefile
|
|
AnyEvent-I3/META.yml
|
|
AnyEvent-I3/MYMETA.json
|
|
AnyEvent-I3/MYMETA.yml
|
|
AnyEvent-I3/blib/
|
|
AnyEvent-I3/inc/
|
|
AnyEvent-I3/pm_to_blib
|
|
*.output
|
|
*.tab.*
|
|
*.yy.c
|
|
man/*.1
|
|
man/*.xml
|
|
man/*.html
|
|
*.tar.bz2*
|
|
i3
|
|
i3-input/i3-input
|
|
i3-nagbar/i3-nagbar
|
|
i3-msg/i3-msg
|
|
i3-config-wizard/i3-config-wizard
|
|
i3-dump-log/i3-dump-log
|
|
libi3.a
|
|
docs/*.pdf
|
|
docs/*.html
|
|
!/docs/refcard.html
|
|
i3-command-parser.stamp
|
|
i3-config-parser.stamp
|
|
.clang_complete
|
|
compile_commands.json
|
|
/.ccls-cache
|
|
/.clangd
|
|
LAST_VERSION
|
|
|
|
# We recommend building in a subdirectory called build.
|
|
# If you chose a different directory name,
|
|
# it is up to you to arrange for it to be ignored by git,
|
|
# e.g. by listing your directory in .git/info/exclude.
|
|
/build
|