mirrors/i3
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add regression test for #3888

Browse Source
This commit is contained in:
Wilhelm Schuster 2020-11-10 16:58:09 +01:00
parent 377f7d7ab2
commit c246f176eb
2 changed files with 67 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
RELEASE-NOTES-next
View File

@ -52,3 +52,4 @@ working. Please reach out to us in that case!
• fix Xorg memory leak with i3bar
• fix named workspace assignments on output changes
• fix named workspace assignment precedence on workspace renames
• fix windows getting swallowed more than once

66
testcases/t/542-layout-restore-remanage.t
View File

@ -83,4 +83,70 @@ is($nodes[0]->{name}, 'different_title', 'test window got swallowed');
close($fh);
############################################################
# Make sure window only gets swallowed once
############################################################
# Regression, issue #3888
$ws = fresh_workspace;
($fh, $filename) = tempfile(UNLINK => 1);
print $fh <<'EOT';
// vim:ts=4:sw=4:et
{
// splith split container with 2 children
"layout": "splith",
"type": "con",
"nodes": [
{
"type": "con",
"swallows": [
{
"class": "^foo$"
}
]
},
{
// splitv split container with 2 children
"layout": "splitv",
"type": "con",
"nodes": [
{
"type": "con",
"swallows": [
{
"class": "^foo$"
}
]
},
{
"type": "con",
"swallows": [
{
"class": "^foo$"
}
]
}
]
}
]
}
EOT
$fh->flush;
cmd "append_layout $filename";
$window = open_window wm_class => 'foo';
# Changing an unrelated window property originally resulted in the window
# getting remanaged and swallowd by a different placeholder, even though the
# matching property (class for the layout above) didn't change.
change_window_title($window, "different_title");
@content = @{get_ws_content($ws)};
subtest 'regression test that window gets only swallowed once', sub {
is($content[0]->{nodes}[0]->{window}, $window->id, 'first placeholder swallowed window');
isnt($content[0]->{nodes}[1]->{nodes}[0]->{window}, $window->id, 'second placeholder did not swallow window');
isnt($content[0]->{nodes}[1]->{nodes}[1]->{window}, $window->id, 'thid placeholder did not swallow window');
};
done_testing;