mirrors/fltk
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix mousewheel problem with Fl_Text_Editor (issue #879)

Browse Source 
When an Fl_Text_Editor ended up under the mouse, it took
mousewheel events for itself, freezing navigation of a
parent's Fl_Scroll.

Patch handles mousewheel events for both up/down and left/right
by checking:

    > If editor has no scrollbar (e.g. no content to scroll to),
      then mousewheel events for that scrollbar are ignored
      so the parent can be navigated.

    > If editor has a scrollbar, it handles wheel events until scroller reaches
      an extreme position (e.g. top or bottom), it starts ignoring wheel events
      so the parent can be navigated.
This commit is contained in:
Greg Ercolano 2024-01-25 08:09:25 -08:00
parent 6a887bf69b
commit f2544509c1
1 changed files with 15 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/Fl_Text_Display.cxx
View File

@ -4128,7 +4128,7 @@ int Fl_Text_Display::handle(int event) {
if (!Fl::event_inside(text_area.x, text_area.y, text_area.w, text_area.h) &&
!dragging && event != FL_LEAVE && event != FL_ENTER &&
event != FL_MOVE && event != FL_FOCUS && event != FL_UNFOCUS &&
event != FL_KEYBOARD && event != FL_KEYUP) {
event != FL_KEYBOARD && event != FL_KEYUP && event != FL_MOUSEWHEEL) {
return Fl_Group::handle(event);
}
@ -4303,8 +4303,20 @@ int Fl_Text_Display::handle(int event) {
}
case FL_MOUSEWHEEL:
if (Fl::event_dy()) return mVScrollBar->handle(event);
else return mHScrollBar->handle(event);
if (Fl::e_dy && mVScrollBar->visible()) {
// Issue #879
Fl_Scrollbar *vs = mVScrollBar;
if ((Fl::e_dy < 0) && (vs->value() == int(vs->minimum()))) return 0; // hit top? ignore
if ((Fl::e_dy > 0) && (vs->value() == int(vs->maximum()))) return 0; // hit bot? ignore
return vs->handle(event);
} else if (Fl::e_dx && mHScrollBar->visible()) {
// Issue #879
Fl_Scrollbar *hs = mHScrollBar;
if ((Fl::e_dx < 0) && (hs->value() == int(hs->minimum()))) return 0; // hit left? ignore
if ((Fl::e_dx > 0) && (hs->value() == int(hs->maximum()))) return 0; // hit right? ignore
return hs->handle(event);
}
return 0;
case FL_UNFOCUS:
if (active_r() && window()) window()->cursor(FL_CURSOR_DEFAULT);