From 5df7a7678a4641cc9234ac8ea0d54623628d922a Mon Sep 17 00:00:00 2001 From: Albrecht Schlosser Date: Wed, 15 May 2019 18:31:46 +0200 Subject: [PATCH] Document Fl_File_Input::errorcolor() as deprecated Fl_File_Input::errorcolor() and Fl_File_Input::errorcolor(Fl_Color) have not been used anywhere. Marked as deprecated. --- FL/Fl_File_Input.H | 22 +++++++++++++++++----- src/Fl_File_Input.cxx | 1 - 2 files changed, 17 insertions(+), 6 deletions(-) diff --git a/FL/Fl_File_Input.H b/FL/Fl_File_Input.H index 6c8ee578b..859652284 100644 --- a/FL/Fl_File_Input.H +++ b/FL/Fl_File_Input.H @@ -46,7 +46,6 @@ */ class FL_EXPORT Fl_File_Input : public Fl_Input { - Fl_Color errorcolor_; char ok_entry_; uchar down_box_; short buttons_[200]; @@ -73,11 +72,24 @@ public: /** Gets the current error color. - \todo Better docs for Fl_File_Input::errorcolor() - is it even used? + + Returns \p FL_RED since FLTK 1.4.0 (default in 1.3.x). + Retained for backwards compatibility. + + \deprecated Will be removed in FLTK 1.4.2 or higher. + \todo Remove Fl_File_Input::errorcolor() in FLTK 1.4.2 or higher. */ - Fl_Color errorcolor() const { return errorcolor_; } - /** Sets the current error color to \p c */ - void errorcolor(Fl_Color c) { errorcolor_ = c; } + Fl_Color errorcolor() const { return FL_RED; } + + /** + Sets the current error color to \p c. + + Does nothing since FLTK 1.4.0. Retained for backwards compatibility. + + \deprecated Will be removed in FLTK 1.4.2 or higher. + \todo Remove Fl_File_Input::errorcolor(Fl_Color) in FLTK 1.4.2 or higher. + */ + void errorcolor(Fl_Color c) {} int value(const char *str); int value(const char *str, int len); diff --git a/src/Fl_File_Input.cxx b/src/Fl_File_Input.cxx index 4a4f3b49a..201101809 100644 --- a/src/Fl_File_Input.cxx +++ b/src/Fl_File_Input.cxx @@ -50,7 +50,6 @@ Fl_File_Input::Fl_File_Input(int X, int Y, int W, int H, const char *L) : Fl_Input(X, Y, W, H, L) { buttons_[0] = 0; - errorcolor_ = FL_RED; ok_entry_ = 1; pressed_ = -1;