mirrors
/
flac
mirror of https://github.com/xiph/flac
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix three more cppcheck warnings 

* src/flac/vorbiscomment.c:203: Uninitialized variable: converted.
* src/flac/vorbiscomment.c:210: Uninitialized variable: converted.
* src/test_libFLAC++/decoders.cpp:507: Memory leak: decoder.
This commit is contained in:
Erik de Castro Lopo 2016-01-23 08:29:32 +11:00
parent d908b292c9
commit e0b406f664
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/flac/vorbiscomment.c
View File

@ -104,7 +104,7 @@ static FLAC__bool parse_vorbis_comment_field(const char *field_ref, char **field
static FLAC__bool set_vc_field(FLAC__StreamMetadata *block, const Argument_VcField *field, FLAC__bool *needs_write, FLAC__bool raw, const char **violation) static FLAC__bool set_vc_field(FLAC__StreamMetadata *block, const Argument_VcField *field, FLAC__bool *needs_write, FLAC__bool raw, const char **violation)
{ {
FLAC__StreamMetadata_VorbisComment_Entry entry; FLAC__StreamMetadata_VorbisComment_Entry entry;
char *converted; char *converted = NULL;
FLAC__ASSERT(0 != block); FLAC__ASSERT(0 != block);
FLAC__ASSERT(block->type == FLAC__METADATA_TYPE_VORBIS_COMMENT); FLAC__ASSERT(block->type == FLAC__METADATA_TYPE_VORBIS_COMMENT);

1
src/test_libFLAC++/decoders.cpp
View File

@ -504,6 +504,7 @@ static bool test_stream_decoder(Layer layer, bool is_ogg)
break; break;
default: default:
die_("internal error 006"); die_("internal error 006");
delete decoder;
return false; return false;
} }
if(init_status != ::FLAC__STREAM_DECODER_INIT_STATUS_OK) if(init_status != ::FLAC__STREAM_DECODER_INIT_STATUS_OK)