mirrors/flac
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix segfault introduced in commit 3975b3e

Browse Source 
A read from the input file was attempted without checking whether
opening it was succesful.
This commit is contained in:
Martijn van Beurden 2022-12-02 10:05:45 +01:00 committed by GitHub
parent 7844578995
commit 9b7ca112e9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/flac/decode.c
View File

@ -332,7 +332,12 @@ FLAC__bool DecoderSession_init_decoder(DecoderSession *decoder_session, const ch
/* When testing, we can be a little more pedantic, as long
* as we can seek properly */
FLAC__byte buffer[3];
FILE * f = flac_fopen(infilename, "rb");
FILE * f;
if(0 == (f = flac_fopen(infilename, "rb"))) {
flac__utils_printf(stderr, 1, "ERROR: can't open input file %s: %s\n", infilename, strerror(errno));
return false;
}
if(fread(buffer, 1, 3, f) < 3) {
flac__utils_printf(stderr, 1, "%s: ERROR checking for ID3v2 tag\n", decoder_session->inbasefilename);