mirrors
/
flac
mirror of https://github.com/xiph/flac
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add note to metaflac warning about writing to symlinks

This commit is contained in:
Martijn van Beurden 2024-08-30 18:46:07 +02:00
parent 685f4f69d1
commit 4a271d2e9f
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/metaflac/operations.c
View File

@ -170,8 +170,12 @@ FLAC__bool do_major_operation_on_file(const char *filename, const CommandLineOpt
if(options->use_padding) if(options->use_padding)
FLAC__metadata_chain_sort_padding(chain); FLAC__metadata_chain_sort_padding(chain);
ok = FLAC__metadata_chain_write(chain, options->use_padding, options->preserve_modtime); ok = FLAC__metadata_chain_write(chain, options->use_padding, options->preserve_modtime);
if(!ok) if(!ok) {
FLAC__Metadata_ChainStatus status = FLAC__metadata_chain_status(chain);
print_error_with_chain_status(chain, "%s: ERROR: writing FLAC file", filename); print_error_with_chain_status(chain, "%s: ERROR: writing FLAC file", filename);
if(status == FLAC__METADATA_CHAIN_STATUS_RENAME_ERROR)
flac_fprintf(stderr, "NOTE: rename errors often occur when working with symlinks pointing to a different filesystem\n");
}
} }
FLAC__metadata_chain_delete(chain); FLAC__metadata_chain_delete(chain);
@ -466,8 +470,12 @@ FLAC__bool do_shorthand_operations_on_file(const char *filename, const CommandLi
if(use_padding) if(use_padding)
FLAC__metadata_chain_sort_padding(chain); FLAC__metadata_chain_sort_padding(chain);
ok = FLAC__metadata_chain_write(chain, use_padding, options->preserve_modtime); ok = FLAC__metadata_chain_write(chain, use_padding, options->preserve_modtime);
if(!ok) if(!ok) {
FLAC__Metadata_ChainStatus status = FLAC__metadata_chain_status(chain);
print_error_with_chain_status(chain, "%s: ERROR: writing FLAC file", filename); print_error_with_chain_status(chain, "%s: ERROR: writing FLAC file", filename);
if(status == FLAC__METADATA_CHAIN_STATUS_RENAME_ERROR)
flac_fprintf(stderr, "NOTE: rename errors often occur when working with symlinks pointing to a different filesystem\n");
}
} }
cleanup : cleanup :