From 293d6b22cd09b8d9c376d447a933641da9828036 Mon Sep 17 00:00:00 2001 From: Erik de Castro Lopo Date: Tue, 19 Jan 2016 18:16:26 +1100 Subject: [PATCH] macros.h: Make FLAC_CHECK_RETURN print to stderr Also comment the fact that this macro should only be used for things that are extremely unlikely to fail. --- include/share/macros.h | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/include/share/macros.h b/include/share/macros.h index 5b9cf4e1..eea62c10 100644 --- a/include/share/macros.h +++ b/include/share/macros.h @@ -32,10 +32,14 @@ #include /* FLAC_CHECK_RETURN : Check the return value of the provided function and - * print and error message if it fails (ie returns a value < 0). + * print an error message if it fails (ie returns a value < 0). + * + * Ideally, a library should not print anything, but this macro is only used + * for things that extremely unlikely to fail, like `chown` to a previoulsy + * saved `uid`. */ #define FLAC_CHECK_RETURN(x) \ { if ((x) < 0) \ - printf ("%s : %s\n", #x, strerror (errno)) ; \ + fprintf (stderr, "%s : %s\n", #x, strerror (errno)) ; \ }