mirrors/bgfx
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix crash on iOS <16 and macOS <13

Browse Source 
- MTLComputePipelineReflection.bindings are only available from iOS 16 and macOS 13, before that MTLComputePipelineReflection.arguments should be used
- Same issue with MTLRenderPipelineReflection.vertexBindings and MTLRenderPipelineReflection.fragmentBindings

Added availability check to fix it.
This commit is contained in:
Adrien Duermael 2023-04-21 15:59:39 +02:00
parent 6dd8edc4b1
commit ef5937bd51
1 changed files with 28 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
src/renderer_mtl.mm
View File

@ -2336,8 +2336,20 @@ BX_STATIC_ASSERT(BX_COUNTOF(s_accessNames) == Access::Count, "Invalid s_accessNa
pso->m_rps = m_device.newRenderPipelineStateWithDescriptor(pd, MTLPipelineOptionBufferTypeInfo, &reflection); pso->m_rps = m_device.newRenderPipelineStateWithDescriptor(pd, MTLPipelineOptionBufferTypeInfo, &reflection);
if (NULL != reflection) if (NULL != reflection)
{ {
processArguments(pso, reflection.vertexBindings, reflection.fragmentBindings); #if BX_PLATFORM_IOS
if (@available(iOS 16, *)) {
processArguments(pso, reflection.vertexBindings, reflection.fragmentBindings);
} else {
processArguments(pso, reflection.vertexArguments, reflection.fragmentArguments);
}
#elif BX_PLATFORM_OSX
if (@available(macOS 13, *)) {
processArguments(pso, reflection.vertexBindings, reflection.fragmentBindings);
} else {
processArguments(pso, reflection.vertexArguments, reflection.fragmentArguments);
}
#endif
} }
} }
@ -2384,7 +2396,20 @@ BX_STATIC_ASSERT(BX_COUNTOF(s_accessNames) == Access::Count, "Invalid s_accessNa
, MTLPipelineOptionBufferTypeInfo , MTLPipelineOptionBufferTypeInfo
, &reflection , &reflection
); );
processArguments(pso, reflection.bindings, NULL);
#if BX_PLATFORM_IOS
if (@available(iOS 16, *)) {
processArguments(pso, reflection.bindings, NULL);
} else {
processArguments(pso, reflection.arguments, NULL);
}
#elif BX_PLATFORM_OSX
if (@available(macOS 13, *)) {
processArguments(pso, reflection.bindings, NULL);
} else {
processArguments(pso, reflection.arguments, NULL);
}
#endif
for (uint32_t ii = 0; ii < 3; ++ii) for (uint32_t ii = 0; ii < 3; ++ii)
{ {