add error log detecting uint8_t overflow in hlsl shader compilation

2023-12-19 12:19:33 -08:00 · 2023-12-19 12:19:33 -08:00 · eb871bb618
commit eb871bb618
parent a0057adaaa
1 changed files with 11 additions and 0 deletions
--- a/tools/shaderc/shaderc_hlsl.cpp
+++ b/tools/shaderc/shaderc_hlsl.cpp
@ -481,6 +481,17 @@ namespace bgfx { namespace hlsl
 							if (UniformType::Count != uniformType
 							&&  0 != (varDesc.uFlags & D3D_SVF_USED) )
 							{
+								if (constDesc.Elements > UINT8_MAX)
+								{
+									bx::write(_messageWriter
+										, &messageErr
+										, "Error: Uniform %s has %u elements. 255 is the limit for shaderc uniform serialization.\n"
+										, varDesc.Name
+										, constDesc.Elements
+										);
+									return false;
+								}
+
 								Uniform un;
 								un.name = varDesc.Name;
 								un.type = uniformType;