mirrors/acpica
1
0
Fork 0
mirror of https://github.com/acpica/acpica/ synced 2025-02-20 23:44:12 +03:00
Code Issues Packages Projects Releases Wiki Activity

Generic Unix OSL: Use a buffer to eliminate multiple vfprintf()s.

Browse Source 
Some compilers/clibs modify the arg pointer parameter to vfprintf
making it difficult to call it twice in the AcpiOsVprintf function.
Use a local buffer to workaround this issue. Does not affect the
Windows OSL since the win c library does not modify the arg
pointer. Chao Guan, Bob Moore.
This commit is contained in:
Robert Moore 2013-01-16 12:29:49 -08:00
parent 392e5cce3c
commit 6872a1d5ae
1 changed files with 19 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
source/os_specific/service_layers/osunixxf.c
View File

@ -156,6 +156,10 @@ AeTableOverride (
typedef void* (*PTHREAD_CALLBACK) (void *);
/* Buffer used by AcpiOsVprintf */
#define ACPI_VPRINTF_BUFFER_SIZE 512
/* Apple-specific */
#ifdef __APPLE__
@ -405,8 +409,21 @@ AcpiOsVprintf (
va_list Args)
{
UINT8 Flags;
char Buffer[ACPI_VPRINTF_BUFFER_SIZE];
/*
* We build the output string in a local buffer because we may be
* outputting the buffer twice. Using vfprintf is problematic because
* some implementations modify the args pointer/structure during
* execution. Thus, we use the local buffer for portability.
*
* Note: Since this module is intended for use by the various ACPICA
* utilities/applications, we can safely declare the buffer on the stack.
* Also, This function is used for relatively small error messages only.
*/
vsnprintf (Buffer, ACPI_VPRINTF_BUFFER_SIZE, Fmt, Args);
Flags = AcpiGbl_DbOutputFlags;
if (Flags & ACPI_DB_REDIRECTABLE_OUTPUT)
{
@ -416,7 +433,7 @@ AcpiOsVprintf (
{
/* Output file is open, send the output there */
vfprintf (AcpiGbl_DebugFile, Fmt, Args);
fputs (Buffer, AcpiGbl_DebugFile);
}
else
{
@ -428,7 +445,7 @@ AcpiOsVprintf (
if (Flags & ACPI_DB_CONSOLE_OUTPUT)
{
vfprintf (AcpiGbl_OutputFile, Fmt, Args);
fputs (Buffer, AcpiGbl_OutputFile);
}
}