mirrors/acpica
1
0
Fork 0
mirror of https://github.com/acpica/acpica/ synced 2025-02-07 09:04:21 +03:00
Code Issues Packages Projects Releases Wiki Activity

BIG CHECKIN

Browse Source 
turning on printf format checking revealed we've been a little lax. Sins
include:
1) using %X when we should use %p
2) using %ld instead of %d
3) using %x for ACPI_INTEGERS (you need to use HIDWORD() and %x%x)
4) using %4.4s and not casting to a char*
5) using %s with void*

I also reformatted the OSL add_device messages a little.

Anything breaks, let me know. :)  -- Andy


date	2001.10.17.03.57.00;	author agrover;	state Exp;
This commit is contained in:
aystarik 2005-06-29 16:55:56 +00:00
parent 13c17cef8f
commit 2fa58ebd30
1 changed files with 12 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
source/components/hardware/hwregs.c
View File

@ -3,7 +3,7 @@
*
* Module Name: hwregs - Read/write access functions for the various ACPI
* control and status registers.
* $Revision: 1.109 $
* $Revision: 1.110 $
*
******************************************************************************/
@ -569,8 +569,9 @@ AcpiHwRegisterBitAccess (
RegisterValue = AcpiHwRegisterRead (ACPI_MTX_DO_NOT_LOCK, PM2_CONTROL);
ACPI_DEBUG_PRINT ((ACPI_DB_IO, "PM2 control: Read %X from %p\n",
RegisterValue, ACPI_GET_ADDRESS (AcpiGbl_FADT->XPm2CntBlk.Address)));
ACPI_DEBUG_PRINT ((ACPI_DB_IO, "PM2 control: Read %X from %8.8X%8.8X\n",
RegisterValue, HIDWORD(AcpiGbl_FADT->XPm2CntBlk.Address),
LODWORD(AcpiGbl_FADT->XPm2CntBlk.Address)));
if (ReadWrite == ACPI_WRITE)
{
@ -579,8 +580,10 @@ AcpiHwRegisterBitAccess (
Value &= Mask;
RegisterValue |= Value;
ACPI_DEBUG_PRINT ((ACPI_DB_IO, "About to write %04X to %p\n", RegisterValue,
AcpiGbl_FADT->XPm2CntBlk.Address));
ACPI_DEBUG_PRINT ((ACPI_DB_IO, "About to write %04X to %8.8X%8.8X\n",
RegisterValue,
HIDWORD(AcpiGbl_FADT->XPm2CntBlk.Address),
LODWORD(AcpiGbl_FADT->XPm2CntBlk.Address)));
AcpiHwRegisterWrite (ACPI_MTX_DO_NOT_LOCK,
PM2_CONTROL, (UINT8) (RegisterValue));
@ -593,8 +596,10 @@ AcpiHwRegisterBitAccess (
Mask = TMR_VAL_MASK;
RegisterValue = AcpiHwRegisterRead (ACPI_MTX_DO_NOT_LOCK,
PM_TIMER);
ACPI_DEBUG_PRINT ((ACPI_DB_IO, "PM_TIMER: Read %X from %p\n",
RegisterValue, ACPI_GET_ADDRESS (AcpiGbl_FADT->XPmTmrBlk.Address)));
ACPI_DEBUG_PRINT ((ACPI_DB_IO, "PM_TIMER: Read %X from %8.8X%8.8X\n",
RegisterValue,
HIDWORD(AcpiGbl_FADT->XPmTmrBlk.Address),
LODWORD(AcpiGbl_FADT->XPmTmrBlk.Address)));
break;