mirrors/acpica
1
0
Fork 0
mirror of https://github.com/acpica/acpica/ synced 2025-01-17 23:09:18 +03:00
Code Issues Packages Projects Releases Wiki Activity

Added error checking after all mutex acquires and most mutex releases.

Browse Source 
date	2002.02.12.23.57.00;	author rmoore1;	state Exp;
This commit is contained in:
aystarik 2005-06-29 16:24:50 +00:00
parent 5b16f3b09f
commit 29937cd598
2 changed files with 45 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
source/components/debugger/dbinput.c
View File

@ -1,7 +1,7 @@
/*******************************************************************************
*
* Module Name: dbinput - user front-end to the AML debugger
* $Revision: 1.76 $
* $Revision: 1.78 $
*
******************************************************************************/
@ -126,7 +126,7 @@
#ifdef ENABLE_DEBUGGER
#define _COMPONENT ACPI_DEBUGGER
MODULE_NAME ("dbinput")
ACPI_MODULE_NAME ("dbinput")
/*
@ -770,7 +770,7 @@ AcpiDbCommandDispatch (
break;
case CMD_TERMINATE:
AcpiDbSetOutputDestination (DB_REDIRECTABLE_OUTPUT);
AcpiDbSetOutputDestination (ACPI_DB_REDIRECTABLE_OUTPUT);
AcpiUtSubsystemShutdown ();
/* TBD: [Restructure] Need some way to re-initialize without re-creating the semaphores! */
@ -843,6 +843,7 @@ AcpiDbExecuteThread (
void *Context)
{
ACPI_STATUS Status = AE_OK;
ACPI_STATUS MStatus;
while (Status != AE_CTRL_TERMINATE)
@ -850,9 +851,19 @@ AcpiDbExecuteThread (
AcpiGbl_MethodExecuting = FALSE;
AcpiGbl_StepToNextCall = FALSE;
AcpiUtAcquireMutex (ACPI_MTX_DEBUG_CMD_READY);
MStatus = AcpiUtAcquireMutex (ACPI_MTX_DEBUG_CMD_READY);
if (ACPI_FAILURE (MStatus)
{
return;
}
Status = AcpiDbCommandDispatch (AcpiGbl_DbLineBuf, NULL, NULL);
AcpiUtReleaseMutex (ACPI_MTX_DEBUG_CMD_COMPLETE);
MStatus = AcpiUtReleaseMutex (ACPI_MTX_DEBUG_CMD_COMPLETE);
if (ACPI_FAILURE (MStatus)
{
return;
}
}
}
@ -903,7 +914,7 @@ AcpiDbUserCommands (
NATIVE_CHAR Prompt,
ACPI_PARSE_OBJECT *Op)
{
ACPI_STATUS Status = AE_OK;
ACPI_STATUS Status;
/* TBD: [Restructure] Need a separate command line buffer for step mode */
@ -912,7 +923,7 @@ AcpiDbUserCommands (
{
/* Force output to console until a command is entered */
AcpiDbSetOutputDestination (DB_CONSOLE_OUTPUT);
AcpiDbSetOutputDestination (ACPI_DB_CONSOLE_OUTPUT);
/* Different prompt if method is executing */
@ -938,8 +949,17 @@ AcpiDbUserCommands (
* Signal the debug thread that we have a command to execute,
* and wait for the command to complete.
*/
AcpiUtReleaseMutex (ACPI_MTX_DEBUG_CMD_READY);
AcpiUtAcquireMutex (ACPI_MTX_DEBUG_CMD_COMPLETE);
Status = AcpiUtReleaseMutex (ACPI_MTX_DEBUG_CMD_READY);
if (ACPI_FAILURE (Status))
{
return (Status);
}
Status = AcpiUtAcquireMutex (ACPI_MTX_DEBUG_CMD_COMPLETE);
if (ACPI_FAILURE (Status))
{
return (Status);
}
}
else
{

24
source/components/debugger/dbxface.c
View File

@ -1,7 +1,7 @@
/*******************************************************************************
*
* Module Name: dbxface - AML Debugger external interfaces
* $Revision: 1.52 $
* $Revision: 1.54 $
*
******************************************************************************/
@ -128,7 +128,7 @@
#ifdef ENABLE_DEBUGGER
#define _COMPONENT ACPI_DEBUGGER
MODULE_NAME ("dbxface")
ACPI_MODULE_NAME ("dbxface")
/*******************************************************************************
@ -158,7 +158,7 @@ AcpiDbSingleStep (
ACPI_PARSE_OBJECT *ParentOp;
FUNCTION_ENTRY ();
ACPI_FUNCTION_ENTRY ();
/* Check for single-step breakpoint */
@ -229,7 +229,7 @@ AcpiDbSingleStep (
if (ParentOp)
{
if ((WalkState->ControlState) &&
(WalkState->ControlState->Common.State == CONTROL_PREDICATE_EXECUTING))
(WalkState->ControlState->Common.State == ACPI_CONTROL_PREDICATE_EXECUTING))
{
/*
* We are executing the predicate of an IF or WHILE statement
@ -347,8 +347,16 @@ AcpiDbSingleStep (
{
/* Handshake with the front-end that gets user command lines */
AcpiUtReleaseMutex (ACPI_MTX_DEBUG_CMD_COMPLETE);
AcpiUtAcquireMutex (ACPI_MTX_DEBUG_CMD_READY);
Status = AcpiUtReleaseMutex (ACPI_MTX_DEBUG_CMD_COMPLETE);
if (ACPI_FAILURE (Status))
{
return (Status);
}
Status = AcpiUtAcquireMutex (ACPI_MTX_DEBUG_CMD_READY);
if (ACPI_FAILURE (Status))
{
return (Status);
}
}
else
@ -357,7 +365,7 @@ AcpiDbSingleStep (
/* Force output to console until a command is entered */
AcpiDbSetOutputDestination (DB_CONSOLE_OUTPUT);
AcpiDbSetOutputDestination (ACPI_DB_CONSOLE_OUTPUT);
/* Different prompt if method is executing */
@ -410,7 +418,7 @@ AcpiDbInitialize (void)
AcpiGbl_DbDebugLevel = ACPI_LV_VERBOSITY2;
AcpiGbl_DbConsoleDebugLevel = NORMAL_DEFAULT | ACPI_LV_TABLES;
AcpiGbl_DbOutputFlags = DB_CONSOLE_OUTPUT;
AcpiGbl_DbOutputFlags = ACPI_DB_CONSOLE_OUTPUT;
AcpiGbl_DbOpt_tables = FALSE;
AcpiGbl_DbOpt_disasm = FALSE;