From 62359492bfdfd365135237a62b022b9467612129 Mon Sep 17 00:00:00 2001
From: Bao Hexing <hexingb@outlook.com>
Date: Tue, 14 Mar 2023 01:44:01 +0800
Subject: [PATCH] fix: addition of two polynomials memory leak and linked list
 crash (#1211)

Co-authored-by: David Leal <halfpacho@gmail.com>
---
 misc/poly_add.c | 46 ++++++++++++++--------------------------------
 1 file changed, 14 insertions(+), 32 deletions(-)

diff --git a/misc/poly_add.c b/misc/poly_add.c
index 53e76c39..8280315e 100644
--- a/misc/poly_add.c
+++ b/misc/poly_add.c
@@ -30,17 +30,11 @@ struct term
  */
 void free_poly(struct term *poly)
 {
-    if (!poly)
+    while (poly)
     {
-        return;  // NULL pointer does not need delete
-    }
-    else
-    {
-        while (!poly->next)
-        {
-            free(poly->next);  // Deletes next term
-        }
-        free(poly);  // delete the current term
+        struct term *next = poly->next;
+        free(poly);
+        poly = next;
     }
 }
 
@@ -54,31 +48,19 @@ void free_poly(struct term *poly)
 void create_polynomial(struct term **poly, int coef, int pow)
 {
     // Creating the polynomial using temporary linked lists
-    struct term *temp1, *temp2;
-    temp1 = *poly;  // Contains the null pointer
+    struct term **temp1 = poly;
 
-    // Initiating first term
-    if (temp1 == NULL)
+    while (*temp1)
     {
-        temp2 = (struct term *)malloc(
-            sizeof(struct term));  // Dynamic node creation
-        temp2->coef = coef;
-        temp2->pow = pow;
-        // Updating the null pointer with the address of the first node of the
-        // polynomial just created
-        *poly = temp2;
-        temp2->next = NULL;  // Increasing the pointer temp2
-    }
-    // Creating the rest of the nodes
-    else
-    {
-        temp2->next = (struct term *)malloc(
-            sizeof(struct term));  // Dynamic node creation
-        temp2 = temp2->next;       // Increasing the pointer temp2
-        temp2->coef = coef;
-        temp2->pow = pow;
-        temp2->next = NULL;
+        temp1 = &(*temp1)->next;
     }
+
+    // Now temp1 reaches to the end of the list
+    *temp1 = (struct term *)malloc(
+        sizeof(struct term));  // Create the term and linked as the tail
+    (*temp1)->coef = coef;
+    (*temp1)->pow = pow;
+    (*temp1)->next = NULL;
 }
 
 /**