mirrors/TheAlgorithms-C
1
0
Fork 0
mirror of https://github.com/TheAlgorithms/C synced 2024-11-21 21:11:57 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix: remove double/unintended free (#1143)

Browse Source 
The call to realloc() already frees the previously allocated memory if necessary.
By the man page of realloc(): "f the area pointed to was moved, a free(ptr) is done.",
and free(): "If free(ptr) has already been called before, undefined behavior occurs.".
This commit is contained in:
Enzo Veroneze 2022-11-10 02:19:01 -03:00 committed by GitHub
parent 68bdbfb0a5
commit 1b3a1ca91e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
data_structures/dynamic_array/dynamic_array.c
View File

@ -18,7 +18,6 @@ void *add(dynamic_array_t *da, const void *value)
{ {
void **newItems = void **newItems =
realloc(da->items, (da->capacity <<= 1) * sizeof(void **)); realloc(da->items, (da->capacity <<= 1) * sizeof(void **));
free(da->items);
da->items = newItems; da->items = newItems;
} }
@ -79,4 +78,4 @@ void *retrive_copy_of_value(const void *value)
memcpy(value_copy, value, sizeof(void *)); memcpy(value_copy, value, sizeof(void *));
return value_copy; return value_copy;
} }