From 2e667a8be93525a73080547eda33f222c3dcad53 Mon Sep 17 00:00:00 2001
From: Sam Lantinga <slouken@libsdl.org>
Date: Mon, 30 Mar 2020 14:26:10 -0700
Subject: [PATCH] Fix incorrectly terminated MakeThreadHighPriority dbus
message
Currently the message is double terminated, which results in SDL_DBus_CallMethodInternal()
incorrectly assuming that the other party is always returning true.
I'm not super familiar with dbus, so I'm not sure if this could also be the cause of this bug:
https://github.com/ValveSoftware/steam-for-linux/issues/6901
---
src/core/linux/SDL_threadprio.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/core/linux/SDL_threadprio.c b/src/core/linux/SDL_threadprio.c
index 2cbc4cb48..61512cbd8 100644
--- a/src/core/linux/SDL_threadprio.c
+++ b/src/core/linux/SDL_threadprio.c
@@ -68,8 +68,7 @@ rtkit_setpriority(pid_t thread, int nice_level)
if (!dbus || !SDL_DBus_CallMethodOnConnection(dbus->system_conn,
RTKIT_DBUS_NODE, RTKIT_DBUS_PATH, RTKIT_DBUS_INTERFACE, "MakeThreadHighPriority",
- DBUS_TYPE_UINT64, &ui64, DBUS_TYPE_INT32, &si32, DBUS_TYPE_INVALID,
- DBUS_TYPE_INVALID)) {
+ DBUS_TYPE_UINT64, &ui64, DBUS_TYPE_INT32, &si32, DBUS_TYPE_INVALID)) {
return SDL_FALSE;
}
return SDL_TRUE;