mirrors/Nuklear
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix undefined behavior in strncpy() call

Browse Source 
`strncpy()`'s pointer parameters are marked `restrict`, but when
`file_browser_reload_directory_content()` was being called to reload
the directory it already had open, it would try to copy its path
buffer to itself, causing undefined behavior.
This commit is contained in:
Victor Chernyakin 2023-12-18 22:45:59 -07:00
parent 544009db92
commit 3793609e39
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
example/file_browser.c
View File

@ -345,7 +345,8 @@ media_init(struct media *media)
static void
file_browser_reload_directory_content(struct file_browser *browser, const char *path)
{
strncpy(browser->directory, path, MAX_PATH_LEN);
const size_t path_len = strlen(path) + 1;
memmove(browser->directory, path, MIN(path_len, MAX_PATH_LEN));
browser->directory[MAX_PATH_LEN - 1] = 0;
dir_free_list(browser->files, browser->file_count);
dir_free_list(browser->directories, browser->dir_count);