FreeRDP/libfreerdp/primitives
akallabeth 7beda29158 Fixed CodeQL warnings
(cherry picked from commit 95a9e60827)
2021-03-12 12:41:44 +01:00
..
test Fixed unit tests run under memory sanitizer 2021-02-25 09:51:41 +01:00
prim_add_opt.c Reformatted to new style 2019-11-07 10:53:54 +01:00
prim_add.c Reformatted to new style 2019-11-07 10:53:54 +01:00
prim_alphaComp_opt.c Remove symbols exported by accident. 2019-12-02 10:57:31 +01:00
prim_alphaComp.c Reformatted to new style 2019-11-07 10:53:54 +01:00
prim_andor_opt.c Reformatted to new style 2019-11-07 10:53:54 +01:00
prim_andor.c Reformatted to new style 2019-11-07 10:53:54 +01:00
prim_colors_opt.c Modified primitives function pointer to take const pointer to const data 2019-11-14 10:46:24 +01:00
prim_colors.c Ignore alpha channel during color conversion. 2021-02-25 09:51:41 +01:00
prim_copy.c Fixed CodeQL warnings 2021-03-12 12:41:44 +01:00
prim_internal.h Ignore alpha channel during color conversion. 2021-02-25 09:51:41 +01:00
prim_set_opt.c Reformatted to new style 2019-11-07 10:53:54 +01:00
prim_set.c Reformatted to new style 2019-11-07 10:53:54 +01:00
prim_shift_opt.c Fixed undefined behaviour in primitives shift 2020-05-18 17:10:01 +02:00
prim_shift.c Fixed undefined behaviour in primitives shift 2020-05-18 17:10:01 +02:00
prim_sign_opt.c Reformatted to new style 2019-11-07 10:53:54 +01:00
prim_sign.c Reformatted to new style 2019-11-07 10:53:54 +01:00
prim_templates.h Fixed undefined behaviour in primitives shift 2020-05-18 17:10:01 +02:00
prim_YCoCg_opt.c Fixed #5855: YCoCg to RGB conversion color order 2020-01-22 17:28:22 +01:00
prim_YCoCg.c Ignore alpha channel during color conversion. 2021-02-25 09:51:41 +01:00
prim_YUV_neon.c Modified primitives function pointer to take const pointer to const data 2019-11-14 10:46:24 +01:00
prim_YUV_opencl.c primitives: use host pointers for openCL 2019-11-29 11:59:09 +01:00
prim_YUV_ssse3.c Ignore alpha channel during color conversion. 2021-02-25 09:51:41 +01:00
prim_YUV.c Ignore alpha channel during color conversion. 2021-02-25 09:51:41 +01:00
primitives.c Fixed CodeQL warnings 2021-03-12 12:41:44 +01:00
primitives.cl Added YUV444 kernel 2019-11-22 13:21:39 +01:00
README.txt primitives: make use of winprs processor feature detection 2013-03-01 09:02:14 +01:00

The Primitives Library

Introduction
------------
The purpose of the primitives library is to give the freerdp code easy
access to *run-time* optimization via SIMD operations.  When the library
is initialized, dynamic checks of processor features are run (such as
the support of SSE3 or Neon), and entrypoints are linked to through
function pointers to provide the fastest possible operations.  All
routines offer generic C alternatives as fallbacks.

Run-time optimization has the advantage of allowing a single executable
to run fast on multiple platforms with different SIMD capabilities.


Use In Code
-----------
A singleton pointing to a structure containing the function pointers
is accessed through primitives_get().   The function pointers can then
be used from that structure, e.g.

    primitives_t *prims = primitives_get();
    prims->shiftC_16s(buffer, shifts, buffer, 256);

Of course, there is some overhead in calling through the function pointer
and setting up the SIMD operations, so it would be counterproductive to
call the primitives library for very small operation, e.g. initializing an
array of eight values to a constant.  The primitives library is intended
for larger-scale operations, e.g. arrays of size 64 and larger.


Initialization and Cleanup
--------------------------
Library initialization is done the first time primitives_init() is called
or the first time primitives_get() is used.  Cleanup (if any) is done by
primitives_deinit().


Intel Integrated Performance Primitives (IPP)
---------------------------------------------
If freerdp is compiled with IPP support (-DWITH_IPP=ON), the IPP function
calls will be used (where available) to fill the function pointers.
Where possible, function names and parameter lists match IPP format so
that the IPP functions can be plugged into the function pointers without
a wrapper layer.  Use of IPP is completely optional, and in many cases
the SSE operations in the primitives library itself are faster or similar
in performance.


Coverage
--------
The primitives library is not meant to be comprehensive, offering
entrypoints for every operation and operand type.  Instead, the coverage
is focused on operations known to be performance bottlenecks in the code.
For instance, 16-bit signed operations are used widely in the RemoteFX
software, so you'll find 16s versions of several operations, but there
is no attempt to provide (unused) copies of the same code for 8u, 16u,
32s, etc.


New Optimizations
-----------------
As the need arises, new optimizations can be added to the library,
including NEON, AVX, and perhaps OpenCL or other SIMD implementations.
The CPU feature detection is done in winpr/sysinfo.


Adding Entrypoints
------------------
As the need for new operations or operands arises, new entrypoints can
be added.  
  1) Function prototypes and pointers are added to 
     include/freerdp/primitives.h
  2) New module initialization and cleanup function prototypes are added
     to prim_internal.h and called in primitives.c (primitives_init()
     and primitives_deinit()).
  3) Operation names and parameter lists should be compatible with the IPP.
     IPP manuals are available online at software.intel.com.
  4) A generic C entrypoint must be available as a fallback.
  5) prim_templates.h contains macro-based templates for simple operations,
     such as applying a single SSE operation to arrays of data.
     The template functions can frequently be used to extend the
     operations without writing a lot of new code.

Cache Management
----------------
I haven't found a lot of speed improvement by attempting prefetch, and
in fact it seems to have a negative impact in some cases.  Done correctly
perhaps the routines could be further accelerated by proper use of prefetch,
fences, etc.


Testing
-------
In the test subdirectory is an executable (prim_test) that tests both
functionality and speed of primitives library operations.   Any new
modules should be added to that test, following the conventions already
established in that directory.  The program can be executed on various
target hardware to compare generic C, optimized, and IPP performance
with various array sizes.