28923ddd75
A proxy URI was parsed both in the function `proxy_read_environment()` in `libfreerdp/core/proxy.c` and in the function `freerdp_client_settings_parse_command_line_arguments()` in `client/common/cmdline.c`. But only the latter was taking into account that the URI can contain a user and password, which made it impossible to use a proxy with authentication by just using an environment variable like `https_proxy`. The function `proxy_parse_uri()` in `libfreerdp/core/proxy.c` was clearly not parsing the optional username and password. This commit moves the code from `client/common/cmdline.c` to `libfreerdp/common/settings.c` into a function `proxy_parse_uri()` so redundant code is avoided. This function is then called in both instances where a proxy URI is parsed. Some minor adjustment were made to the code, so the `WLog_INFO()` statement at the end works in both cases, where credentials were either provided or not. Also, some error messages were added or clarified. If the parsing of the environment variable fails, we ignore it entirely (with a warning) and proceed. |
||
|---|---|---|
| .github | ||
| channels | ||
| ci/cmake-preloads | ||
| client | ||
| cmake | ||
| compat/stdbool | ||
| docs | ||
| external | ||
| include | ||
| libfreerdp | ||
| packaging | ||
| rdtk | ||
| resources | ||
| scripts | ||
| server | ||
| third-party | ||
| tools | ||
| uwac | ||
| winpr | ||
| .clang-format | ||
| .gitignore | ||
| .travis.yml | ||
| ChangeLog | ||
| CMakeCPack.cmake | ||
| CMakeCPackOptions.cmake.in | ||
| CMakeLists.txt | ||
| LICENSE | ||
| README.md | ||
| SECURITY.md | ||
FreeRDP: A Remote Desktop Protocol Implementation
FreeRDP is a free implementation of the Remote Desktop Protocol (RDP), released under the Apache license. Enjoy the freedom of using your software wherever you want, the way you want it, in a world where interoperability can finally liberate your computing experience.
Resources
Project website: https://www.freerdp.com/
Issue tracker: https://github.com/FreeRDP/FreeRDP/issues
Sources: https://github.com/FreeRDP/FreeRDP/
Downloads: https://pub.freerdp.com/releases/
Wiki: https://github.com/FreeRDP/FreeRDP/wiki
API documentation: https://pub.freerdp.com/api/
Matrix room : #FreeRDP:matrix.org (main) XMPP channel: #FreeRDP#matrix.org@matrix.org (bridged) IRC channel : #freerdp @ irc.oftc.net (bridged) Mailing list: https://lists.sourceforge.net/lists/listinfo/freerdp-devel
Microsoft Open Specifications
Information regarding the Microsoft Open Specifications can be found at: https://www.microsoft.com/openspecifications/
A list of reference documentation is maintained here: https://github.com/FreeRDP/FreeRDP/wiki/Reference-Documentation
Compilation
Instructions on how to get started compiling FreeRDP can be found on the wiki: https://github.com/FreeRDP/FreeRDP/wiki/Compilation