Ilya Shipitsin
5d7186258a
libfreerdp/codec/include/bitmap.c: resolve possible NULL pointer arithmetic
...
found by cppcheck
[libfreerdp/codec/include/bitmap.c:112] -> [libfreerdp/codec/include/bitmap.c:95]: (warning) Either the condition '!pbSrcBuffer' is redundant or there is pointer arithmetic with NULL pointer.
[libfreerdp/codec/include/bitmap.c:112] -> [libfreerdp/codec/include/bitmap.c:96]: (warning) Either the condition '!pbDestBuffer' is redundant or there is pointer arithmetic with NULL pointer.
2019-02-22 17:18:19 +05:00
Armin Novak
dfb4a411d4
Silenced unused-const-variables for test cases.
2019-02-21 14:02:13 +01:00
Armin Novak
43e13bdfac
Fixed all integer conversion warnings for OpenH264.
...
Added range checks and casts to integer where necessary
to remove warnings.
2019-02-21 11:43:59 +01:00
Armin Novak
2a582ed197
Fixed NULL dereferences and uninitialized values
2019-01-30 16:11:10 +01:00
Armin Novak
7b92b91d9a
Fixed warnings found by compiler and static analysis.
2019-01-24 11:53:52 +01:00
Armin Novak
ac12adda93
Fixed warnings found by compiler and static analysis.
2019-01-24 11:53:52 +01:00
Armin Novak
8c41bd21ea
Added version check for dynamic OpenH264 use.
2019-01-15 09:49:48 +01:00
Armin Novak
1c855068a2
Using runtime linking for OpenH264.
...
This allows removing the hard dependency on OpenH264 and use the
cisco provided binary.
2019-01-11 12:00:08 +01:00
Armin Novak
6a175d588f
Fixed #5167 : Memory leak in unit test.
2019-01-08 11:20:00 +01:00
Ilya Shipitsin
bdc039e719
resolve several issues found by cppcheck
...
[client/X11/xf_floatbar.c:800] -> [client/X11/xf_floatbar.c:796]: (warning) Either the condition '!floatbar' is redundant or there is possible null pointer dereference: floatbar.
[client/X11/xf_floatbar.c:800] -> [client/X11/xf_floatbar.c:797]: (warning) Either the condition '!floatbar' is redundant or there is possible null pointer dereference: floatbar.
[client/X11/xf_floatbar.c:800] -> [client/X11/xf_floatbar.c:798]: (warning) Either the condition '!floatbar' is redundant or there is possible null pointer dereference: floatbar.
[libfreerdp/codec/dsp.c:1156] -> [libfreerdp/codec/dsp.c:1154]: (warning) Either the condition '!srcFormat' is redundant or there is possible null pointer dereference: srcFormat.
[channels/drdynvc/client/drdynvc_main.c:1453] -> [channels/drdynvc/client/drdynvc_main.c:1450]: (warning) Either the condition '!drdynvc' is redundant or there is possible null pointer dereference: drdynvc.
[channels/audin/client/opensles/audin_opensl_es.c:98] -> [channels/audin/client/opensles/audin_opensl_es.c:94]: (warning) Either the condition '!opensles' is redundant or there is possible null pointer dereference: opensles.
[channels/audin/client/opensles/audin_opensl_es.c:159] -> [channels/audin/client/opensles/audin_opensl_es.c:153]: (warning) Either the condition '!opensles' is redundant or there is possible null pointer dereference: opensles.
2019-01-02 20:35:24 +05:00
Martin Fleisz
97c5210dbc
Merge pull request #5096 from akallabeth/dsp_channel_mix
...
Fix #5019 : Added channel up/downmixing code for mono/stereo.
2018-12-10 11:58:43 +01:00
Martin Fleisz
30b31b7fb0
Merge pull request #5062 from akallabeth/init_freerdp_image_copy_from_pointer_data
...
Fix #5061 : Initialize output buffer transparent.
2018-12-05 10:57:43 +01:00
Armin Novak
e46575671c
Fix #5019 : Added channel up/downmixing code for mono/stereo.
2018-12-04 11:38:42 +01:00
David Fort
579a13b054
remotefx: don't require data messages to come all in one chunk
...
The spec doesn't require that FRAME_BEGIN, REGION, TILESET, and FRAME_END come all in one
chunk. This patch adds the necessary state saving.
A unitary test is also added.
2018-12-04 11:38:01 +01:00
Armin Novak
d27cd1b19e
Fixed unit tests, use uniqe file names
2018-12-04 08:45:41 +01:00
Armin Novak
c97d4eec67
Fixed uninitialized value.
2018-11-29 11:25:27 +01:00
Armin Novak
0d8a1e1083
Fix #5061 : Initialize output buffer transparent.
2018-11-23 10:57:17 +01:00
Armin Novak
17c363a516
Fixed CVE-2018-8784
...
Thanks to Eyal Itkin from Check Point Software Technologies.
2018-11-20 11:08:31 +01:00
Armin Novak
d1112c279b
Fixed CVE-2018-8788
...
Thanks to Eyal Itkin from Check Point Software Technologies.
2018-11-20 11:08:31 +01:00
Armin Novak
602f4a2e14
Fixed CVE-2018-8785
...
Thanks to Eyal Itkin from Check Point Software Technologies.
2018-11-20 11:08:31 +01:00
Armin Novak
d2e1248b09
Fixed profiler API
...
* Duplicate the name internally to avoid issues with stack
* Made API opaque and removed direct dereferencing of struct.
2018-11-16 09:32:15 +01:00
Bernhard Miklautz
010e3485cb
Merge pull request #4989 from akallabeth/dsp_encode_resample
...
Added resampling to freerdp_dsp_encode.
2018-11-15 15:54:56 +00:00
Bernhard Miklautz
d6dea852b3
Merge pull request #4976 from hardening/rfx_flush
...
remotefx: fix rlgr last bits of encoder
2018-11-15 15:25:25 +00:00
Armin Novak
9766161f10
Added missing define guards.
2018-11-14 13:27:20 +01:00
Armin Novak
5b363e72aa
Allow building without libsoxr support.
2018-11-14 13:27:20 +01:00
Armin Novak
6af56458ad
Marked custom ADPCM codecs experimental.
2018-11-14 13:27:20 +01:00
Armin Novak
b362b61a1a
Added libsoxr based resampling.
2018-11-14 13:27:20 +01:00
Armin Novak
ab15e34032
Refactored freerdp_dsp_resample, checks now done internally.
2018-11-14 13:27:20 +01:00
Armin Novak
60025dde8e
Fixed unused function warnings when FFMPEG backend is used.
2018-11-14 13:27:20 +01:00
Armin Novak
e8e4800c5e
Added resampling to freerdp_dsp_encode.
2018-11-14 13:27:20 +01:00
Bernhard Miklautz
c5c1bac31a
Merge pull request #4960 from akallabeth/interleaved_fix
...
Fixed #4954 : Check destination buffer bounds.
2018-11-09 12:25:55 +00:00
Armin Novak
fff2454ae6
Make VS2010 happy, reworked UNROLL defines.
2018-11-09 12:18:51 +01:00
Armin Novak
6e61dd9d9f
Unroll bBits loops as well.
2018-11-09 12:12:19 +01:00
Armin Novak
7e932bbfa2
Readded loop unrolling.
2018-11-09 11:32:28 +01:00
Armin Novak
cf8bc72dc4
Fixed profiler naming in tests.
2018-11-08 17:43:50 +01:00
Armin Novak
9e2c203771
Fixed various issues with freerdp_bitmap_compress and interleaved_compress
2018-11-08 17:21:28 +01:00
Armin Novak
c0c1d064be
Added a unit test for interleaved codec compression.
2018-11-08 17:20:31 +01:00
Armin Novak
a544776bd8
Simplified code, moved bounds check out of loops.
2018-11-07 13:10:23 +01:00
Armin Novak
10d3ee131e
Fixed #4954 : Check destination buffer bounds.
2018-11-07 12:18:08 +01:00
Bernhard Miklautz
37f8181735
fix [libfreerdp/codec]: heap buffer overflow in TestFreeRDPCodecClear
...
The examples and the allocated buffers assume that the destination
starts with x 0 and y 0 and not 1/1.
2018-11-05 15:43:12 +01:00
David Fort
af195864e5
remotefx: fix rlgr last bits of encoder
...
The last bits of the bitstream were not flushed in the output, this patch fixes it.
2018-10-31 10:42:04 +01:00
Norbert Federa
0572572eb9
fix issue with fnObjectFree and related casts
...
- remove unnecessary/dangerous OBJECT_xxx function-style casts
- fix -Wstrict-prototypes issue with OBJECT_NEW_FN definition
2018-10-19 11:30:01 +02:00
Martin Fleisz
e46d1d95ff
Merge pull request #4926 from akallabeth/primary_order_checks
...
Order data validation and correction
2018-10-17 16:02:28 +02:00
Armin Novak
bbcba568f4
Added parameter checks.
2018-10-16 17:23:24 +02:00
Armin Novak
d2e08c0aa8
Fixed missing argument check.
2018-10-16 17:14:56 +02:00
Armin Novak
91107beb67
Separate alpha handling for planar codec
...
If the destination does not support an alpha channel ignore it
when decoding and prevent data to be copied unnecessarily
2018-10-16 12:17:25 +02:00
Armin Novak
a29bc16af4
Siplified planar alpha / non alpha paths
2018-10-16 10:05:33 +02:00
Martin Fleisz
00af869cd3
Merge pull request #4889 from akallabeth/shadow_server_audin_refactor
...
Shadow server audin refactor
2018-10-08 12:56:09 +02:00
akallabeth
9cc4f844c4
Merge pull request #4912 from akallabeth/swresample
...
Swresample support with avresample fallback
2018-10-05 11:00:13 +02:00
Armin Novak
fbe95209e7
Readded AVRESAMPLE support as fallback.
2018-10-04 09:16:34 +02:00