mirrors
/
FreeRDP
mirror of https://github.com/FreeRDP/FreeRDP
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
14,424 Commits 6 Branches 73 Tags 86 MiB
Commit Graph

195 Commits

Author SHA1 Message Date
Armin Novak ff79636d33 TSG improvements 
* Respect connection timeout during connect
* Better debug output
* Cleaned up data types,
 2020-06-19 11:31:13 +02:00
akallabeth a1f2c1e161 Fixed #6156: Enforce synchronized encrypt count 
Old style RDP encryption uses a counter, synchronize this for
packets send from different threads.
 2020-05-12 15:34:57 +02:00
akallabeth daf4e11324 Silence valgrind in rdp_read_header 
If a disconnect message is received, we returned success but did
not initialize the return arguments.
 2020-05-08 11:04:03 +02:00
akallabeth 6f00add067 Export remaining packet length from rdp_read_share_control_header 2020-04-06 13:18:35 +02:00
akallabeth 0ad894adbc Fixed substream read in rdp_recv_tpkt_pdu 2020-04-06 11:58:48 +02:00
akallabeth 0533c05be3 Fixed rdp_recv_tpkt_pdu parsing, use substream. 2020-04-06 11:22:18 +02:00
akallabeth 2a379bfe09 Fixed invalid seek size in patrial pdu parse case 2020-04-02 17:41:49 +02:00
akallabeth 9301bfe730 Fixed #6007: Boundary checks in rdp_read_flow_control_pdu 2020-04-02 17:27:53 +02:00
Armin Novak 4216646746 Fixed length checks for compressed rdp data. 2020-03-10 14:05:10 +01:00
Armin Novak c7187928e9 Fix tpkt header length checks for encrypted packets 
If securityFlag SEC_ENCRYPT is set, remove the encryption headers from
the TPKT header length on comparison.
 2020-03-10 12:20:50 +01:00
Armin Novak f1098aa17c rdp_recv_tpkt_pdu verbose debug parsing issues 
Print out parsing issues found in MCS Channel 1003 parsing.
 2020-03-05 13:48:58 +01:00
Armin Novak 0f729d2b2c Fixed conversion and return checks. 
* Fix some missing argument checks for function pointer implementations
* Fix broken return value check for client->SendChannelData
* Updated const correctness for function pointer implementations
 2020-03-04 14:44:03 +01:00
Armin Novak be714d2a13 Fixed tpkt header length checks. 
TPKT header length and consumption of data was not consistently
checked. This adds checks after each packet processed and fixes
any inconsistencies found.
 2020-03-02 11:40:35 +01:00
Armin Novak 318cb3dd47 Added tpkt header length plausibility checks. 2020-03-02 11:40:35 +01:00
Kobi Mizrachi 457d5e426c Revert "core: rdp: reset rdp->nla in rdp_reset" 
This reverts commit 205b0fba7f.
 2020-01-21 12:08:39 +01:00
Kobi Mizrachi 205b0fba7f core: rdp: reset rdp->nla in rdp_reset 2020-01-16 08:46:24 +01:00
Armin Novak 105799de31 Added an error message in rdp_set_error_info 
If the provided arguments are not properly set up write
an error message explaining what is wrong.

Signed-off-by: Armin Novak <armin.novak@thincast.com>
 2020-01-08 17:51:00 +01:00
Armin Novak 7d252cdc8e Added freerdp_set_last_error_ex function 
This new function allows better logging of call locations
for errors. Additionally added freerdp_set_error_log macro
to record function, file and line the error was set.

Signed-off-by: Armin Novak <armin.novak@thincast.com>
 2020-01-08 17:39:25 +01:00
xie.kunming e16bef6b4f rdp.c : fix DATA_PDU_TYPE_STRINGS mismatch declaration when WITH_DEBUG_ALL=ON 2019-12-16 12:14:59 +01:00
Armin Novak 7c243da6e1 Remove symbols exported by accident. 2019-12-02 10:57:31 +01:00
Armin Novak 72ca88f49c Reformatted to new style 2019-11-07 10:53:54 +01:00
David Fort 824d09169e rdp: fix byte and packet counters 
Best to count bytes directly at the transport level.
 2019-11-04 07:39:35 +01:00
David Fort bd5a88e95a rdp: count in/out bytes and packets 2019-10-23 09:16:35 +02:00
Armin Novak 6100273089 Reset fastpath on disconnect, fixes #5629 2019-10-02 10:21:48 +02:00
Armin Novak b036fd7a7d Return a proper error if redirection fails. 2019-08-12 12:33:06 +02:00
kubistika cd135ceacb libfreerdp/core: Export monitor layout PDU 
* Move update notification related functions to new display.c: Not
related to `rdp.c`.
    * Rename `rdp_write_monitor_layout_pdu` to `display_write_monitor_layout_pdu`.
* Add internal `display_convert_rdp_monitor_to_monitor_def` instead of
doing the conversion inside `display_write_monitor_layout_pdu`.
 2019-06-03 14:30:17 +03:00
Armin Novak f51a9bafcc Fixed sign-compare warnings 2019-04-05 09:13:24 +02:00
Armin Novak 1930bf69dd Replaced hardcoded xfreerdp program name 2019-02-12 10:53:37 +01:00
David Fort 53c74beadc rdp: add a callback for ServerStatusInfo 2019-01-29 10:33:06 +01:00
Armin Novak 8110c391bf Fixed requested protocol define names according to spec. 2018-12-05 10:55:06 +01:00
Armin Novak 82863a8518 Refactored NLA to be self contained. 2018-12-05 10:55:06 +01:00
Armin Novak 5ca8eca18e Made nego self contained. 2018-12-05 10:55:06 +01:00
Armin Novak 991f051a63 Fixed stream release for transport_write 2018-10-17 14:55:55 +02:00
Armin Novak 9516c251c7 Made TSG struct opaque 2018-09-28 12:00:45 +02:00
rbarnett 5d3e76bd80 Replace cryptic names; move the disconnect ultimatum reasons enum into public API and rename; remove setter 2018-09-19 09:36:39 -05:00
rbarnett 8458266183 Store the disconnect provider ulimatum reason in a new field in struct rdp_context and move the test for a logoff reason to xf_client.c 2018-09-18 15:31:10 -05:00
rbarnett 5db0b57fcd Map a particular disconnect situation triggered by a user logging off to a user logoff code. 2018-09-14 09:54:35 -05:00
Armin Novak 328eba7fe9 Fix #4752: Provide message free function for channel queue. 2018-07-18 15:31:07 +02:00
Martin Fleisz 80a49f46dc
Merge pull request #4320 from ondrejholy/coverity-fixes 
Coverity Scan fixes
 2017-12-20 14:17:20 +01:00
David Fort 2a6c9e1b87 Add an activated event and a Timer event 
Added an event that is triggered when the activation sequence is finished.
We also define a timer event that is neat to have for regular operation.
 2017-12-19 15:21:15 +01:00
Ondrej Holy 4791970c09 core: Remove redundant stream position changes 
Stream_Seek() is used, but consequently Stream_SetPosition() is used
for position obtained by Stream_GetPosition() immediatelly before
Stream_Seek(). Let's remove this stream position changes due to its
redundancy.
 2017-12-19 13:02:55 +01:00
David Fort 41823080f9 Fix users of Stream_GetPosition() that returns size_t 2017-12-11 22:38:58 +01:00
David Fort 11ee81be60 Fix XRandr for old systems and MacOSX 
We need a recent enough version of XRandr to correctly detect monitor.
Also this patch adds some typo or style fixes.
 2017-12-08 10:59:38 +01:00
David Fort a132922376 Add checks for DR channel 2017-10-04 10:30:47 +02:00
Armin Novak 8292b4558f Fix TALOS issues 
Fix the following issues identified by the CISCO TALOS project:
 * TALOS-2017-0336 CVE-2017-2834
 * TALOS-2017-0337 CVE-2017-2834
 * TALOS-2017-0338 CVE-2017-2836
 * TALOS-2017-0339 CVE-2017-2837
 * TALOS-2017-0340 CVE-2017-2838
 * TALOS-2017-0341 CVE-2017-2839
 2017-07-20 09:28:47 +02:00
Armin Novak 22f1fbe3d2 Fixed missing external declaration (#3982) 2017-05-31 11:44:33 +02:00
Armin Novak b1d631f1e5 Added support for Set Keyboard IME Status 2017-05-12 09:43:58 +02:00
Martin Fleisz 68a9408249 core: Get rid of useless settings copy 2017-02-15 14:59:24 +01:00
Norbert Federa f71b6b46e8 fix string format specifiers 
- fixed invalid, missing or additional arguments
- removed all type casts from arguments
- added missing (void*) typecasts for %p arguments
- use inttypes defines where appropriate
 2016-12-16 13:48:43 +01:00
Armin Novak a1b2325c1d Ensure securityFlags are always initialized. 2016-12-02 12:04:53 +01:00