bjcollins
ee3b39d70f
Remove unnecessary variable to keep track of nlaFailure, instead just set the NLA authentication error in the callback
...
where it is detected.
2015-09-15 14:17:13 -05:00
bjcollins
be47c6f782
Remove unused functions from initial code to handle NLA authentication failures.
2015-09-15 14:07:14 -05:00
bjcollins
7fbc7e45a7
Clean up NLA authentication failure handling code
...
1. Make use of freerdp_set_last_error to set authentication failure without the helper functions
2. Rename ssl callback function
3. Break out AuthenticationOnly exit handling from bad connect handling
2015-09-15 14:07:14 -05:00
bjcollins
32a1406dc4
Return FREERDP_ERROR_AUTHENTICATION_FAILED on an authentication failure
...
when using NLA with xfreerdp.
2015-09-15 14:07:14 -05:00
MartinHaimberger
2b2af6c9ea
Merge pull request #2886 from clangm/master
...
Fix Network Characteristics Autodetect [RDPBCGR 2.2.14]
2015-09-15 15:16:37 +02:00
MartinHaimberger
db2ce49a98
Merge pull request #2763 from akallabeth/nla_null_auth
...
Fixed server and client NLA state machine for NULL identity.
2015-09-15 14:53:55 +02:00
clangm
ac089f8a3f
Removed if statement that was causing network characteristics autodetect to not work
2015-09-11 15:01:31 -06:00
MartinHaimberger
d971116457
Merge pull request #2765 from akallabeth/connect_abort
...
Connect abort and unified TCP connect
2015-09-07 10:05:24 +02:00
Armin Novak
4d77f2a4c8
Fixed CreateProcess argument initialisation.
2015-09-05 18:55:08 +02:00
Armin Novak
91d318ba7b
Enable RFX for test connection, now required by sample server.
2015-09-05 17:00:27 +02:00
Armin Novak
f7a11a0ed8
Resetting abortEvent on disconnect to avoid race during connect.
2015-09-05 16:26:46 +02:00
Armin Novak
01496f474f
Fixed error handling for rdp_client_connect fail.
2015-09-05 16:26:29 +02:00
Armin Novak
7d8ab23877
WSAEvent fixes ported from realjiangms pull 2870.
2015-09-05 15:18:01 +02:00
Armin Novak
188fe4ed2b
Removed rdp disconnect, using unified abortEvent instead.
2015-09-05 14:57:30 +02:00
Armin Novak
3b8043264f
Resetting channel error on connect.
2015-09-03 13:46:17 +02:00
Bernhard Miklautz
1f13781fe1
Merge pull request #2855 from akallabeth/memleak_fixes
...
Memleak fixes
2015-08-31 09:50:21 +02:00
Armin Novak
893e7a35a8
Fixed broken cleanup code.
2015-08-31 09:13:15 +02:00
Bernhard Miklautz
05c02da742
settings: update settings/help to match
...
* wallpaper was off but help said "default: on"
* compression is on but help said "default: off"
Fixes #2853
2015-08-28 11:09:38 +02:00
Armin Novak
dd9d66a3e6
Fixed NONNULL argument warnings.
2015-08-28 10:59:48 +02:00
Armin Novak
07bba9b623
Fixed NONNULL argument warnings.
2015-08-28 10:58:20 +02:00
Armin Novak
c3a1f56f77
Resetting signals on freerdp_connect.
2015-08-27 15:53:37 +02:00
Armin Novak
fda56c0dbb
Added missing NULL pointer checks.
2015-08-27 15:33:06 +02:00
Armin Novak
7ebf4879f0
Fixed uninitialised events.
2015-08-27 15:33:06 +02:00
Armin Novak
4cfd7a48cd
Aborting transport layer now if requested.
2015-08-27 15:33:06 +02:00
Armin Novak
134a16d522
Fixed WSAEventSelect mode reset.
2015-08-27 15:33:06 +02:00
Armin Novak
1cbeb10074
Added unit test for freerdp_connect
...
* Tests connection to not existing host (timeout)
* Tests connection to not exising host with abort.
* Tests connection to sfreerdp-server on localhost.
2015-08-27 15:33:06 +02:00
Armin Novak
e6c23cb534
Implemented Async TCP connect with abort event
...
* Implemented unified freerdp_tcp_connect_timeout with connect abort.
* Implemented unified freerdp_tcp_connect_multi with connect abort.
* Added connect abort to freerdp_tcp_connect.
* Added freerdp_abort_connect and abortEvent.
2015-08-27 15:33:06 +02:00
Marc-André Moreau
223e0c7900
Merge pull request #2785 from MartinHaimberger/mh-channel-fix
...
Channel hardening and fixing
2015-08-27 09:24:10 -04:00
Martin Haimberger
52405a3e79
Remove WIN32ERROR type
...
All return values are UINT now.
2015-08-27 05:38:20 -07:00
Vic Lee
6f639c1e34
gcc: read and write desktop scale settings in core data.
2015-08-27 16:19:40 +08:00
Vic Lee
8394d8c677
gcc: read and write monitor extended data.
2015-08-27 15:26:37 +08:00
Martin Haimberger
420a86e1c7
Merge remote-tracking branch 'upstream/master' into mh-channel-fix
...
Conflicts:
channels/drdynvc/client/drdynvc_main.c
channels/rdpgfx/client/rdpgfx_main.c
client/X11/xf_gfx.c
2015-08-25 00:07:04 -07:00
Marc-André Moreau
d7329194fc
Merge branch 'master' of github.com:FreeRDP/FreeRDP
2015-08-04 11:55:38 -04:00
Martin Haimberger
2862109337
Merge remote-tracking branch 'upstream/master' into mh-channel-fix
...
Conflicts:
channels/smartcard/client/smartcard_main.c
channels/smartcard/client/smartcard_operations.c
2015-07-30 07:29:12 -07:00
Bernhard Miklautz
a22dc21c15
remdesk,encomps: misc fixes
...
* only free stream when an error occurs
* ignore unhanded messages instead of throwing an error
* fix memory leak in settings
2015-07-29 17:32:09 +02:00
Clive Stevens
99228ee254
Fix race condition in freerdp_channels_client_load
...
If g_pInterface is set to NULL outside the critical section in one thread
while another thread is in the critical section, the channel client context
allocated in the VirtualChannelEntry won't end up getting freed.
The channel client context is normally loaded from g_pInterface in
FreeRDP_VirtualChannelInit and stored in the pChannelInitData, then copied
from there onto the pChannelOpenData structure in FreeRDP_VirtualChannelOpen
and finally freed in freerdp_channels_free.
2015-07-29 14:26:33 +01:00
Marc-André Moreau
5cb06ecc68
Merge branch 'master' of github.com:FreeRDP/FreeRDP
2015-07-28 09:21:33 -04:00
Bernhard Miklautz
a342d40158
core/listner: fix possible problem in _free
2015-07-27 11:24:21 +02:00
Bernhard Miklautz
458d3b1593
transport: fix regression introduced with PR #2770
...
When the event is reset in transport_check_fds xfreerdp doesn't work and
consumes 100% CPU (see #2790 ). On windows this is require otherwise the
CPU consumption is 100% there.
This quick fix only resets the event on windows. It's a working approach
but definitely not the final solution.
2015-07-17 12:06:41 +02:00
Vic Lee
042cb250f3
Merge pull request #2770 from akallabeth/bio_event_reset
...
Resetting frontBio after read now.
2015-07-16 06:57:46 -07:00
Martin Haimberger
6ab0187d84
Merge remote-tracking branch 'upstream/master' into mh-channel
...
Conflicts:
channels/audin/client/oss/audin_oss.c
channels/drive/client/drive_main.c
channels/printer/client/printer_cups.c
channels/printer/client/printer_main.c
channels/rail/client/rail_main.c
channels/rdpgfx/client/rdpgfx_main.c
channels/rdpsnd/client/oss/rdpsnd_oss.c
channels/remdesk/client/remdesk_main.c
channels/remdesk/server/remdesk_main.c
channels/tsmf/client/tsmf_media.c
2015-07-15 01:57:07 -07:00
Martin Haimberger
b8c110d19b
introduced channel error reporting system
...
The rdpContext gets an event which will
get set if an error occoured in a channel.
If a thread or a void callback has to report an
error it will get signaled by this system.
2015-07-15 00:50:35 -07:00
Bernhard Miklautz
68e8569110
winpr/synch: remove the dependency on winsock.h
...
winsock.h pulls in a lot of defines and dependencies that are not
required and partially unwanted in winpr's core (for parts that are not
related to network). In order to get rid of this dependency and have an
independent defines for extended winpr functions the WINPR_FD_* defines
are used internally (and for exposed functions). Where required, like in
WSAEventSelect, the FD_* is mapped to WINPR_FD_*.
2015-07-14 11:39:41 +02:00
Armin Novak
098eda9873
Error checks for BIO_get_event
...
ResetEvent before reading data from transport BIO.
2015-07-09 12:20:22 +02:00
Armin Novak
18cea1c9ba
Replaced cbMaxSignature with cbSecurityTrailer
...
The token buffer size during authentication was constructed
from the wrong buffer size. These sizes are equal in case of
local account logins but differ with domain accounts.
2015-07-09 10:09:18 +02:00
Armin Novak
ecf6ffdcce
Fixed CompleteAuthToken return check.
2015-07-09 09:57:45 +02:00
Armin Novak
cb01e540ba
Fixed CompleteAuthToken return check.
2015-07-09 09:49:12 +02:00
Armin Novak
2fe5ecfc1b
Fixed wrong output in log messages.
2015-07-08 17:41:23 +02:00
Martin Fleisz
9a2d33af12
Fixed missing encrypt / decrypt success check.
...
The return of EncryptMessage and DecryptMessage was unchecked.
This lead to PLAINTEXT to be sent over the wire, a major security
issue.
2015-07-08 17:41:23 +02:00
Armin Novak
48ccf73a36
More SSPI logging.
2015-07-08 17:41:22 +02:00