1affbd0655
[coverity] 1543285 Resource leak
2024-04-11 12:04:07 +02:00
1e325dc2de
[core,settings] add missing autoreconnect option
...
Split settings, there was a double use for AutoReconnectEnabled.
AutoReconnectEnabled is a setting responsible for client side
autoreconnection.
AutoReconnectPacketSupported is a flag set by the server to announce
support for AutoReconnectPacket allowing fast reconnect.
2024-04-11 11:19:18 +02:00
14cdd6a105
location: Increase buffer size for printing channel info
...
The current buffer size of 32 bytes was too small to hold the version
info string which resulted in a non-null terminated buffer (_snprintf
does not null-terminate the buffer if it is too small) being printed.
2024-04-11 11:18:43 +02:00
2b7146575f
recreate codeql.yml
2024-04-11 11:04:08 +02:00
be9df8d62b
CI: add coverity scheduled workflow
2024-04-11 09:01:25 +02:00
f6a18d142d
[packaging,rpm] fix excludes
2024-04-10 11:22:36 +02:00
1f3a49c57a
libfreerdp/utils/http.c: fix resource leak
...
found by coverity
128 if (winpr_asprintf(&headers, &size, post_header_fmt, path, hostname, blen) < 0)
CID 424888: (#1 of 1): Resource leak (RESOURCE_LEAK)
15. leaked_storage: Variable hostname going out of scope leaks the storage it points to.
129 return FALSE;
130 }
2024-04-08 11:39:20 +02:00
822537be0e
channels/cliprdr/client/cliprdr_main.c: fix resource leak
...
found by coverity
655 if (Stream_Write_UTF16_String_From_UTF8(s, tmpDirCharLen - 1, tempDirectory->szTempDir,
656 ARRAYSIZE(tempDirectory->szTempDir), TRUE) < 0)
CID 424748: (#1 of 1): Resource leak (RESOURCE_LEAK)
9. leaked_storage: Variable s going out of scope leaks the storage it points to.
657 return ERROR_INTERNAL_ERROR;
658 /* Path must be 260 UTF16 characters with '\0' termination.
659 * ensure this here */
2024-04-08 11:39:20 +02:00
c7954ad0f3
channels/urbdrc/client/data_transfer.c: fix resource leak
...
found by coverity
705 if (transferDir == USBD_TRANSFER_DIRECTION_OUT)
706 {
18. Condition !Stream_CheckAndLogRequiredLengthEx("com.freerdp.channels.urbdrc.client" /* "com.freerdp.channels.urbdrc.client" */, 3, s, OutputBufferSize, 1, "%s(%s:%zu)" /* "%s(%s:%zu)" */, <anonymous>, "/home/runner/work/FreeRDP/FreeRDP/channels/urbdrc/client/data_transfer.c", 707UL /* (size_t)707 */), taking true branch.
707 if (!Stream_CheckAndLogRequiredLength(TAG, s, OutputBufferSize))
CID 424733: (#1 of 1): Resource leak (RESOURCE_LEAK)
19. leaked_storage: Variable out going out of scope leaks the storage it points to.
708 return ERROR_INVALID_DATA;
709 Stream_Copy(s, out, OutputBufferSize);
710 }
2024-04-08 11:39:20 +02:00
b3d8434578
[ci] do not run clang-tidy by scheduler
2024-04-08 11:38:02 +02:00
4b1bdc622a
[x11,client] always use current clipboard owner
2024-04-07 08:59:51 +02:00
0905796cd7
[core,gateway[ fix use after free
2024-04-06 09:17:17 +02:00
7efd75cb01
[client,wlfreerdp] use wm-class for app_id
2024-04-06 09:17:17 +02:00
25edec803b
libfreerdp/crypto/certificate.c: handle malloc error
2024-04-06 07:11:14 +02:00
8b2e13d989
[emu,scard] abort busy loop on session cancel
2024-04-05 13:06:57 +02:00
330fe90b21
[cmake] Fix warning in FindOSS.cmake
2024-04-05 13:06:57 +02:00
309509808c
libfreerdp/core/gateway/rdg.c: handle malloc failure
2024-04-05 09:59:12 +02:00
00cd1c7130
[cmake] do not set NO_SONAME
...
if set the linker might insert full paths to dependencies
2024-04-04 21:51:09 +02:00
f62a61886f
common: Parse actual value of redirectlocation rdp file setting
2024-04-04 21:20:39 +02:00
1b7e0ffb97
[core,smartcard] allow userhint to match UPN
...
the username might match the UPN of the smartcard certificate. If not
fall back to compare to userHint
2024-04-04 14:05:39 +02:00
4a56e2f74c
[winpr,kerberos] use profile_abandon
...
suggested by @greghudson to just release the profile and not flush
changes back to config file. See #9766
2024-04-03 15:37:43 +02:00
1956fffd3d
[build,mingw] fix build issues found
2024-04-03 11:53:58 +02:00
0712d0c899
[build,mac] check required tools are installed
2024-04-03 11:50:34 +02:00
ff92ef4331
[client,windows] clean up clipboard
2024-04-03 10:45:12 +02:00
be50010d1d
client/Windows/wf_cliprdr.c: handle malloc error
2024-04-03 10:45:12 +02:00
735cb1ec14
[cmake] fix mingw linking
2024-04-03 09:42:44 +02:00
e5799ec947
[locale,xkbfile] improve mapping
...
* Add missing keycodes to mapping
* Use sorted list to create mapping table
2024-04-03 08:22:25 +02:00
18612bb513
[mingw] fix missing shlwapi link
2024-04-02 09:31:55 +02:00
4b52dfd70c
Add #include to declare winpr_strerror
2024-04-01 09:31:57 +02:00
532a3cd1a9
Set res_class on classHints
2024-04-01 09:30:30 +02:00
d864393a8a
[client,X11] fix detection of need to use relative movements
...
Register XI raw masks when MouseUseRelativeMove enabled
Fix duplication of sent events (in previous implementation relative and absolute events were sent at the same time)
Slightly refactor code
2024-03-26 09:20:50 +01:00
8bd1e72dd4
[client,common] guard ainput access with correct guard
2024-03-26 09:20:35 +01:00
82dc655979
[core,gateway] improve warning for bad request
...
In case of E_PROXY_ORCHESTRATION_LB_SESSIONHOST_DEALLOCATED print a
warning with the message body or a generic fallback should that not be
provided.
2024-03-26 09:19:45 +01:00
c6dd5e45e0
[client,common] fix TS_RELPOINTER_EVENT sending logic
...
Send relative mouse events using TS_RELPOINTER_EVENT only when capability present
2024-03-22 20:15:24 +01:00
31a131b9e4
[crypto,cert] follow up to #10002
...
Ensure we always compare the lowercase hostname when looking for a
stored certificate or calculating a hash.
2024-03-21 15:07:58 +01:00
f98d0dd60a
[crypto,cert] allow NULL certificate
...
If a certificate can not be read and is NULL return NULL for all queries
on that NULL certificate. Fixes #10002
2024-03-21 14:26:37 +01:00
1b2f95dfde
[client,common] allow deactivating RAILS hidef mode
2024-03-21 14:26:14 +01:00
b596ad0d45
[common,settings] accept 'on|off' as bool settings
2024-03-21 14:26:14 +01:00
675ec01e97
[flatpak] build custom openssl
...
we need legacy providers or openssl 1.1.1 for compatibility with older
windows servers.
2024-03-20 15:04:31 +01:00
2359e3ff63
[flatpak] update permissions and dependencies
2024-03-20 15:04:31 +01:00
678ff144ab
[cmake] unify windows resource file generation
...
* use a macro to add resource files for executables and shared libraries
* use that macro to declare targets
* use that macro to set library/binary versioning
* use that macro to set target output name
* use a macro to create manpages and names
2024-03-20 11:17:18 +01:00
ea9e219867
[channels,rail] print handshakeEx flags
2024-03-20 10:00:57 +01:00
903172737a
[cmake] readd BSD related default include paths
2024-03-20 09:11:08 +01:00
09ff2966af
[cmake] unify BSD related configuration in PlatformDefaults.cmake
2024-03-20 09:11:08 +01:00
faf0c74029
[cmake] add posix requirements
2024-03-20 09:11:08 +01:00
92ed8b3916
[winpr,timezone] outside definition timezone file
...
allow defining the filepath of timezone file in buildsystem adjusting it
without a required code change.
2024-03-20 09:11:08 +01:00
f4b7c59915
[cmake] move platform defines to common include
...
* Move platform specific settings to a common CMake include
2024-03-20 09:11:08 +01:00
15cf6b26b1
[channesl,oss] fix OSS detection
...
* generate a include header depending on where the soundcard.h file was
found as that is in system paths that must not be added to the include
search paths.
* fix detection, the if/else was mixed up and completely broken.
2024-03-20 09:11:08 +01:00
1bf3f5335e
[winpr,file] clean up FileSetFileTime
...
* Split POSIX and BSD implementations
* Add stub for unuspported platforms
2024-03-20 09:11:08 +01:00
0106d34636
[core,gatewya] fix function argument type
2024-03-20 08:39:15 +01:00
akallabeth