Armin Novak
dec4cb4d73
Fixed rdpdr device name setting
2021-10-18 12:49:38 +02:00
Armin Novak
990400aedd
Close SVC channels in WTSVirtualChannelClose
2021-10-18 12:49:38 +02:00
Armin Novak
41d77cae46
Fixed /video buffer alignment, added assertions
2021-10-18 10:53:05 +02:00
Armin Novak
a1a7724b88
Fixed freerdp_image_fill scanline detection
2021-10-18 10:53:05 +02:00
Armin Novak
7d80c74e97
Cleaned up RDPDR channel interhitance
...
* All channels inheriting from RDPDR_DRIVE base struct
* Add functions to create/free a new device of a type
* Fixed settings array resize code, prevent 0 sizes
2021-10-18 09:21:02 +02:00
akallabeth
07b789c880
Gateway legacy parser fix ( #7362 )
...
* Implemented missing TSG debug functions
* Refactored RPC gateway parser
Utilize wStream instead of custom binary parsing code, add proper
input validation.
Reported by Sunglin from the Knownsec 404 team & 0103 sec team
2021-10-15 11:45:08 +02:00
Armin Novak
73fbbcf0fb
Fixed const warnings
2021-10-14 13:04:59 +02:00
Armin Novak
cf74a6ea3f
Fixed const cast warnings in generated settings setter
2021-10-14 13:04:59 +02:00
Armin Novak
07df48c91d
Removed unused variable
2021-10-14 13:04:59 +02:00
akallabeth
da3c1197a2
Fixed GFX alpha painting
2021-10-14 13:01:26 +02:00
akallabeth
3ccb96d52f
Fixed #7350 : Warnings with Stream_StaticInit
...
* Properly initialize the stream buffer
* Add Stream_StaticConstInit accepting a const buffer
* Modify API to return a pointer to the stream initialized
2021-10-14 12:11:16 +02:00
akallabeth
217e0caa18
Bitmap update fix ( #7349 )
...
* Added checks for bitmap width and heigth values
Data received from the server might have invalid values for bitmap
with or height. Abort parsing if such a value is found.
Reported by Sunglin from the Knownsec 404 team & 0103 sec team
* Added checks for glyph width & height
2021-10-12 12:26:22 +02:00
Hans-Peter Jansen
74d7b4c9b7
Add some ADDIN_PATH debug messages
2021-10-11 08:38:53 +02:00
akallabeth
51268bbcba
Lock updates during gdi_resize ( #7330 )
2021-10-07 10:25:09 +02:00
Armin Novak
33bc2ba2ab
Fixed static-in-line warnings
2021-10-06 09:49:07 +02:00
Armin Novak
18a3fcf2fc
Updated wStream API and added torough checks
...
* Do length/capacity checks in every read/write/seek function
if WINPR_ASSERT is defined.
* Ensure s->pointer is valid, e.g. within s->buffer + s->capacity
(Stream_Rewind, Stream_Seek, ...)
* Add return values to Stream_Set* functions so inalid arguments
can be reported to the caller
* Deprecated problematic stream manipulation functions
(Stream_SetBuffer, Stream_SetPointer, Stream_SetCapacity)
* Ensure length/capacity functions never return a value larger
than the actual length/capacity
2021-10-06 09:49:07 +02:00
Armin Novak
103ff6a758
Fixed certificate store double free.
2021-10-06 09:49:07 +02:00
akallabeth
03a9ca80c8
Refactor proxy ( #7312 )
...
* Added hidden transport dump and replay options
* Added settings to enable transport dump and replay
* Added check in freerdp_connect to skip authentication on
dump replay
* Fixed proxy issues
* Proper shutdown handling
* Uninitialized variables
* Skip proxy-client channels, initialize from peer channels and
config
* Filter static channels like dynamic ones
* Added proxy module filtering from config data (channels, input, ...)
* Removed oboslete proxy decoding related files
* Added defines for RDPECAM channel
* Added proxy config options:
* VideoRedirection
* CameraRedirection
* Fixed duplicate channel free
2021-09-23 14:52:03 +02:00
Martin Fleisz
e7bfcc37fc
core: Fix invalid memory access in local peer detection
2021-09-22 14:32:26 +02:00
akallabeth
e0a531f728
Channel fixes ( #7309 )
...
* Added missing CHANNEL_NAME defines.
* Fixed FreeRDP_ChannelDefArray setter
* Fixed code duplication due to merge error
* Added public function freerdp_channels_from_mcs
* Fixed const correctness in mcs
2021-09-22 14:27:21 +02:00
akallabeth
1c84690c2f
Fixes from tests ( #7308 )
...
* Fixed memory leak in tls_verify_certificate
* Fixed missing NULL checks
* Fixed missing checks for FreeRDP_DeactivateClientDecoding
* Added WINPR_ASSERT for client common new/free
* Added /disable-output switch to deactivate client decoding
Allows low resource remote connections that do not require visual
feedback. (e.g. load testing/...)
2021-09-21 09:56:56 +02:00
akallabeth
7b7e2d6f32
Prefer constant division over multiplication for length checks
2021-09-21 08:55:22 +02:00
Jeremy Cross
6547db2f17
early bail from update_read_window_state_order when handling WINDOW_ORDER_FIELD_WND_RECTS breaks subsequent protocol parsing
2021-09-21 07:43:03 +02:00
Armin Novak
0ccebb2a0f
Fixed missing NULL checks.
2021-09-20 10:59:59 +02:00
akallabeth
3ce622b638
Fixed FreeRDP_WTS* failure handling
2021-09-20 10:59:59 +02:00
akallabeth
bc800175d1
Fixed proper reset ov member variable to NULL
2021-09-20 10:59:59 +02:00
akallabeth
bc80fe3580
Improved server accept log message
2021-09-20 10:59:59 +02:00
akallabeth
d1b58ab263
Refactored rdpRdp cleanup handling
2021-09-20 10:59:59 +02:00
akallabeth
6b24c2be10
Added WINPR_ASSERT and cleanup fixes in freerdp.c
2021-09-20 10:59:59 +02:00
akallabeth
c1e38b24a6
Replaced manual settings value allocation with setter
2021-09-20 10:59:59 +02:00
akallabeth
04a8ced567
Added WINPR_ASSERT and proper error reset in client.c
2021-09-20 10:59:59 +02:00
akallabeth
bfb9a89639
Loop data type fix in certificate.c
2021-09-20 10:59:59 +02:00
akallabeth
73223638dd
WINPR_ASSERT in bulk.c
2021-09-20 10:59:59 +02:00
akallabeth
c2d126cdd8
Streamlined rdpCodec cleanup routines
2021-09-20 10:59:59 +02:00
akallabeth
ce8ef33ea4
Added WINPR_ASSERT in transport
2021-09-20 10:59:59 +02:00
akallabeth
75e6f443b5
Fixed possible leak in tls_prepare
...
If the function fails, the 'underlying' BIO was leaking as
tls_free did not clean it up if 'tls->bio' was not successfully
allocated.
2021-09-20 10:59:59 +02:00
akallabeth
1ca7e1f7a0
Added option to disable graphics decoding in client code path
2021-09-20 10:59:59 +02:00
akallabeth
41aaafef77
Added unicode input for xfreerdp
2021-09-17 07:21:45 +02:00
akallabeth
00c083a854
Fixed compilation warnings.
2021-09-14 09:45:03 +02:00
akallabeth
c7aa330091
Fixed #7280 : Missing return
2021-09-13 08:23:13 +02:00
akallabeth
70894c92e7
Added /kbd-scancode-list
...
Prints a listing of hexadecimal scancodes and the mapping to VK_*
2021-09-10 15:47:08 +02:00
akallabeth
1904020d7f
Some code cleanups and WINPR_ASSERT ( #7281 )
2021-09-10 09:06:35 +02:00
Armin Novak
673fb46836
Fixed uninitialized warnings
2021-09-10 08:16:25 +02:00
Armin Novak
0fe1e2359e
Fixed all reserved-id-macro warnings
2021-09-10 08:16:25 +02:00
Armin Novak
b41093be20
Fixed missing NULL set
2021-09-09 08:53:20 +02:00
Armin Novak
56648a98f2
Fixed rdp_reset error handling
2021-09-09 08:53:20 +02:00
Armin Novak
b336751861
Fixed AuthenticateEx issues
2021-09-09 08:53:20 +02:00
Armin Novak
85f1d46eab
Fixed cache issues
...
* Use rdpContext as reference instance
* WINPR_ASSERT what is not otherwise checked
2021-09-09 08:53:20 +02:00
akallabeth
3409f8d3b0
Transport add getter, add checks
...
* Added transport_get_context to get rdpContext in IO callbacks.
* Added WINPR_ASSERT where possible.
* Fixed handle count mismatch in transport_get_event_handles
2021-09-09 08:53:20 +02:00
Armin Novak
368b9f8e9c
Fixed CloseThreadpool calls
...
Requires NULL checks before call
2021-09-09 08:53:20 +02:00