Commit Graph

14135 Commits

Author SHA1 Message Date
Armin Novak
451c4ddee6 Passing on error code from irp_free 2020-02-21 11:31:21 +01:00
Armin Novak
30db616cec Added a free function to erase streams not processed.
When shutting down the streams still in the queue were not properly
freed.
2020-02-21 11:31:15 +01:00
Martin Fleisz
2d38a8a110
Merge pull request #5901 from nfedera/add_connstate_active_timeout
core: fix endless loops waiting for activation
2020-02-21 09:05:47 +01:00
Norbert Federa
a48e7f8b47 core: fix endless loops waiting for activation
There are two loops polling the transport pdu receiver in non-blocking mode
when waiting for reaching CONNECTION_STATE_ACTIVE rdp state.

In case of an invalid pdu size in the tpkt header this leaded to an endless
loop, utilizing 100% of a cpu core.

Added a sleep and limited the max loop time to the tcp ack timout value.
2020-02-20 17:51:20 +01:00
Armin Novak
bef8dda5e1 Fixed data length for list reader group return. 2020-02-20 15:35:11 +01:00
Armin Novak
aa441d3238 Log smartcard to stdout. 2020-02-20 15:24:03 +01:00
Armin Novak
5ab0716d7b SCardListReadersW return length is in bytes, not char. 2020-02-20 15:24:03 +01:00
Armin Novak
fd89ff6913 Fixed some conversion warnings. 2020-02-20 14:40:19 +01:00
Armin Novak
959be9d946 Fixed warnings in pcsc layer 2020-02-20 14:03:29 +01:00
Armin Novak
9b5f1ab384 Beautify smartcard log. 2020-02-20 13:59:28 +01:00
Armin Novak
893d08d653 Decreased smartcard log verbosity. 2020-02-20 13:59:28 +01:00
Armin Novak
a8e8351c1d Removed duplicated copyright claim 2020-02-20 13:59:28 +01:00
Armin Novak
fa10dfa186 Fixed memory leaks in PCSC_SCardReadCache[AW] 2020-02-20 13:59:28 +01:00
Armin Novak
f885476423 Fixed 8bit and 16bit return string sizes. 2020-02-20 13:59:28 +01:00
Armin Novak
ef93109f42 Fixes for GetAttrib and some refactroing
* Fix accidental buffer free before transfer
* Refactored code to eliminate a bunch of warnings
* Updated copyright headers
2020-02-20 13:59:28 +01:00
Armin Novak
f0f476c7d5 Fixed pcsc function pointer casts. 2020-02-20 13:59:28 +01:00
Armin Novak
fe61eab88c Fixed SCardReadCache autoallocate handling. 2020-02-20 13:59:28 +01:00
Armin Novak
2acce6214c SCardFreeMemory non const argument. 2020-02-20 13:59:28 +01:00
Armin Novak
37e850cb24 Cleaned up smartcard pcsc wrapper. 2020-02-20 13:59:28 +01:00
Armin Novak
30983f4049 Cleaned up smartcard inspect. 2020-02-20 13:59:28 +01:00
Armin Novak
ccda3de168 Added (incomplete) smartcard API test program. 2020-02-20 13:59:28 +01:00
Armin Novak
04f0e679f7 Fixed NDR pointer handling for smartcard data. 2020-02-20 13:59:28 +01:00
Martin Fleisz
428234012f
Merge pull request #5899 from akallabeth/respect_abort_connect
End connection before user callbacks if aborted.
2020-02-20 08:32:50 +01:00
Armin Novak
ac4bb3c103 End connection before user callbacks if aborted.
If somewhere in freerdp_connect freerdp_abort_connect was called
the user callbacks Authenticate, GatewayAuthenticate and
Verify[Changed|X509]Certificate[Ex] must not be called.
2020-02-19 16:44:42 +01:00
Martin Fleisz
c723c23308
Merge pull request #5898 from akallabeth/timezone_update_20200219
Updated timezones 2020-02-19
2020-02-19 16:03:54 +01:00
Armin Novak
e9a75d5a7a Updated timezones 2020-02-19 2020-02-19 15:27:10 +01:00
Martin Fleisz
48df902b0b
Merge pull request #5896 from akallabeth/cast_warning_fixes
Fixed #5895: cast warnings.
2020-02-19 10:54:02 +01:00
Martin Fleisz
b8aa01e16d
Merge pull request #5897 from akallabeth/flatpak_update
Updated flatpak build manifest
2020-02-19 10:50:41 +01:00
Armin Novak
3941e1cda6 Updated flatpak build manifest
* Use platform 19.08
* Remove shared-modules, no longer required (udev is now part of the
platform)
* Switch PCSC source to github to avoid rate limitations.
2020-02-19 10:30:56 +01:00
Armin Novak
436b68e416 Fixed #5895: cast warnings. 2020-02-19 10:21:43 +01:00
Armin Novak
75be471d78 Fixed #5889: Only add descriptors wanted to select 2020-02-18 14:33:45 +01:00
Sergey Bronnikov
c157067ccf Fix markup 2020-02-18 13:16:51 +01:00
Martin Fleisz
f46596a82d
Merge pull request #5890 from akallabeth/sample_client_install
Install sample client binary.
2020-02-18 11:14:58 +01:00
Armin Novak
f77b3daaa0 Fix channel linking for built in channels 2020-02-18 11:14:05 +01:00
Armin Novak
f933cafa93 Added some callbacks to dynamic channel
* Allow listener removal of channel during runtime
* Allow retrieval of channel name
2020-02-18 11:14:05 +01:00
Armin Novak
c0bf6c0768 working progressive Original Method DWT
Implemented decoding utilizing Original Method DWT
(See [MS-RDPEGFX] 3.2.8.1.2.2 Reduce-Extrapolate Method)
2020-02-18 11:13:52 +01:00
Armin Novak
1fa00c4318 Refactored progressive codec. 2020-02-18 11:13:52 +01:00
Armin Novak
8c15bd9765 Install sample client binary. 2020-02-18 11:02:43 +01:00
Sergey Bronnikov
6d6956a139 client: remove unused variable 2020-02-17 15:49:26 +01:00
Martin Fleisz
3468460389
Merge pull request #5885 from llyzs/rdpsnd_overrun
rdpsnd: implement buffer overrun detection.
2020-02-15 19:25:40 +01:00
Vic Lee
25eb6b6cdd rdpsnd: implement buffer overrun detection. 2020-02-14 20:49:18 +08:00
David Fort
e4ac7b98a0
Merge pull request #5881 from akallabeth/win_disable_console
Disable windows console attach.
2020-02-13 16:12:50 +01:00
Bernhard Miklautz
5d5ceda19e
Merge pull request #5882 from akallabeth/sample_auth_only
Added /auth-only option to sample client.
2020-02-13 15:39:27 +01:00
Armin Novak
8828eff6a1 Added /auth-only option to samle client.
In #5814 the option to use a connection test was expressed.
Adding this option to the sample client allows doing that without
X11 or similar around.
2020-02-13 08:27:49 +01:00
Armin Novak
2822585db4 Disable windows console attach. 2020-02-12 15:47:31 +01:00
Martin Fleisz
e304428a5f
Merge pull request #5857 from akallabeth/scanbuild_fixes
Scanbuild fixes
2020-02-12 10:16:54 +01:00
Martin Fleisz
bbc8bf35c4
Merge pull request #5877 from akallabeth/urbdrc_export_symbol_fix
Urbdrc export symbol fix
2020-02-11 12:58:10 +01:00
Armin Novak
b004e01fc8 Exporting URBDRC symbols used by helper library
When building the usb channel with different shared libraries some
necessary symbols were not exported.
2020-02-11 12:42:45 +01:00
David Fort
7c26d7d9ad
Merge pull request #5875 from akallabeth/smartcard_missing_null_check
Fix #5847: Missing length check to trace smartcard buffers.
2020-02-10 14:57:46 +01:00
Kobi Mizrachi
7a2eafbc3c core: server: fix a bad free in channel->queue cleanup 2020-02-10 14:29:30 +01:00