Armin Novak
9859cfb736
Fixed dead store.
2017-11-15 15:54:38 +01:00
Armin Novak
0e6a44faf3
Mask out ignored bits from UnicodeFlag.
2017-07-19 09:41:58 +02:00
Armin Novak
b2c29158be
Scanbuild warning, argument checks and leak fixes.
...
* Added Stream_GetRemainingCapacity to check remaining stream size
before writes.
* Fixed shadow server memory leak.
* Fixed lots of scanbuild warnings
* Added missing argument checks in many functions
* Added missing static function declarations
2017-03-02 18:13:43 +01:00
Norbert Federa
f71b6b46e8
fix string format specifiers
...
- fixed invalid, missing or additional arguments
- removed all type casts from arguments
- added missing (void*) typecasts for %p arguments
- use inttypes defines where appropriate
2016-12-16 13:48:43 +01:00
Norbert Federa
c6e6b44143
countless WLog/printf format specifier fixes
2016-11-25 17:06:25 +01:00
Marc-André Moreau
dee76617d9
channels: remove thread-local storage usage
2016-11-15 11:41:01 -05:00
Armin Novak
9f5da483dc
Reformatted files touched in last 2 commits.
2016-10-06 13:43:12 +02:00
Armin Novak
88a3b8dd76
Initializing channel context in each thread.
2016-10-06 13:43:12 +02:00
Norbert Federa
ef4b29e5b3
ConvertFromUnicode fixes and misc hardening
...
- Added missing ConvertFromUnicode checks
- If ConvertToUnicode allocates memory, guarantee the null termination
similar to ConvertFromUnicode's implementation
- Fixed some TestUnicodeConversion.c CTest return values
- Added some CTests for ConvertFromUnicode and ConvertToUnicode
- Misc code and protocol hardening fixes in the surrounding code regions
that have been touched
2016-03-03 16:56:19 +01:00
Martin Haimberger
52405a3e79
Remove WIN32ERROR type
...
All return values are UINT now.
2015-08-27 05:38:20 -07:00
Martin Haimberger
65fd259610
misc fixes:
...
fixed all bugs from the review
checking all WaitFor*Object/s calls
2015-07-30 06:49:21 -07:00
Martin Haimberger
58ada13dd9
fixed some remakes and compiler errors
2015-07-22 02:36:24 -07:00
Martin Haimberger
b8c110d19b
introduced channel error reporting system
...
The rdpContext gets an event which will
get set if an error occoured in a channel.
If a thread or a void callback has to report an
error it will get signaled by this system.
2015-07-15 00:50:35 -07:00
Martin Haimberger
0bf222ec50
hardend rdpdr channel
2015-06-18 03:04:32 -07:00
Marc-André Moreau
35e26020aa
freerdp: patch multiple leaks and OOM errors
2015-05-22 14:14:57 -04:00
Marc-André Moreau
89642923d1
channels/rdpdr: add more server-side error checking
2015-05-21 16:50:29 -04:00
Marc-André Moreau
d8460d14e0
channels/rdpdr: treat OOM and status failures in server-side code
2015-05-21 16:08:46 -04:00
Marc-André Moreau
aa34c8a7d5
channels/rdpdr: cleanup server-side rdpdr code
2015-05-21 14:33:38 -04:00
Marc-André Moreau
7e1dbd505b
Merge branch 'awakecoding' of https://github.com/vworkspace/FreeRDP
...
Conflicts:
channels/rdpdr/server/rdpdr_main.c
2015-05-20 11:40:48 -04:00
Norbert Federa
1eff1a345e
free can handle NULL perfectly fine
2015-05-11 09:07:39 +02:00
Mike McDonald
b6cb94b60e
Fixed protocol parsing issue in general capability set. The SpecialTypeDeviceCap field is only present when the Version field is set to GENERAL_CAPABILITY_VERSION_02.
2015-04-22 17:33:42 -04:00
Bernhard Miklautz
79de8168f9
Integrate feedback from pull request
...
* orders.c: remove ; at eol
* rdpdr_main.c: simplify error case
* rdpsnd_pulse.c: fix incorrect check
* rdpsnd_main.c: adapt return value according to documentation
* update.c: fix incorrect return values
2015-03-30 18:29:32 +02:00
Bernhard Miklautz
74c8400789
coding style fixes
...
Add missing space after if
2015-03-30 17:15:45 +02:00
Bernhard Miklautz
f469e069dc
stream: Stream_Ensure*Capacity: change return type
...
Change the return type of Stream_Ensure*Capacity from void to BOOL to be
able to detect realloc problems easily. Otherwise the only way to detect
this was to check if the capacity after the call was >= the required
size.
In case Stream_Ensure*Capacity fails the old memory is still available
and need to freed outside.
This commit also adds checks to most calls of Stream_Ensure*Capacity to
check if the call was successful.
2015-03-30 16:33:48 +02:00
Mike McDonald
7febeb2dec
Added rename file and fixed some minor bugs.
2014-12-30 18:41:21 -05:00
Mike McDonald
b21331cf1a
First cut at server side implementation of RDPDR drive redirection.
2014-12-27 21:17:34 -05:00
Armin Novak
b1e9ffb655
Using wlog for channel logging now.
...
Fixed compiler warnings and broken callback in urbdrc.
2014-09-15 08:48:46 +02:00
Armin Novak
b22b897389
Reformatted changed files.
2014-09-09 16:32:22 +02:00
Armin Novak
419f102bec
Fixed calling of dump functions, new API
2014-09-09 16:31:46 +02:00
Armin Novak
66b8905ac6
Using special log defines for channels now.
2014-08-11 09:12:01 +02:00
Armin Novak
158e1323de
Fixed compiler warnings.
2014-08-07 19:05:48 +02:00
Armin Novak
b252009d36
Replaced custom logging mechanism with WLog wrapper.
2014-08-07 16:51:49 +02:00
Vic Lee
29cb8680ce
server: allow partial channel read (fix rdpsnd).
2014-07-14 20:00:38 +08:00
Hardening
c076ffb020
Don't use NULL for pWrittenBytes when calling WTSVirtualChannelWrite()
...
Nothing in the MSDN API says that setting NULL is safe. And if the
implementation uses WriteFile directly, it crashes.
2014-05-28 17:04:24 +02:00
Marc-André Moreau
6e1cdf1b67
libfreerdp-core: expose opaque HANDLE instead of WTSVirtualChannelManager*
2014-02-27 13:30:04 -05:00
Marc-André Moreau
3e546a22a1
channels: start migrating existing server-side channels to WTSAPI
2014-02-16 22:07:00 -05:00
Marc-André Moreau
c878200e00
channels/server: refactor to match WTSApi + avoid conflicts
2013-08-20 19:26:36 -04:00
Marc-André Moreau
552cee7431
channels/server: start refactoring to fully match WTSApi
2013-08-20 18:06:19 -04:00
Marc-André Moreau
73c02a7637
channels/cliprdr: fix unicode conversion
2013-08-19 12:21:40 -04:00
Marc-André Moreau
3d0d65e917
channels/rdpdr: server-side device list and user logged on pdu
2013-08-18 20:27:50 -04:00
Marc-André Moreau
363bd27d76
channels/rdpdr: start server-side device redirection
2013-08-18 18:09:12 -04:00
