Armin Novak
83bb37d174
Fixed decoder arguments, use const correct ones
2022-04-28 09:17:41 +02:00
akallabeth
73cdcdfe09
Logging and parser fixes ( #7796 )
...
* Fixed remdesk settings pointer
* Fixed sign warnings in display_write_monitor_layout_pdu
* Use freerdp_abort_connect_context and freerdp_shall_disconnect_context
* Added and updates settings
* info assert/dynamic timezone
* mcs assert/log/flags
* Fixed and added assertions for wStream
* Unified stream length checks
* Added new function to check for lenght and log
* Replace all usages with this new function
* Cleaned up PER, added parser logging
* Cleaned up BER, added parser logging
* log messages
* Modified Stream_CheckAndLogRequiredLengthEx
* Allow custom format and options
* Add Stream_CheckAndLogRequiredLengthExVa for prepared va_list
* Improved Stream_CheckAndLogRequiredLength
* Now have log level adjustable
* Added function equivalents for existing logger
* Added a backtrace in case of a failure is detected
* Fixed public API input checks
2022-04-19 14:29:17 +02:00
akallabeth
752ac3b479
Fix #7793 : Do not expose internal input API ( #7794 )
...
* Fixed GetFileInformationByHandle initializers
* Fix #7793 : Do not expose internal input API
Slow-Path input uses UINT16 for scancodes on wire, but only the
lower byte is actually used. (the extended fields are sent in
keyboardFlags field)
Hide this implementation detail and adjust the API to use UINT8
for the code instead just like the corresponding Fast-Path PDU
* Added a warning for problematic slow path keyCodes
2022-04-13 09:34:05 +02:00
Armin Novak
d49f744526
Unify stream positioning on fastpath updates
2022-04-06 08:58:32 +02:00
Armin Novak
24997387a4
Fixed missing capacity checks in fastpath
2022-04-06 08:58:32 +02:00
Armin Novak
4d03d7c0bf
Freerdp remove #ifdef HAVE_CONFIG_H
2022-03-03 11:26:48 +01:00
Armin Novak
b2ad47a809
Reorganized FreeRDP headers
2022-03-03 11:26:48 +01:00
Armin Novak
1f59dff316
Fixed const warnings
2022-02-01 10:25:37 +00:00
akallabeth
1ca7e1f7a0
Added option to disable graphics decoding in client code path
2021-09-20 10:59:59 +02:00
Armin Novak
17f530a866
Transport opaque
2021-09-09 08:36:01 +02:00
akallabeth
64403d9d40
Refactored rdpFastpath
...
* Structure now opaque
* Added WINPR_ASSERT where appropriate
2021-09-06 10:11:14 +02:00
akallabeth
00ac11524e
Wrapped rpdRdp:state access in getter/setter
...
* Only access state via getter/setter
* Better state debuggind with log messages on state transition
2021-09-06 10:11:14 +02:00
Martin Fleisz
bddeece00c
Merge pull request #6601 from akallabeth/clip_file
...
Fixed support for huge files in clipboard
2021-01-25 10:26:30 +01:00
akallabeth
f3dad4106a
Fixed support for huge files in clipboard
2021-01-25 08:43:46 +01:00
akallabeth
102869f6a8
Fixed missing check for fastpath input messages
...
Input events are only allowed after a connection was established
(connection state is active)
This check aborts input sending when done before that.
2021-01-23 16:12:29 +01:00
Armin Novak
182d0ce548
Added RDP 10.7 large pointer support
...
* Implements [MS-RDPBCGR] version 51 large pointer support.
* Logs unknown large pointer capability flags as warning.
Signed-off-by: Armin Novak <armin.novak@thincast.com>
2019-12-19 09:53:40 +01:00
Armin Novak
72ca88f49c
Reformatted to new style
2019-11-07 10:53:54 +01:00
Armin Novak
d03d8f1a2d
Fixed fastpath/slowpatth pause event.
2019-05-16 15:21:12 +02:00
Armin Novak
2a26aa0d87
Unified update->BeginPaint and update->EndPaint
...
Since these functions were called from 2 different threads
(main thread or dynamic channel) depending on fastpath or
gfx channel use lock between these.
If not locked the invalid region may be accessed from both
threads and lead to crashes as experienced with nightly df280a7ff
2019-04-11 15:33:23 +02:00
Armin Novak
a97bf21109
Fixed broken DEBUG_RDP log message.
2018-11-21 09:55:38 +01:00
Martin Fleisz
7b0f4f5dc4
Merge pull request #4907 from akallabeth/transport_write_leak_fix
...
Transport write leak fix
2018-10-29 14:54:55 +01:00
Armin Novak
6ccaafe2d9
Fixed default return value for fastpath_send_multiple_input_pdu
2018-10-23 12:33:13 +02:00
Armin Novak
991f051a63
Fixed stream release for transport_write
2018-10-17 14:55:55 +02:00
Armin Novak
f88ed950d3
Fixed various issues with primary orders.
2018-10-15 14:30:58 +02:00
Armin Novak
54f3a388da
Fixed #4835 : BeginPaint callback now optional.
2018-09-04 10:40:17 +02:00
Armin Novak
e0af47d26d
Fixed rebase introduced error.
2018-05-02 09:56:49 +02:00
Armin Novak
4e66972616
Fixed remaining global order buffers.
2018-05-02 08:54:21 +02:00
Armin Novak
e5767f07ac
Refactored order updates
...
Unified order creation/copy/delete to avoid memory leaks.
2018-05-02 08:54:21 +02:00
Armin Novak
3762e06714
Fixed RDP debug message invalid function.
2018-04-06 11:34:24 +02:00
Armin Novak
e47d7eb968
Simplified fastpath buffer handling.
2018-04-04 13:24:43 +02:00
Armin Novak
1f7d33a2f2
Fixed read/write of surface bits command.
...
The optional field exBitmapDataHeader of TS_ BITMAP_DATA_EX was ignored.
Read and expose the data (currently unused)
2018-03-01 11:38:59 +01:00
David Fort
41823080f9
Fix users of Stream_GetPosition() that returns size_t
2017-12-11 22:38:58 +01:00
David Fort
17a4e95a5b
Drop some annoying warning
...
Probably that some unused functions should be removed, but at least it makes
it compile with no warnings.
2017-05-12 13:54:16 +02:00
Armin Novak
d46d0c3d4a
Fixed invalid return from xf_rail_window_icon
2017-03-28 11:47:46 +02:00
Armin Novak
b2c29158be
Scanbuild warning, argument checks and leak fixes.
...
* Added Stream_GetRemainingCapacity to check remaining stream size
before writes.
* Fixed shadow server memory leak.
* Fixed lots of scanbuild warnings
* Added missing argument checks in many functions
* Added missing static function declarations
2017-03-02 18:13:43 +01:00
Norbert Federa
f71b6b46e8
fix string format specifiers
...
- fixed invalid, missing or additional arguments
- removed all type casts from arguments
- added missing (void*) typecasts for %p arguments
- use inttypes defines where appropriate
2016-12-16 13:48:43 +01:00
Armin Novak
e7814d5855
Fixed stream API for Stream_Copy.
2016-03-01 12:57:48 +01:00
Bernhard Miklautz
ff8d172a12
core: use error instead of debug
...
When the function would return with an error print an error message
instead of a debug message
2015-06-23 11:15:13 +02:00
ivan-83
307d22ca11
* debug and error messages now print function name and line number
...
* add debug messages to trace fake network dissconects
2015-05-27 23:48:07 +03:00
ivan-83
3912172fc8
+ tsmf: OSS initial suppot (not work yet)
...
* tsmf: fix video playback on FreeBSD (proper shared object name)
* tsmf: renamed args: audio->sys, audio-dev->dev
* audin: OSS fix, now it work
* cmdline: add syntax help for /audin, /rdpsnd, /tsmf
* add debug messages
2015-05-27 23:22:36 +03:00
ivan-83
5ba4d6cd6c
Code style changed.
2015-05-27 22:59:57 +03:00
ivan-83
0fda0eb0de
Code style changed.
2015-05-27 22:59:57 +03:00
ivan-83
1009268158
* debug and error messages now print function name and line number
...
* add debug messages to trace fake network dissconects
2015-05-27 22:57:10 +03:00
ivan-83
94a7abd2af
+ tsmf: OSS initial suppot (not work yet)
...
* tsmf: fix video playback on FreeBSD (proper shared object name)
* tsmf: renamed args: audio->sys, audio-dev->dev
* audin: OSS fix, now it work
* cmdline: add syntax help for /audin, /rdpsnd, /tsmf
* add debug messages
2015-05-27 22:54:13 +03:00
Clive Stevens
2e41c5425b
Fix whitespace
2015-05-06 15:54:23 +01:00
Clive Stevens
b06e50479e
Fix two cases of potentially leaked streams
2015-05-06 15:23:37 +01:00
Bernhard Miklautz
2c072d33d3
Fix GDI return values and other fixes
...
* top level GDI functions return 0 on error and != 0 otherwise but the
low level functions (16bpp.c, 8bpp.c 32bpp.c) which are called did it
exactly the other way around. Those were adapted.
* change gdi_InvalidateRegion to BOOL and check calls where appropriate
* integrate comments from pull request
2015-04-21 14:18:07 +02:00
Bernhard Miklautz
515502ffa5
change return types of callbacks to BOOL
...
* change all client/server callbacks to BOOL
* update all clients accordingly
* add multiple return value checks
* small fixes
2015-04-21 14:18:07 +02:00
David FORT
c03bf75896
Take in account @nfedera's comments
2015-04-07 21:06:53 +02:00
David FORT
0eb399a717
Treat return values for security.c
...
This patch make functions in security.c return values when they should instead of
beeing void. And it also fix the callers of these functions.
2015-04-01 11:11:37 +02:00