Martin Fleisz
ebe0fc59b5
Merge pull request #5865 from akallabeth/write_cancelled_leak
...
Fix #5852 : handle CHANNEL_EVENT_WRITE_CANCELLED
2020-02-10 12:08:55 +01:00
Martin Fleisz
1366abfbff
Merge pull request #5869 from llyzs/winmm_fixes
...
rdpsnd/winmm: fix some memory issues.
2020-02-10 10:40:55 +01:00
David Fort
245fc6014d
Merge pull request #5830 from akallabeth/smartcard_updates
...
Smartcard updates
2020-02-07 14:11:00 +01:00
Vic Lee
847fe0f919
rdpsnd/winmm: fix some memory issues.
2020-02-04 17:56:45 +08:00
Armin Novak
d2aef75004
Fix #5852 : handle CHANNEL_EVENT_WRITE_CANCELLED
...
When channels are cleaned up OpenHandle is most of the time
already 0. Ignore the argument checks for
CHANNEL_EVENT_WRITE_CANCELLED and CHANNEL_EVENT_WRITE_COMPLETE
only check where actually required (CHANNEL_EVENT_DATA_RECEIVED)
2020-01-29 08:52:25 +01:00
Armin Novak
11f2532242
Added unified NDR pointer reading.
2020-01-24 13:52:43 +01:00
Armin Novak
7b50ed887e
Fixed missing length checks for smartcard IRP read.
2020-01-24 13:23:40 +01:00
Armin Novak
9128e441c6
Fixed rdpei unused function warning.
2020-01-23 10:50:37 +01:00
Armin Novak
f4ee8d92a7
Fixed smartcard type mismatches.
2020-01-23 10:39:43 +01:00
Armin Novak
087f290d8d
Fixed type of index variable.
2020-01-23 10:12:12 +01:00
Armin Novak
8996fdc797
Fixed unused variable warning.
2020-01-23 10:12:12 +01:00
Armin Novak
f0db6f2ead
Unified smartcart multistring conversion.
2020-01-23 10:07:54 +01:00
Armin Novak
ee7950c95c
Fixed type mismatches on allocation.
2020-01-23 09:48:20 +01:00
Armin Novak
ec5881e3f2
Fixed smartcard_SetAttrib_Decode call type
2020-01-23 09:32:34 +01:00
Martin Fleisz
706e32982e
rdpsnd: Add synchronization to winmm backend
2020-01-17 13:56:30 +01:00
Armin Novak
afaee324bb
Fixed #5843 wrong header length for pdu
...
@boom1 reported encomsp_send_change_participant_control_level_pdu
fails due to wrong length.
2020-01-16 15:30:33 +01:00
Armin Novak
03e2106f25
Fixed accidental reorder of surface delete and disconnect
2020-01-16 15:24:55 +01:00
Martin Fleisz
369c696b23
rdpsnd: Fix possible crash and deadlock in winmm backend
2020-01-16 10:23:17 +01:00
Martin Fleisz
53f7927bf3
audin: Fix possible crash in winmm backend
2020-01-16 10:23:17 +01:00
Martin Fleisz
9cddb7c2be
Merge pull request #5836 from kubistika/proxy/fix_rail_and_update_issues
...
fixes: rail and update issues
2020-01-16 10:13:26 +01:00
David Fort
30d6e25def
Merge pull request #5750 from akallabeth/encomsp_auto
...
Encomsp automatic input control && cleanups
2020-01-15 13:56:00 +01:00
Kobi Mizrachi
b94143f644
rdpsnd: server: fix leak in rdpsnd_server_context_free
2020-01-15 13:51:05 +02:00
David Fort
d617de5a79
Merge pull request #5831 from akallabeth/drdynvc_error_tolerance
...
Ignore dynamic virtual channel errors
2020-01-15 10:49:53 +01:00
Kobi Mizrachi
29dee84a2b
rail/server: rename rdpContext to rdpcontext
...
Fixes a compilation error when mixing c++ and c code.
2020-01-14 07:58:47 +01:00
Armin Novak
f313fabb2b
Added fallback for libusb < 1.0.19
...
we use stream_id functions which were introduced with 1.0.19
2020-01-13 15:23:57 +01:00
Armin Novak
b5bb6e3ea9
Fixed LIBUSB_HOTPLUG_NO_FLAGS definition
...
libusb documentation is a bit misleading, this flag was
introduced with 1.0.20
2020-01-13 15:13:35 +01:00
Kobi Mizrachi
18be21a4fa
rdpgfx: client: fix leak when using rdpgfx_client_context_new API
2020-01-13 13:41:44 +01:00
Kobi Mizrachi
2d9a50fafb
fix memory leaks in disp server and gfx.c
2020-01-13 13:41:44 +01:00
Armin Novak
7011b008b5
Ignore dynamic virtual channel errors
...
If a dynamic virtual channel can not process a message, ignore it.
2020-01-13 12:23:30 +01:00
Armin Novak
dfe7b8c8da
Implement missing functions for new smartcard
...
Newer smartcard channel behaviour expects a lot more callbacks
being implemented. This change provides them.
2020-01-13 11:27:37 +01:00
Armin Novak
d0929cbf2f
Extend LIBUSB_API_VERSION check
...
The define exists since 1.0.13, so to compensate for older also
check if the variable is defined.
2020-01-10 10:52:23 +01:00
Armin Novak
e86849759a
Fixed waveOutClose, call waveOutReset first.
...
Signed-off-by: Armin Novak <armin.novak@thincast.com>
2020-01-08 18:25:08 +01:00
Armin Novak
b0de74cad2
Fallback definition for LIBUSB_HOTPLUG_NO_FLAGS
...
The flag was first introduced with libusb 1.0.16, so
define it if we are using an older version.
Signed-off-by: Armin Novak <armin.novak@thincast.com>
2020-01-08 17:14:09 +01:00
Armin Novak
f720ec5383
RDPSND device API refinements
...
* Added default format callback for rdpsnd backend to allow
different default input formats (different samplerates, ...)
* Made WINMM backend in flight packet limitation a compile time
option
* Fixed missing buffer copy in winmm backend
Signed-off-by: Armin Novak <armin.novak@thincast.com>
2020-01-08 17:14:09 +01:00
Martin Fleisz
05a865281e
channels: Fix memory leak and make log messages more precise
2020-01-08 16:49:15 +01:00
Armin Novak
ac553e1bb5
Fix #5805 : windows hotplug drive detection.
2020-01-07 10:35:12 +01:00
David Fort
31a4e2ad8b
Merge pull request #5745 from akallabeth/urbdrc_rewrite
...
Urbdrc rewrite
2020-01-06 09:23:45 +01:00
Martin Fleisz
a98e153b9d
rdpsnd: Do not set output device on Catalina or later ( #5747 )
2020-01-03 13:31:15 +01:00
Martin Fleisz
d21e0a6d6d
Fix audio channel init when no audio devices are present
...
This PR fixes the handling of using rdpsnd or audin when the system has
no audio device available.
In case of a missing playback device the
Windows backend now correctly reports an error and the fake rdpsnd
backend is loaded.
If audin is enabled and no microphone is present the channel
initialization will report an error but it won't cut the connection (as
it did before).
2019-12-30 12:59:14 +01:00
Armin Novak
947645520d
Removed touch input channel thread
...
The touch input channel only sends small events (touch points et al)
and therefore does not require a heavy processing thread.
2019-12-18 11:36:12 +01:00
Armin Novak
d044915a7e
Fixed stream handling and missing includes.
2019-12-17 15:51:24 +01:00
Kobi Mizrachi
3f9e6ca978
rdpgfx: surface_to_scaled_window: fix pdu type
2019-12-12 11:10:44 +01:00
Kobi Mizrachi
7af2483626
rail: keep extendedSpiSupported flag synced
2019-12-12 11:10:44 +01:00
Kobi Mizrachi
5565b366b0
rail: stream size checks and rail_read_sysparam_order fixes
2019-12-12 11:10:44 +01:00
Armin Novak
2d3d882de9
Stream size checks for rail_write_sysparam_order
...
Ensure the stream is large enough to hold the data
in rail_write_sysparam_order, rail_write_high_contrast and
rail_write_filterkeys.
2019-12-12 11:10:44 +01:00
Mati Shabtay
4dacb57f6f
rail server: implement channel code for rail server
...
* Split common functionality from client code
* Clean up client code and use proper defines for constants
* Implements the channel code to read/write server side
messages.
2019-12-12 11:10:44 +01:00
ajlex140
2f2f4f91d8
reply with empty irp package with error code, if irp device is unavailable
2019-12-09 11:43:02 +01:00
Armin Novak
da6ff1ca65
Removed some unnecessary casts.
2019-12-05 11:40:56 +01:00
Armin Novak
6e6dfc3e2a
Removed rdpsnd client thread
...
The thread used to process audio data is not really required
and just produces overhead.
2019-12-05 11:40:56 +01:00
Martin Fleisz
71feb974ac
Merge pull request #5739 from akallabeth/improve_function_hiding
...
Improve function hiding
2019-12-02 11:31:35 +01:00
Armin Novak
7c243da6e1
Remove symbols exported by accident.
2019-12-02 10:57:31 +01:00
Martin Fleisz
4d8a4d39ba
Merge pull request #5748 from akallabeth/mac_sound_no_mic
...
Fix #5747 : Only open output device in rdpsnd for mac.
2019-11-29 08:19:24 +01:00
David Fort
5e6775ce95
winpr: fix anonymous enum members and menbers without a size
2019-11-25 13:39:31 +01:00
Armin Novak
fd968cdf84
Fixed dead store warning.
2019-11-25 10:32:55 +01:00
Armin Novak
2691532061
Fixed const correctness of encomsp functions.
2019-11-25 09:39:21 +01:00
Armin Novak
65ebda20dd
Fix #5747 : Only open output device in rdpsnd for mac.
2019-11-25 08:27:57 +01:00
Armin Novak
c4a141cd8a
Fixed some scanbuild warnings.
2019-11-22 11:47:16 +01:00
Armin Novak
0927d7aa50
Rewrite of urbdrc channel.
...
* Fix command line parsing
* Properly handle channel creation/destruction
* Use wStream API for parsing
2019-11-22 10:56:21 +01:00
David Fort
d7e510016a
Merge pull request #5736 from akallabeth/makecert_cleanups
...
Cleaned up code for makecert.
2019-11-20 23:26:31 +01:00
Armin Novak
a5bebd3c65
Fixed scanbuild warnings.
2019-11-20 09:17:08 +01:00
Armin Novak
f9b3f270fe
Fixed path NULL checks.
2019-11-19 10:48:25 +01:00
Armin Novak
4c5bfcc235
Fixed #5727 : drive_process_irp_create set path to NULL if not provided.
2019-11-18 15:25:18 +01:00
Armin Novak
9f3adf10f8
Fixed #5727 : use getmntent to read /proc/mounts
2019-11-18 15:25:18 +01:00
Armin Novak
57a57a917a
Fixed #5727 : Remove forbidden symbols from drive name
2019-11-18 14:31:46 +01:00
Bernhard Miklautz
6bf94972b1
Merge pull request #5715 from akallabeth/table_gen
...
Fixed #5713 : Use proper types to generate tables.c where possible.
2019-11-14 15:01:07 +01:00
Armin Novak
b3630d12e5
Fixed #5713 : Use proper types to generate tables.c where possible.
...
Use the correct type for function arguments of DVCPluginEntry type
and void* for type DeviceServiceEntry when generating tables.c
2019-11-14 11:42:50 +01:00
Bernhard Miklautz
f95e347e9c
fix [build]: don't export rdp2tcp as cmake target
...
rdp2tcp was wrongly exposed as cmake target. This could lead to errors
like the following when the FreeRDP2 cmake file was required:
CMake Error at ../lib/cmake/FreeRDP2/FreeRDPTargets.cmake:73 (message):
The imported target "rdp2tcp-client" references the file
".../lib/freerdp2/librdp2tcp-client.a"
but this file does not exist. Possible reasons include:
* The file was deleted, renamed, or moved to another location.
* An install or uninstall procedure did not complete successfully.
* The installation package was faulty and contained
".../lib/cmake/FreeRDP2/FreeRDPTargets.cmake"
but not all the files it references.
2019-11-13 16:11:46 +01:00
Armin Novak
17c7144cb2
Fixed cleanup of remdesk in CHANNEL_EVENT_WRITE_COMPLETE
2019-11-13 11:42:27 +01:00
kubistika
511f89cd99
cliprdr: common: fix validation of file contents request pdu
2019-11-12 12:45:01 +01:00
Armin Novak
153639624b
Fixed NULL checks for strnlen calls, limit static channel name length.
...
As reported by @metametaclass in #5687 check the strings for NULL before
using strnlen. Also extend the same checks to static channel loading.
2019-11-07 10:53:55 +01:00
Armin Novak
72ca88f49c
Reformatted to new style
2019-11-07 10:53:54 +01:00
Armin Novak
2790866c12
Added CHANNEL_EVENT_WRITE_CANCELLED for remdesk channel
2019-11-06 13:01:43 +01:00
Armin Novak
75ed12f1f0
Fixed userdata pointer and CHANNEL_EVENT_WRITE_CANCELLED message.
2019-11-06 13:01:43 +01:00
Armin Novak
1bcb799560
Listen to CHANNEL_EVENT_WRITE_CANCELLED and emit if queue is cleared.
2019-11-06 13:01:43 +01:00
Armin Novak
1b78b59926
Fixed #4809 : Properly process CHANNEL_EVENT_WRITE_COMPLETE
2019-11-06 13:01:43 +01:00
Armin Novak
09d14a2462
Fixed VirtualChannelWriteEx error case leaks.
2019-11-06 13:01:43 +01:00
Martin Fleisz
bc39b32d20
Merge pull request #5685 from akallabeth/multi_instance_arg_parse
...
COMMAND_LINE_ARGUMENT structs contain parser results, use one per instance
2019-11-06 09:09:22 +01:00
Armin Novak
993b79f1bd
Removed strcpy use.
2019-10-29 11:58:43 +01:00
Armin Novak
f01e042211
Code cleanups (strlen, casts, size_t, ...)
2019-10-29 11:58:43 +01:00
Martin Fleisz
9b1626ee6e
Merge pull request #5673 from akallabeth/audin_format_leak_fix
...
Fixed memory leak when freeing up audin formats.
2019-10-28 15:19:30 +01:00
Armin Novak
0c87eaee4d
COMMAND_LINE_ARGUMENT structs contain parser results, use one per instance
...
Remove the old global structs as the parser modifies them. When using
multiple instances in the same process space this could break parsing.
2019-10-28 13:30:05 +01:00
Martin Fleisz
9e32899347
Merge pull request #5676 from akallabeth/hotplug_leak_fix
...
Hotplug leak fix
2019-10-28 13:06:36 +01:00
Armin Novak
da48b4eb8d
Made disp channel internal functions static.
2019-10-28 09:31:50 +01:00
Armin Novak
64f64cd035
devman_load_device_service device argument can be const.
2019-10-24 15:04:48 +02:00
kubistika
bf2e1a33d0
channels: rdpgfx: export API to create rdpgfx client
2019-10-24 12:19:31 +02:00
Armin Novak
30c21279cb
Fixed memory leak when freeing up audin formats.
2019-10-24 12:18:24 +02:00
AzureusNation
4955a0e5b8
Fixes hub was not found! error
...
Again as with auto usb detection strtol needs to use base 10 and force to use base 10 else the conversion does not work correctly.
2019-10-23 09:56:23 +02:00
AzureusNation
7d6a10aaff
Fixes Auto USB Redirection
...
Base 0 does not work when converting the string to long int. This ends up not showing the correct device id and sometimes the wrong bus id. By changing it to base 10 conversion instead of base 0 this fixes the issue of auto redirect usb devices.
2019-10-23 09:56:23 +02:00
asapelkin
82eadad4a4
Fix some static analizer warnings
2019-10-22 15:39:54 +02:00
kubistika
5cc5aa98ec
channels: cliprdr: client: fix leak in cliprdr_packet_send
2019-10-18 14:20:26 +02:00
kubistika
d75c5eec04
channels: cliprdr: improved common cliprdr api
2019-10-18 14:20:26 +02:00
kubistika
d2f73136d3
channels: cliprdr: reformat cliprdr_common.c
2019-10-18 14:20:26 +02:00
kubistika
345cc2a2f5
channels: cliprdr: get rid of duplicated server and client code
2019-10-18 14:20:26 +02:00
Armin Novak
59b4988f56
Fixed compilation warnings.
2019-10-16 14:54:05 +02:00
Martin Fleisz
9a33a82fb7
Merge pull request #5634 from akallabeth/error_code_update
...
Added missing error codes.
2019-10-03 08:45:44 +02:00
Armin Novak
0ffcba9350
Fix #5635 : Silence double WITH_CUPS definition.
2019-10-02 16:24:12 +02:00
Armin Novak
134da33eb0
Fixed format string.
2019-10-02 16:01:36 +02:00
Martin Fleisz
583045e2e5
rail: Update to latest spec version 28.0
2019-10-02 14:51:45 +02:00
Martin Fleisz
20c585bd18
rdpdr: Fix error code reporting for create PDUs
2019-10-01 14:34:36 +02:00
akallabeth
d5d3ebee60
Fix #5606 : Fall back to loading default printer backend.
2019-09-22 16:22:41 +02:00
Armin Novak
5e9f454256
Use stat instead of lstat to iterate /Volumes
...
Some entries are symbolic links, so follow them and check the link
target for being a directory.
2019-09-12 14:35:01 +02:00
Armin Novak
6f82ab6204
Hotplugging only for drive redirection.
2019-09-12 11:14:39 +02:00
Armin Novak
88c654ee1d
Modified printer backend to allow dynamic backends.
2019-09-06 09:28:29 +02:00
Armin Novak
2670d83cdd
freerdp_channels_load_static_addin_entry pszSubsystem empty string returns the default backend.
2019-09-04 17:15:51 +02:00
Armin Novak
15bc118d78
Names of services are now const.
2019-09-04 15:48:34 +02:00
Armin Novak
3ce1dc1972
Fix some warnings on mac os
2019-09-03 13:47:13 +02:00
Armin Novak
1b9e01509d
Refactored winmm backend
...
Using CALLBACK_FUNCTION again, but protect with semaphore to avoid closing
the device while there are still buffers to be played.
2019-09-03 15:11:18 +02:00
Armin Novak
208fbabfde
Only close local audio device if rdpsnd thread closes or output format changes.
...
Windows 7 and other older systems send one close PDU after another.
This distorts audio during setup and teardown of local sound devices.
2019-09-03 15:11:18 +02:00
Armin Novak
48f35972c8
Fixed limit check for wave confirm pdu timestamp.
2019-09-03 15:11:18 +02:00
Armin Novak
83b80f64af
Fixed uninitialized variable warning.
2019-09-03 08:55:29 +02:00
Armin Novak
f93d625cde
Use GetTickCount64 instead of GetTickCountPrecise.
2019-09-02 15:46:36 +02:00
Armin Novak
12b0b9ea28
Do not use named events, they are global!
2019-09-02 15:28:31 +02:00
Armin Novak
40964301df
Use CALLBACK_EVENT for waveOutOpen to play synchronously.
2019-09-02 15:11:54 +02:00
Martin Fleisz
29f914f178
Merge pull request #5541 from akallabeth/rdp_file_full_drivestoredirect_parsing
...
Rdp file full drivestoredirect parsing
2019-08-30 11:29:06 +02:00
kubistika
265e0848ed
rdpsnd: subsystems: Add proxy subsystem
2019-08-29 14:39:17 +02:00
kubistika
faa833f97a
rdpsnd: client: add rdpContext getter
2019-08-29 14:39:17 +02:00
Armin Novak
fdf1715213
Unified DriveStoreRedirect parsing.
2019-08-23 12:06:21 +02:00
Armin Novak
935ed36e68
Add dynamicDrives hotplug option.
2019-08-23 10:27:01 +02:00
Armin Novak
52af56d956
Added rdpsnd latency calculation.
2019-08-22 10:11:26 +02:00
Kyle Evans
d796920f8f
(FreeBSD) Build fixes for urbdrc
2019-08-19 16:57:56 +02:00
Armin Novak
c1d98d7e0a
Proper parsing of clipboard capability sets.
2019-08-19 09:30:40 +02:00
Armin Novak
74cffef053
Clipboard server callback arguments const
2019-08-19 09:30:40 +02:00
kubistika
f429275f86
channels: cliprdr: server: add autoInitializationSequence
2019-08-19 09:30:40 +02:00
kubistika
cf474bdb74
channels: cliprdr: server: call ClientCapabilities callback
2019-08-19 09:30:40 +02:00
kubistika
6cebbc2a16
channels: cliprdr: add lastRequestedFormatId
...
This one is for proxy use. The proxy must know what format is requested by the other side
of the connection, for determining if the message should be passed
or ignore (for example, if we want to allow only text, the proxy must
verify that the requested format received in Format Data Request PDU is
a text format.
2019-08-19 09:30:40 +02:00
Martin Fleisz
30c0127a29
Merge pull request #5510 from akallabeth/mac_realtime_sound
...
Mac realtime sound
2019-08-14 12:54:54 +02:00
Armin Novak
18e4245791
Added proper latency estimation for winmm sound backend.
2019-08-13 10:55:12 +02:00
Armin Novak
23069d1fe2
Convert input PCM to float format.
2019-08-12 08:13:43 +02:00
Armin Novak
5ffe2eed4e
Mostly working AVAudio backend.
2019-08-02 14:00:32 +02:00
Bernhard Miklautz
a311075202
fix [channels/smartcard]: fix StatusW_Call
...
According to 2.2.2.18 Status_Call cbAtrLen is unused an must be ignored
upon receipt.
2019-07-30 09:48:47 +02:00
Martin Fleisz
445764100b
Merge pull request #5396 from widgetii/master
...
Artur Zaprzala's rdp2tcp channel driver
2019-07-09 16:17:29 +02:00
Martin Fleisz
b80a26f82c
rail: Fixes incorrect setting of TS_RAIL_EXEC_FLAG_FILE
...
The TS_RAIL_EXEC_FLAG should only be set if ExeOrFile refers to a file
path. If we don't supply a published app name (using ||) but the name of
an application (i.e. notepad.exe) this flag was incorrectly set causing
an remote app execution error (error 5 - file not found).
2019-07-09 08:21:45 +02:00
Dmitry Ilyin
cb235debf5
PR fixes
2019-06-25 11:52:22 +03:00
Armin Novak
14c99ac061
Patch from #5436 : fix input handling with gstreamer and vaapisink
2019-06-18 13:43:44 +02:00
David Fort
2da425aa03
Merge pull request #5424 from kubistika/rdpgfx
...
rdpgfx: CacheImportOffer implementation
2019-06-13 11:35:15 +02:00
Kobi
d9366df448
RDPEDISP server side implementation ( #5414 )
...
* libfreerdp: Add RDPEDISP server implementation
* server/proxy: Add RDPEDISP support
2019-06-11 16:13:42 +02:00
kubistika
bf618fb929
rdpgfx/client: Update gfx->UnacknowlegedFrame correctly
2019-06-06 10:24:27 +03:00
kubistika
49e7c5ddc0
rdpgfx/server: Fix formatting: rdpgfx_recv_cache_import_offer_pdu
2019-06-06 07:53:34 +03:00
kubistika
bf97d3e041
rdpgfx/client: Expose QoeFrameAck
2019-06-06 07:53:34 +03:00
kubistika
98e09af2ff
rdpgfx/client: Implement CacheImportOffer PDU
2019-06-06 07:53:34 +03:00
kubistika
e2eeb9f870
rdpgfx: Add WITH_DEBUG_RDPGFX option
2019-06-04 10:29:05 +03:00
Idan Freiberg
2ee8b2cbbd
channels: ssh-agnet: cmake: turn off server side channel by default in ChannelsOptions.cmake
( #5420 )
...
CMake v3.5.1 throws the following error if this is not set:
```
CMake Error at channels/CMakeLists.txt:48 (if):
if given arguments:
"OFF" "OR"
Unknown arguments specified
Call Stack (most recent call first):
channels/sshagent/ChannelOptions.cmake:6 (define_channel_options)
channels/CMakeLists.txt:273 (include)
```
2019-06-03 09:47:35 +02:00
David Fort
6563bc28c4
rail: added verbose logs ( #5402 )
...
* rail: added verbose logs
* rail: fix buffer initialisation in debug message
2019-05-23 12:15:26 +02:00
Dmitry Ilyin
c537b1749c
format after VS2010
2019-05-15 22:41:25 +03:00
Dmitry Ilyin
39bd28bcb8
VS2010 adaptation
2019-05-15 20:33:35 +01:00
Dmitry Ilyin
eee7d4b783
proper code format
2019-05-15 20:12:33 +03:00
Armin Novak
8666d7e59b
Fixed mapping of new client sysparam values.
2019-05-15 15:25:04 +02:00
Dmitry Ilyin
f6c0c7ba7c
fix for loop for ancient compilers
2019-05-14 21:44:33 +03:00
Dmitry Ilyin
2cfb2839f4
Artur Zaprzala's rdp2tcp channel driver
2019-05-14 21:04:39 +03:00
Martin Fleisz
ccd1fc71e9
Merge pull request #5327 from akallabeth/sign_compare_fixes_v3
...
Leak and warning fixes for 2.0
2019-05-09 13:21:36 +02:00
Martin Fleisz
6633e01891
Merge pull request #5392 from akallabeth/gfx_avc_flag_fixes
...
Fixed GFX flags and CapsConfirm return checks
2019-05-09 13:16:08 +02:00
Armin Novak
f22b77d49c
Fixed GFX flags and CapsConfirm return checks
2019-05-09 12:46:10 +02:00
Armin Novak
a2834ae233
Fixed rails set_caretwidth
2019-05-09 12:28:27 +02:00
Armin Novak
2cc714a57d
Updated RAILS implementation
...
* Implement new messages and callbacks
* Announce most recent channel features
* Added settings to configure flags to announce
2019-05-08 17:25:15 +02:00
Armin Novak
60a82854c1
For smartcard trace functions use const arguments
2019-05-08 15:13:03 +02:00
Armin Novak
4b72a85e91
Fixed possible memory leak.
2019-05-08 15:12:40 +02:00
Armin Novak
ea421ed52e
Fixed index data type
2019-05-08 15:12:40 +02:00
Martin Fleisz
50566c2171
Merge pull request #5385 from akallabeth/some_unused_parameter_silenced
...
Some unused parameter silenced
2019-05-08 14:16:05 +02:00
Armin Novak
8f7e1579fd
Silenced unused parameter warnings in smartcard trace
2019-05-08 12:27:51 +02:00
Armin Novak
48a12ae131
Fixed memory leak and return values in rdpgfx_recv_caps_advertise_pdu
2019-05-08 12:05:58 +02:00
Armin Novak
7b2608a938
Added gfx capability filter option.
...
With this new option it is possible to selectively disable certain
GFX capability versions. This way buggy behaviour can be addressed
at runtime.
2019-05-08 11:43:22 +02:00
Armin Novak
1bb933b991
Fixed missing argument checks.
...
The arguments for rdpgfx_send_frame_acknowledge_pdu must be checked
as in some call stacks they might be NULL.
2019-05-07 13:46:24 +02:00
Armin Novak
3b7e46fb0e
Updated GFX to 10.6 spec
2019-05-07 12:10:13 +02:00
akallabeth
95b8b43d4d
Merge pull request #5376 from kubistika/bugfix/rdpgfx-server-v10.6-PDUs
...
rdpgfx: Fix GFX v10.6 PDUs parsing and naming according to the spec
2019-05-06 15:32:32 +02:00
akallabeth
314fcee41e
Merge pull request #5377 from m4ntis/gfx/fix-caps-confirm-recv
...
client/rdgpfx_main.c: Fix rdpgfx_recv_caps_confirm_pdu caps length read
2019-05-06 12:51:23 +02:00
Mati Shabtay
2048708235
client/rdpgfx_main.h: Formatting
2019-05-05 16:27:11 +03:00
Armin Novak
841cb70f91
Fixed const correctness of gfx function pointer
...
Signed-off-by: Mati Shabtay <matishabtay@gmail.com>
2019-05-05 16:17:15 +03:00
Mati Shabtay
eee234c239
rdpgfx/client: Add callbacks for manual caps sending and frame acking
2019-05-05 15:56:35 +03:00
Mati Shabtay
e9dfe13a70
client/rdgpfx_main.c: Fix rdpgfx_recv_caps_confirm_pdu caps length read
2019-05-05 13:39:04 +03:00
kubistika
e9faaedc85
rdpgfx: Fix GFX v10.6 PDUs parsing and naming according to the spec
2019-05-05 12:34:57 +03:00
r-barnett
40ef08ddc5
Fix smartcard segfault when no devices are present ( #5364 )
...
* Don't assume smartcard reader list is not empty.
* Check status of retrieval of smartcard device list before trying to filter it
* style fixes
2019-05-02 06:11:57 +02:00
Martin Fleisz
25fc56a625
Merge pull request #5260 from akallabeth/rail_spec_update
...
Rail spec update
2019-04-29 11:27:26 +02:00
Martin Fleisz
6eb108058e
Merge pull request #5306 from akallabeth/gfx_server_caps_input_checks
...
Fixed input stream length checks in rdpgfx_recv_caps_advertise_pdu
2019-04-29 11:27:06 +02:00
Armin Novak
5e42c8943d
Fixed typo in RAIL_ZORDER_SYNC
2019-04-26 13:14:30 +02:00
Armin Novak
8af9c138e3
Fixed input stream length checks in rdpgfx_recv_caps_advertise_pdu
2019-04-26 13:11:46 +02:00
Pascal J. Bourguignon
431c37f3a9
5360 segfault using smartcard without any readers ( #5361 )
...
* Fix: corrected test for astyle.
* Fix: added test for NULL readers returned by ConvertFromUnicode.
2019-04-26 09:10:41 +02:00
Mati Shabtay
e1ef302a8d
rail_orders.c: Fix wrong callback call on server handshake ex recv ( #5345 )
2019-04-25 10:55:24 +02:00
David Fort
7ae72ee512
Merge pull request #5240 from akallabeth/sign_compare_fixes_v2
...
Sign compare fixes v2
2019-04-05 14:13:03 +02:00
Mati Shabtay
6e8c02c9ee
Added optional PreFrameAck callback to RdpgfxClientContext ( #5303 )
...
* RdpgfxClientContext: Add PreFrameAck callback
* client/rdpgfx_main.c: Call PreFrameAck callback before acking frame
* client/rdpgfx_main.c: Fix windows_msbuild_vs2010 CI build
* client/rdpgfx_main.c: Fix error logs log level
2019-04-05 13:37:51 +02:00
Armin Novak
9218712ecf
Remove unnecessary clipboard data copy.
2019-04-05 10:04:36 +02:00
David Fort
e0d60a0310
clipboard: correctly handle flags during renegociatiion ( #5323 )
2019-04-05 09:36:53 +02:00
Armin Novak
624d895106
Fixed sign issues
2019-04-05 09:22:35 +02:00
Armin Novak
27d2a9e040
Fixed unused argument warnings.
2019-04-05 09:14:35 +02:00
Armin Novak
5612cbd8e6
Fixed dead store warnings
2019-04-05 09:14:35 +02:00
Armin Novak
6c9130f7d6
Fixed sign-compare warnings.
2019-04-05 09:14:35 +02:00
Armin Novak
4360033405
Fixed const free warning.
2019-04-05 09:13:24 +02:00
Armin Novak
426137a7f0
Fixed sign-compare warnings
2019-04-05 09:13:24 +02:00
Armin Novak
93ad9a2092
Fixed sign-compare warnings
2019-04-05 09:13:24 +02:00
Armin Novak
3eb3ad3cab
Fixed sign-compare warnings
2019-04-05 09:13:24 +02:00
Armin Novak
856252a62f
Fixed sign-compare warnings
2019-04-05 09:13:24 +02:00
Armin Novak
b9b3f3eda7
Fixed sign-compare warnings
2019-04-05 09:13:24 +02:00
Armin Novak
116383897e
Fixed sign-compare warnings
2019-04-05 09:13:24 +02:00
Armin Novak
4430187e8d
Fixed sign-compare warnings
2019-04-05 09:13:24 +02:00
Armin Novak
52b03cd408
Addin function pointers now expect const strings
2019-04-05 09:13:24 +02:00
David Fort
37358e81d0
Merge pull request #5285 from akallabeth/urbdrc_preparations
...
Channel, log debug and semaphore related fixes
2019-04-04 18:21:47 +02:00
David Fort
39f7486211
Merge pull request #5318 from akallabeth/filetime_fix
...
Fix #5317 : Change file attributes before modifying file time.
2019-04-04 18:06:22 +02:00
David Fort
058ae0db57
Merge pull request #5273 from akallabeth/mac_compile_warning_fix
...
Fixed mac compilation warnings.
2019-04-04 18:03:50 +02:00
Armin Novak
485061e4d0
Fix #5317 : Change file attributes before modifying file time.
2019-03-29 15:45:52 +01:00
Mati Shabtay
5d808226af
client/rdpgfx_main.c: Fix wire to surface 2 pixel format decode
2019-03-18 16:07:18 +02:00
Mati Shabtay
88b7859c87
server/rdpgfx_main.c: Fixed caps advertise PDU recv ( #5304 )
2019-03-15 08:37:35 +01:00
Armin Novak
11cefecb7b
Temporarily disable GFX version >= 10.3
2019-03-04 09:07:27 +01:00
Armin Novak
9be2324be8
Disabled RDPGFX_CAPVERSION_106 for good.
2019-02-28 13:43:11 +01:00
Armin Novak
69e9571d9e
Fixed EGFX capability parsing, respect length fields.
...
Disable RDPGFX_CAPVERSION_106 as we currently do not support scaled
outputs.
2019-02-27 17:15:43 +01:00
Armin Novak
e8c8e7b6d0
Updated EGFX support to 10.6
2019-02-27 16:36:15 +01:00
Armin Novak
0bba166020
Force close channel, use defines instead of magic numbers
...
* When senging a close request for a dynamic channel close the channel
immediately. A response from the server is not guaranteed.
* Use the *_PDU defines instead of magic numbers when creating
dynamic channel messages.
2019-02-26 15:29:30 +01:00
Armin Novak
9566ae0e90
Fixed mac compilation warnings.
2019-02-21 17:30:12 +01:00
Armin Novak
3680d9f7d2
Fixed cast warnings from freerdp_load_channel_addin_entry
2019-02-21 13:54:25 +01:00
Armin Novak
37ed4bffd0
Fixed conversion warnings.
...
Range checks and type casts to remove all warnings in printer channel.
2019-02-21 11:43:59 +01:00
Armin Novak
aacf5bddc4
Updated rail channel, supporting all new messages.
2019-02-19 15:04:11 +01:00
Armin Novak
5904cad1f7
Replaced hardcoded xfreerdp program name
2019-02-12 10:53:30 +01:00
Martin Fleisz
22e666d2d0
Merge pull request #5225 from akallabeth/rdprd_caps_read_fix
...
Fixed size checks when reading rdpdr capabilities.
2019-02-08 09:05:27 +01:00
Bernhard Miklautz
162a69b0f0
Merge pull request #5139 from akallabeth/drive_hotplug_shutdown_crash_fix
...
Fixed crash on drive hotplug shutdown.
2019-02-07 10:08:41 +01:00
Armin Novak
ef1728faf5
Fixed NULL dereferences and uninitialized values
2019-01-30 16:11:10 +01:00
Armin Novak
0d3c1d4aab
Fixed rect assignment in geometry channel.
2019-01-30 13:46:59 +01:00
Armin Novak
79416f5d32
Fixed missing initializers
2019-01-29 17:48:49 +01:00
Armin Novak
2e5fd8d16b
Fixed clang analyzer false positive memory leaks.
...
Added a justification for each #ifndef __clang_analyzer__
2019-01-29 17:17:30 +01:00
Armin Novak
d5720b7999
Fixed clang scanbuild false positive memory leak.
...
The memset did confuse the analyzer. Remove it as the variable
is already initialized to zero.
2019-01-29 17:17:24 +01:00
Armin Novak
0dae6933ce
Fixed uninitialized return value.
2019-01-29 16:53:30 +01:00
Armin Novak
51039f6535
Fixed compiler warnings #5210
2019-01-29 16:15:23 +01:00
David Fort
70805402be
Merge pull request #5140 from akallabeth/print_custom_component
...
Added callback to handle printer custom components in printer backend.
2019-01-29 15:18:53 +01:00
Armin Novak
dd9814df84
Fixed review remarks.
2019-01-29 14:21:58 +01:00
Armin Novak
711c726222
Fixed static analyzer warnings for dynamic channel.
2019-01-29 12:07:05 +01:00
Armin Novak
17bfa1c0d1
Added missing data range checks for geometry channel.
2019-01-29 11:57:24 +01:00
Armin Novak
8b7da77f36
Fixed size checks when reading rdpdr capabilities.
2019-01-29 11:50:27 +01:00
akallabeth
0a8ebcfcac
Merge pull request #5187 from astrand/mingw-part1
...
Mingw build fixes part1
2019-01-29 10:46:21 +01:00
Armin Novak
4ba73e0c73
Fixed warnings found by compiler and static analysis.
2019-01-24 11:53:52 +01:00
Armin Novak
65812bdbc0
Clipboard data pointer arguments are now const.
2019-01-23 16:55:13 +01:00
Vic Lee
e2df67ab34
rdpsnd/winmm: remove an unnecessary blocking event.
2019-01-18 17:51:14 +08:00
Armin Novak
805741bdf6
Fixed #5185 broken file size initialization.
2019-01-14 14:54:33 +01:00
Peter Åstrand (astrand)
30cd1ba1ab
Use lowercase for includes and libs
...
Makes build possible on case sensitive systems such as MinGW on Linux.
2019-01-09 09:36:28 +01:00
Martin Fleisz
aa442de059
Merge pull request #5174 from chipitsine/master
...
resolve several issues found by cppcheck
2019-01-07 15:21:46 +01:00
Ilya Shipitsin
05462d27fb
remove identical code, found by coverity
2019-01-04 20:56:57 +05:00
Ilya Shipitsin
bdc039e719
resolve several issues found by cppcheck
...
[client/X11/xf_floatbar.c:800] -> [client/X11/xf_floatbar.c:796]: (warning) Either the condition '!floatbar' is redundant or there is possible null pointer dereference: floatbar.
[client/X11/xf_floatbar.c:800] -> [client/X11/xf_floatbar.c:797]: (warning) Either the condition '!floatbar' is redundant or there is possible null pointer dereference: floatbar.
[client/X11/xf_floatbar.c:800] -> [client/X11/xf_floatbar.c:798]: (warning) Either the condition '!floatbar' is redundant or there is possible null pointer dereference: floatbar.
[libfreerdp/codec/dsp.c:1156] -> [libfreerdp/codec/dsp.c:1154]: (warning) Either the condition '!srcFormat' is redundant or there is possible null pointer dereference: srcFormat.
[channels/drdynvc/client/drdynvc_main.c:1453] -> [channels/drdynvc/client/drdynvc_main.c:1450]: (warning) Either the condition '!drdynvc' is redundant or there is possible null pointer dereference: drdynvc.
[channels/audin/client/opensles/audin_opensl_es.c:98] -> [channels/audin/client/opensles/audin_opensl_es.c:94]: (warning) Either the condition '!opensles' is redundant or there is possible null pointer dereference: opensles.
[channels/audin/client/opensles/audin_opensl_es.c:159] -> [channels/audin/client/opensles/audin_opensl_es.c:153]: (warning) Either the condition '!opensles' is redundant or there is possible null pointer dereference: opensles.
2019-01-02 20:35:24 +05:00
Bernhard Miklautz
9f6abd2701
fix [channels]: remove sshagent server side
...
The server side channel wasn't tested and does not work this way with
FreeRDP. Rely on the server side channel that come with the RDP
server(s).
2018-12-13 10:17:46 +01:00
Armin Novak
34c9404c98
Added OpenSSL include path globally.
2018-12-12 15:41:29 +01:00
Armin Novak
31d5a3b0c3
Don't reset configuration and driver name when supplied via command line.
2018-12-12 14:42:50 +01:00
Armin Novak
d13bd66f5a
Implemented printer name based backend to remember settings.
2018-12-12 14:36:18 +01:00
Armin Novak
192680a001
Added callback to handle printer custom components in printer backend.
2018-12-12 10:57:53 +01:00
Armin Novak
598ece4ae7
Fixed crash on drive hotplug shutdown.
2018-12-12 09:32:09 +01:00
Bernhard Miklautz
2fe1c786c4
Merge pull request #5075 from akallabeth/clipboard_channel_cleanup
...
Fixed clipboard channel cleanup.
2018-12-11 09:12:24 +00:00
Armin Novak
fdf9ca3273
Fixed #5113 : The timestamps for FileFullDirectoryInformation were inverted.
2018-12-07 10:59:52 +01:00
Armin Novak
81a0cd7010
Fixed clipboard channel cleanup.
2018-11-28 11:40:57 +01:00
Armin Novak
6c02a1c7d8
Fixed version check for remote assistance channel.
2018-11-22 11:11:31 +01:00
Armin Novak
6de2129a90
assistance v2 support
2018-11-22 11:11:31 +01:00
Bernhard Miklautz
010e3485cb
Merge pull request #4989 from akallabeth/dsp_encode_resample
...
Added resampling to freerdp_dsp_encode.
2018-11-15 15:54:56 +00:00
Bernhard Miklautz
d915491717
Merge pull request #5012 from akallabeth/rail_app_icons
...
Rail app icons
2018-11-15 08:50:56 +00:00
Armin Novak
5490ceb4ed
Fixed source format for freerdp_dsp_encode in rdpsnd_server_send_wave_pdu
2018-11-14 13:27:20 +01:00
Armin Novak
0f45a570fa
Added fallback for supported sample rates if original not supported.
...
Added format compatibility check between recording input and destination.
2018-11-14 13:27:20 +01:00
Armin Novak
93eea24120
Fixed possible NULL pointer dereference
2018-11-14 13:27:20 +01:00
Armin Novak
83f959ce6b
Fixed format issues with server sound channel (review by @llysz)
2018-11-14 13:27:20 +01:00