14421 Commits

Author SHA1 Message Date
Linus Heckemann
3c24e10bf3 shadow_server: allow specifying IP addresses to listen on (#6050)
* shadow_server: allow specifying IP addresses to listen on

This allows using IPv6 as well as listening only on specific
interfaces. Additionally, it enables listening on local and TCP
sockets simultaneously.

* listener: log address with square brackets

This disambiguates IPv6 addresses.

* shadow_server: check error on each socket binding

* Refactored shadow /bind-address for 2.0 compiatibility.

* Made /ipc-socket and /bind-address incompatible arguments.

* Fixed shadow /bind-address handling and description

* Allow multiple bind addresses for shadow server.

Co-authored-by: akallabeth <akallabeth@posteo.net>
2020-05-08 11:06:02 +02:00
akallabeth
eee9dead2d Fixed compiler warnings for usb channel 2020-05-08 11:06:02 +02:00
akallabeth
c903aa0409 Fixed index out of bound access in update_glyph_offset 2020-05-08 11:06:02 +02:00
akallabeth
63fbc976be Unified INLINE definition 2020-05-08 11:06:02 +02:00
Armin Novak
a8c6f012d8 Silence SCARD_E_TIMEOUT warnings
These occur quite often for status calls, so reduce log verbosity.
2020-05-08 11:06:02 +02:00
akallabeth
e928888dab Fixed various input buffer length checks in URBDRC
Thanks to hac425 CVE-2020-11039
2020-05-08 11:06:02 +02:00
akallabeth
c1cef2d68c Fixed int overflow in smartcard_ndr_read
Thanks to hac425
2020-05-08 11:06:02 +02:00
akallabeth
af2ce439e1 Fixed int overflow in msusb_mspipes_read
Thanks to hac425
2020-05-08 11:06:02 +02:00
akallabeth
4c07a00403 Fixed int overflow in printer_write_setting
Thanks to hac425
2020-05-08 11:06:02 +02:00
akallabeth
98a4cd28bd Fixed int overflow in PresentationContext_new
Thanks to hac425 CVE-2020-11038
2020-05-08 11:06:02 +02:00
akallabeth
0f266b5362 Fixed #6112: Segfault in update_decompress_brush
The iterators need to be signed for the loop check to work.
2020-05-05 07:46:10 +02:00
akallabeth
e35d06f6e1 Fixed oob read in rfx_process_message_tileset
Check input data length
Thanks to hac425 CVE-2020-11043
2020-05-05 07:46:10 +02:00
akallabeth
32f705e597 Fixed oob read in clear_decompress_subcode_rlex
Fixed length checks before stream read.
Thanks to hac425 CVE-2020-11040
2020-05-05 07:46:10 +02:00
akallabeth
7c94b425e6 Fixed oob read in rdpsnd_recv_wave2_pdu
Check format index before using it.
Thanks to hac425 CVE-2020-11041
2020-05-05 07:46:10 +02:00
akallabeth
738d4bff00 Fixed oob read in update_recv
properly use update_type_to_string to print update type.
Thanks to hac425 CVE-2020-11019
2020-05-05 07:46:10 +02:00
akallabeth
f5b838de37 update_decompress_brush: explicit output length checks
The output length was just assumed to be >= 256 bytes, with this
commit it is explicitly checked.
2020-05-05 07:46:10 +02:00
akallabeth
00b5ff301f Fixed clipboard 'called with invalid type' warning 2020-05-05 07:46:10 +02:00
akallabeth
f3de3ee16b Fix short format name configuration and format list return. 2020-05-05 07:46:10 +02:00
akallabeth
13dac0ee2a Fixed possible int overflow. 2020-05-05 07:46:10 +02:00
akallabeth
09d0124418 Remove unnecessary cast. 2020-05-05 07:46:10 +02:00
akallabeth
55f18cb8a5 Fix oob read in msusb_msconfig_read 2020-05-05 07:46:10 +02:00
akallabeth
a1a6790f99 Fixed oob read in irp_write and similar 2020-05-05 07:46:10 +02:00
akallabeth
b375d84ed6 Fixed oob read in parallel_process_irp_create 2020-05-05 07:46:10 +02:00
akallabeth
8d3d953264 Fixed oob read in parallel_process_irp_read 2020-05-05 07:46:10 +02:00
akallabeth
1d28ba56bd Fixed oob read in parallel_process_irp_write 2020-05-05 07:46:10 +02:00
akallabeth
19694b0110 Fixed oob read in ntlm_read_AuthenticateMessage 2020-05-05 07:46:10 +02:00
akallabeth
c098f21fda Fixed oob read in ntlm_read_ntlm_v2_response 2020-05-05 07:46:10 +02:00
akallabeth
f59ad0f15c Fixed oob read in ntlm_read_NegotiateMessage 2020-05-05 07:46:10 +02:00
akallabeth
b73143cf7e Fixed oob read in cliprdr_read_format_list 2020-05-05 07:46:10 +02:00
akallabeth
495cb2e312 Fixed cliprdr_server_receive_capabilities
Thanks to hac425 CVE-2020-11017, CVE-2020-11018
2020-05-05 07:46:10 +02:00
Armin Novak
bc4615e5ed Added expert settings /tune and /tune-list 2020-05-05 07:46:10 +02:00
akallabeth
da03f7e04e Fixed #6122: Allow SSL server and client purpose 2020-05-05 07:46:10 +02:00
akallabeth
55ee2cce34 Fixed #6087: Inconsistend scroll on wayland
Thanks to @yol and @SaschaWessel a bug in scroll step conversion
was uncovered. The RDP value ranges are inverted when scrolling
in negative direction.
2020-05-05 07:46:10 +02:00
qarmin
9fd86bee46 Don't allow to overflow dev_array array 2020-05-05 07:46:10 +02:00
qarmin
59aa24e1e5 Fixed copy paste error in MessagePipe.c 2020-05-05 07:46:10 +02:00
Sascha Wessel
fa059c8912 libuwac/input: Fix memory leak
`create_pointer_buffer()` allocates memory with `mmap` and never frees it.

Adding a corresponding `munmap` fixes this issue.
2020-05-05 07:46:10 +02:00
akallabeth
c0a17eb342 Fixed #6121: Use correct destination color format 2020-05-05 07:46:10 +02:00
akallabeth
5d56937e20 Workaround #6072: FFMPEG AAC encoding graded experimental
Due to many reporing issues with different AAC encoder configurations
deactivate support by default. Can be enabled by compiling with
experimental codec support.
2020-05-05 07:46:09 +02:00
Sascha Wessel
fe9a5ae5a9 wlfreerdp/cliprdr: Initialize pointer before use
In `wlf_cliprdr_server_format_data_request()` `ConvertToUnicode()` may return 0
while not allocating memory for `cdata` and not setting `cdata` to a valid
address. In this case, `data` points to a random address.

Settting `cdata` to NULL before calling `ConvertToUnicode()` fixes this issues.
2020-05-05 07:46:09 +02:00
Sascha Wessel
a74d5b630c libuwac/window: Fix memory leak / SIGBUS
`UwacWindowShmAllocBuffers()` allocates memory with `mmap` and never frees it
resulting in SIGBUS errors and running out of memory after some time.

Adding a corresponding `munmap` fixes this issue.
2020-05-05 07:46:09 +02:00
Lukas Fink
6425313776 Fixes null dereference bug
Avoids a null function pointer dereference that happened, when
freerdp_urbdrc_client_subsystem_entry failed before invoking
udevman_load_interface.
2020-05-05 07:46:09 +02:00
Lukas Fink
aae9640beb Implemented udevman->hotplug_vid_pids as wArrayList 2020-05-05 07:46:09 +02:00
Lukas Fink
c668d66e88 Added ability to add usb devs via id and addr simultaneously
It is now possible to add usb devices both via vid+pid and via bus+addr
at the same time. To do this, the ids are directly
given to the corresponding command line options:
/usb🆔<vid+pids>,addr:<bus+addrs>
The dev option still works like before: /usb:id,dev:<vid+pids> or
/usb:addr,dev:<bus+addrs>
2020-05-05 07:46:09 +02:00
Lukas Fink
efb929644e Added hotplug to /usb:id,dev option
Devices specified with the /usb:id,dev command line option are now
detected by the hotplug callback.
2020-05-05 07:46:09 +02:00
Lukas Fink
2e86e36200 Fixed /usb:dev command line option
The /usb:dev command line option failed silently, because it tried to add the
devices before urbdrc gets initialized. This commit adds a new function
to udevman, that gets called when the urbdrc addin is initialized.
Registering of the given devices is now performed there.
2020-05-05 07:46:09 +02:00
Raul Fernandes
54c902b3b5 Optimize function xcrush_copy_bytes()
Use memcpy to copy the bytes when we can assure that the memory areas does not overlap.
When the areas overlap, copy the area that doesn't overlap repeatly.
With this change, the copy is ~30x faster.
2020-05-05 07:46:09 +02:00
Zhu Qun-Ying
2ed941f9e2 possible memory leak when various functions return failure. (#6110)
* possible memory leak when allocation failed.

* Use initialization in stead of ZeroMemory

* Format with clang-format
2020-05-05 07:46:09 +02:00
Zhu Qun-Ying
63c76ae02d use WINPR_MD5_DIGEST_LENGTH in stead of magic number for hash array 2020-05-05 07:46:09 +02:00
Zhu Qun-Ying
47be0ea985 Use NTOWFv2FromHashW() in NTOWFv2W() to avoid duplicate code 2020-05-05 07:46:09 +02:00
Allan Nordhøy
cf13402baf Spelling fixes for iOS strings 2020-05-05 07:46:09 +02:00