Commit Graph

43 Commits

Author SHA1 Message Date
Bernhard Miklautz
bf73f4e4f1 Fix unchecked strdups
* add missing checks
* adapt function return values where necessary
* add initial test for settings
2015-06-22 19:09:59 +02:00
Marc-André Moreau
6b1fefea40 freerdp: fix remote assistance mode, add multi-address connection 2015-05-06 16:32:45 -04:00
Norbert Federa
ef1fd12b15 Fix unchecked CreateEvent calls and misc fixes
1)
Added missing checks for CreateEvent which also required the
following related changes:

- changed freerdp_context_new API to BOOL
- changed freerdp_peer_context_new API to BOOL
- changed pRdpClientNew callback to BOOL
- changed pContextNew callback to BOOL
- changed psPeerAccepted callback to BOOL
- changed psPeerContextNew callback to BOOL

2)
Fixed lots of missing alloc and error checks in the
changed code's neighbourhood.

3)
Check freerdp_client_codecs_prepare result to avoid segfaults
caused by using non-initialized codecs.

4)
Fixed deadlocks in x11 caused by missing xf_unlock_x11() calls
in some error handlers

5)
Some fixes in thread pool:
- DEFAULT_POOL assignment did not match TP_POOL definition
- don't free the pool pointer if it points to the static DEFAULT_POOL
- added error handling and cleanup in InitializeThreadpool
2015-04-29 18:18:39 +02:00
Bernhard Miklautz
3c7662517c hardening
Start to add missing checks for:
* *alloc
* *_New
2015-03-25 17:38:21 +01:00
Armin Novak
c380fb3520 Added flag to ignore unknown keywords
freerdp_client_settings_parse_command_line now allows ignoring
unknown keywords.
2015-03-16 10:15:37 +01:00
Marc-André Moreau
d8e10ac04a freerdp: patch leaks reported by valgrind when using TS Gateway 2014-12-11 11:25:34 -05:00
Marc-André Moreau
b56eaccdc3 Merge branch 'master' of github.com:FreeRDP/FreeRDP
Conflicts:
	client/common/client.c
2014-07-28 16:58:32 -04:00
Justin DeFields
65aab2569d Move multimon/span logic from cmdline.c to client.c post processing 2014-07-28 15:24:48 -04:00
Bernhard Miklautz
ff26a90489 return status instead of returning directly 2014-07-28 18:49:18 +02:00
Bernhard Miklautz
32bb18152a cmdline post: cleanup in case of oom 2014-07-28 17:57:51 +02:00
Bernhard Miklautz
f06490b426 fix freerdp_client_settings_post_processing 2014-07-28 17:52:40 +02:00
Marc-André Moreau
2036b443eb libwinpr-wtsapi: fix WtsApi32.dll dynamic loading on Windows 2014-07-26 15:23:39 -04:00
Justin DeFields
2e859a5d14 Removed GatewayUseSameCredentials logic from cmdline.c, and placed it after both cmdline and rpd file have been parsed. This provides proper GatewayUseSameCredentials support for the rdp file 2014-07-24 16:07:14 -04:00
Marc-André Moreau
b60eff8e42 channels/remdesk: start sending authentication data 2014-06-30 12:51:27 -04:00
Marc-André Moreau
7a50525880 libfreerdp-common: move assistance code 2014-06-30 09:40:24 -04:00
Marc-André Moreau
af1be38775 client/common: parse and use remote assistance file 2014-06-28 18:33:46 -04:00
Marc-André Moreau
f963491ebe libfreerdp-client: cleanup .rdp file parsing 2013-12-05 12:35:31 -05:00
Marc-André Moreau
73196c3777 libfreerdp-common: add fine grained control over .rdp file writing functions 2013-12-04 18:25:55 -05:00
Benoît LeBlanc
7215f4295f Merge branch 'master' of git://github.com/awakecoding/FreeRDP
Conflicts:
	include/freerdp/client.h
2013-11-07 10:42:35 -05:00
Marc-André Moreau
d754e4f9a8 Fixed memory corruption that occured when writing rdpFile to disk 2013-11-07 10:37:46 -05:00
Benoît LeBlanc
ce34923959 Merge branch 'master' of git://github.com/awakecoding/FreeRDP
Conflicts:
	libfreerdp/core/gateway/tsg.c
	libfreerdp/crypto/tls.c
2013-11-04 09:12:26 -05:00
Benoît LeBlanc
993f5f18b8 added const to buffer parameters in functions 2013-11-04 09:10:05 -05:00
Marc-André Moreau
3bc47a2bf8 libfreerdp-core: fix leaks and potential use after free 2013-10-31 21:12:06 -04:00
Benoît LeBlanc
5bfca61261 setting pointers to NULL after freeing memory to avoid crashes.
gitignore: only top-level "external" folder is ignored.
2013-10-22 17:05:41 -04:00
Marc-André Moreau
59eccac4e7 libfreerdp-client: refactor and decouple rdpSettings* from client context 2013-10-12 21:07:12 -04:00
Marc-André Moreau
b70ecbbf62 libfreerdp-core: decouple initialization of rdpSettings from freerdp* instance 2013-10-12 18:20:25 -04:00
Benoît LeBlanc
d274363b1a Fixed client crash at close. Entry points were freed too soon. 2013-10-02 14:34:10 -04:00
Marc-André Moreau
e62e78c24b libfreerdp-client: fix registration of static addin table (don't associate it with command-line parsing) 2013-09-19 16:25:10 -04:00
Marc-André Moreau
10f1a898ef libfreerdp-client: fix command-line parsing with .rdp file 2013-09-17 17:03:35 -04:00
Armin Novak
2f20a8c12b Fixed various memory leaks and resource deallocation problems. 2013-08-19 17:44:52 +02:00
Marc-André Moreau
fe62e8c69b Merge branch 'master' of github.com:mrthebunny/FreeRDP 2013-07-15 17:14:20 -04:00
Marc-André Moreau
5926fa36dd libfreerdp-client: use PubSub for OnChannelConnected/OnChannelDisconnected 2013-07-11 08:53:15 -07:00
Benoît LeBlanc
f9bac0fce9 Added public API function
freerdp_client_write_connection_file()

For now, all settings are written to the RDP file. This can be switched with the WRITE_ALL_SETTINGS define in file.c
2013-07-05 23:20:56 -04:00
Benoît LeBlanc
c17c2f811b FreeRDP:
- replaced char* by const char* in function prototypes
- MacFreeRDP: moved assignation of context function pointers
- freerdp: added more pointer and return value validations to prevent crashes
2013-07-04 14:42:40 -04:00
Benoît LeBlanc
bc83a8700c mac client: cleanup, removed RAIL, global var 2013-06-17 21:21:42 -04:00
Marc-André Moreau
59b7c53c5f freerdp: remove temporary rdpClient* interface and replace with pubSub hooks 2013-06-15 17:39:45 -04:00
Marc-André Moreau
6c9a3b8e64 freerdp: start using pubSub for client GUI events 2013-06-15 17:01:10 -04:00
Marc-André Moreau
010f1dfdd9 xfreerdp: add rdpClientContext common section 2013-06-14 15:07:17 -04:00
Marc-André Moreau
a8c268a9ff xfreerdp: improve common client API 2013-06-13 22:11:23 -04:00
Marc-André Moreau
208c9f844a freerdp: fix core API bugs 2013-06-13 21:34:46 -04:00
Marc-André Moreau
8eaa32ac8f xfreerdp: merge with benoit's client API update 2013-06-13 17:52:24 -04:00
Benoît LeBlanc
115b3978c6 Updating common API 2013-06-13 16:18:19 -04:00
Marc-André Moreau
8cfb69623e libfreerdp-channels: add libfreerdp-client and libfreerdp-server libraries that bundle client/server static channels 2012-10-14 03:43:10 -04:00