David FORT
f8d6eb226c
Fixed last VirtualChannelEntry
2015-05-19 13:56:48 +02:00
David FORT
6fb3f390a0
Fixed functions that return BOOLs
2015-05-19 13:48:57 +02:00
Bernhard Miklautz
d922afc24a
smartcard: fix compiler warnings
...
gcc 4.7.2:
warning: passing argument 1 of ‘free’ discards ‘const’ qualifier from
pointer target type
2015-05-18 11:36:31 +02:00
Hardening
f8120919af
Add checks for some XXX_New and XXX_Add functions
...
Based on PR #2616
2015-05-18 11:28:00 +02:00
Norbert Federa
1eff1a345e
free can handle NULL perfectly fine
2015-05-11 09:07:39 +02:00
Bryan Everly
9865854f3c
Simplified random byte stream generation code to use SSL RAND_bytes() and also eliminated two more compiler warnings.
2015-05-05 12:33:44 -04:00
Norbert Federa
25fc866a58
Fix unchecked CreateThread calls and misc fixes
2015-05-05 13:55:48 +02:00
Mike McDonald
b6cb94b60e
Fixed protocol parsing issue in general capability set. The SpecialTypeDeviceCap field is only present when the Version field is set to GENERAL_CAPABILITY_VERSION_02.
2015-04-22 17:33:42 -04:00
Bryan Everly
a2a1d06d9b
Necessary changes to get latest branch working on OpenBSD 5.6
2015-04-21 14:44:02 -04:00
Bryan Everly
8c75127a67
Necessary changes to get latest branch working on OpenBSD 5.6
2015-04-21 14:42:06 -04:00
Armin Novak
449929fc35
Fixed NULL dereference.
2015-04-15 10:37:28 +02:00
Maxim
9b8754ca72
Update urbdrc_main.c
2015-04-12 14:51:27 +03:00
Maxim
d4ad03bbf0
fixed buffer overflow at sprintf
2015-04-10 15:44:27 +03:00
Maxim
0b39a1f72a
fixed undefined behaviour of sprintf, buffer overflow
2015-04-08 18:21:52 +03:00
David FORT
cf8c7631bd
Kill more exit() occurences
...
In general we should not have any exit() call in libfreerdp.
2015-03-31 23:56:40 +02:00
Armin Novak
e68726400d
Fixed NULL pointer dereference.
2015-03-31 15:18:45 +02:00
Bernhard Miklautz
79de8168f9
Integrate feedback from pull request
...
* orders.c: remove ; at eol
* rdpdr_main.c: simplify error case
* rdpsnd_pulse.c: fix incorrect check
* rdpsnd_main.c: adapt return value according to documentation
* update.c: fix incorrect return values
2015-03-30 18:29:32 +02:00
Bernhard Miklautz
8615f74eac
drdynvc: ensure stream != NULL
2015-03-30 17:23:22 +02:00
Bernhard Miklautz
6a997fad53
cliprdr: ensure stream != NULL
2015-03-30 17:17:36 +02:00
Bernhard Miklautz
74c8400789
coding style fixes
...
Add missing space after if
2015-03-30 17:15:45 +02:00
Bernhard Miklautz
f469e069dc
stream: Stream_Ensure*Capacity: change return type
...
Change the return type of Stream_Ensure*Capacity from void to BOOL to be
able to detect realloc problems easily. Otherwise the only way to detect
this was to check if the capacity after the call was >= the required
size.
In case Stream_Ensure*Capacity fails the old memory is still available
and need to freed outside.
This commit also adds checks to most calls of Stream_Ensure*Capacity to
check if the call was successful.
2015-03-30 16:33:48 +02:00
Marc-André Moreau
851626f296
Merge pull request #2492 from bmiklautz/malloc_wrap
...
Fix compiler warnings and code hardening
2015-03-30 09:35:36 -04:00
tagunil
45ea141974
tsmf: free frame data after processing
2015-03-26 13:38:09 +03:00
Bernhard Miklautz
f2b4709cbd
opensl: remove unnecessary memset
2015-03-25 17:38:21 +01:00
Bernhard Miklautz
7f3326d41c
Fix compiler warnings
...
gcc 4.7.2
* warning: value computed is not used [-Wunused-value]
* warning: unused variable ‘oss’ [-Wunused-variable]
2015-03-25 17:38:21 +01:00
Bernhard Miklautz
3c7662517c
hardening
...
Start to add missing checks for:
* *alloc
* *_New
2015-03-25 17:38:21 +01:00
Marc-André Moreau
afdd55fa81
Merge branch 'master' of github.com:FreeRDP/FreeRDP
2015-03-13 15:30:31 -04:00
Marc-André Moreau
cb27703d2e
Merge pull request #2461 from ivan-83/master
...
audin OSS support, dyn channels fix, dev arg broken fix, add debug verbosity, build warning fix
2015-03-13 15:19:35 -04:00
Marc-André Moreau
cb002d91cd
channels/smartcard: fix pioRecvPci with cbExtraBytes > 0
2015-03-13 14:20:57 -04:00
Zhang Zhaolong
c2ddb08437
urbdrc: fix undefined behavior of sprintf.
...
Signed-off-by: Zhang Zhaolong <zhangzl2013@126.com>
2015-03-13 11:15:14 +08:00
ivan-83
3a8022e67c
* audin OSS files
2015-03-13 01:41:44 +03:00
ivan-83
9e7e4ce7ff
Merge branch 'master' of github.com:ivan-83/FreeRDP
2015-03-13 01:39:41 +03:00
ivan-83
7b3a552988
+ audin OSS support (un tested now)
...
+ add: COMMAND_LINE_IGN_UNKNOWN_KEYWORD flag for CommandLineParseArgumentsA to ignory unknown keys without fail
+ add: lot of WLog_DBG() in drdynvc, add function names in existing
* change: error text in rdpsnd OSS
* fix: dev in rdpsnd does not work
* fix/change: audio-dev renamed to dev and now work in audin
* fix dynamic channels now work again
2015-03-13 01:28:44 +03:00
Marc-André Moreau
dfc1238523
Merge pull request #2447 from ivan-83/master
...
Fix poor sound quality with ALSA, add OSS sound system support, FreeBSD patches
2015-03-12 10:09:02 -04:00
Zhang Zhaolong
e675a41705
rail: fix incorrect usage of realloc.
...
Signed-off-by: Zhang Zhaolong <zhangzl2013@126.com>
2015-03-11 11:17:52 +08:00
Zhang Zhaolong
d329831ba1
audin: fix incorrect usage of realloc.
...
Signed-off-by: Zhang Zhaolong <zhangzl2013@126.com>
2015-03-11 11:10:28 +08:00
Zhang Zhaolong
b8de622b90
tsmf: fix incorrect usage of realloc.
...
Signed-off-by: Zhang Zhaolong <zhangzl2013@126.com>
2015-03-11 11:04:36 +08:00
ivan-83
0f3b639058
* OSS build fix on linux
2015-03-11 02:17:45 +03:00
ivan-83
e85dccc22a
* remove OSS debug messages
2015-03-10 01:34:15 +03:00
ivan-83
4f8f84f33b
+ some files for OSS, missed from prev commit
2015-03-09 09:31:27 +03:00
ivan-83
fe9fab920e
+ add OSS support for rdpsnd
2015-03-09 09:23:29 +03:00
ivan-83
8d5825ee00
Fix poor sound quality with ALSA
...
and decrease "ALSA lib pcm.c:7339:(snd_pcm_recover) underrun occurred"
+ little code cleanup
2015-03-09 09:11:46 +03:00
Marc-André Moreau
bc50c81a0a
channels/smartcard: fix SCardTransmit return encoding with pioRecvPci
2015-02-20 15:39:51 -05:00
Armin Novak
69afce34c7
Debug messages now use WLog_DBG instead of WLog_ERR.
2015-02-19 08:45:45 +01:00
Marc-André Moreau
22ac46957a
xfreerdp: fix egfx multimonitor support
2015-02-10 16:32:07 -05:00
Marc-André Moreau
0054b6b134
Merge branch 'master' of github.com:FreeRDP/FreeRDP
2015-02-06 18:02:10 -05:00
Marc-André Moreau
edb8b3055f
Merge pull request #2367 from eledoux/ports
...
fixed: serial redirect not work #2333
2015-02-06 18:02:16 -05:00
Marc-André Moreau
3258c887a4
libfreerdp-core: add channel reconnect
2015-02-06 17:35:14 -05:00
Marc-André Moreau
fa06c4d401
libfreerdp-core: improve reconnection
2015-02-06 14:21:26 -05:00
Emmanuel Ledoux
cf3d857b89
serial: changed the default underlying ServerSerialDriverId from SerialDriverSerCx2Sys to SerialDriverSerialSys
2015-02-06 19:56:36 +01:00
Marc-André Moreau
82d58086db
xfreerdp: partial reconnect fixes
2015-02-05 17:01:56 -05:00
Marc-André Moreau
a4979456e5
Merge branch 'master' of github.com:FreeRDP/FreeRDP into gateway
2015-02-04 11:36:05 -05:00
Petr Sumbera
17df42e4b5
Fixes some build issues on Solaris 11.
2015-02-02 08:48:54 -08:00
Marc-André Moreau
5e53063d55
channels/smartcard: fix SCardTransmit pioRecvPci parsing
2015-01-31 12:27:48 -05:00
Marc-André Moreau
bc857776fb
Merge branch 'master' of github.com:FreeRDP/FreeRDP
2015-01-27 15:55:52 -05:00
Marc-André Moreau
c76847dafc
Merge branch 'master' of github.com:awakecoding/FreeRDP
2015-01-27 14:54:49 -05:00
Norbert Federa
70c8acdd67
drdynvc: fix segfaults and a compiler warning
...
If we send a negative creation status while processing the DVC create
response pdu in drdynvc_process_create_request() we must also close
the created channel. Otherwise we will get duplicated channel IDs
in the channel manager's array list because the server will
eventually reuse the channel ids which we have reported as failed in
previous creation responses.
In order to protect the client from duplicated IDs sent by buggy or
malicious servers I've added an appropriate check in
dvcman_channel_new() which will now return NULL in this case.
Also added a missing NULL check for the result of dvcman_channel_new()
in dvcman_create_channel().
2015-01-26 19:26:38 +01:00
Marc-André Moreau
bcc702346f
channels/smartcard: fix buffer read alignment in SCardTransmit parsing
2015-01-23 14:19:15 -05:00
Marc-André Moreau
0146927605
Merge branch 'master' of github.com:FreeRDP/FreeRDP
2015-01-22 16:07:25 -05:00
Armin Novak
2f57cca71c
Moved arraylist remove to dvcman_close_channel
...
This ensures, that the resources are also cleaned up if no channel
listener was registered.
2015-01-21 14:16:23 +01:00
Armin Novak
256c64fbed
Fixes cleanup when closing a dynamic channel.
...
The resource cleanup was executed twice for each dynamic channel.
Now cleaning up the resources by array list free callback and only
when closing the channel.
2015-01-21 12:58:18 +01:00
Marc-André Moreau
f0fc27f7bd
libwinpr-winscard: add WINPR_WINSCARD_LOCK_TRANSACTIONS environment variable, fix winpr_HexDump line feeds
2015-01-20 15:29:05 -05:00
Marc-André Moreau
ee51da8500
channels/smartcard: cleanup debug output
2015-01-20 11:16:37 -05:00
Marc-André Moreau
b057d1eaf7
Merge branch 'master' of github.com:FreeRDP/FreeRDP
2015-01-20 09:29:21 -05:00
Mike McDonald
b184a7531f
Merge branch 'master' of https://github.com/awakecoding/FreeRDP into awakecoding-staging
2015-01-20 08:09:00 -05:00
Armin Novak
b6d0ce797b
Fixed variable initialisation and cleanup.
2015-01-20 12:31:43 +01:00
Armin Novak
4d08528f89
Fixed variable initialisation and cleanup.
2015-01-20 12:31:39 +01:00
Armin Novak
97988b4868
Fixed variable initialisation and cleanup.
2015-01-20 12:31:37 +01:00
Armin Novak
cadd2675f6
Fixed variable initialisation and cleanup.
2015-01-20 12:31:30 +01:00
Armin Novak
ac81b9ddf5
Fixed variable initialisation and cleanup.
2015-01-20 12:31:26 +01:00
Armin Novak
557e8bb938
Fixed variable initialisation and cleanup.
2015-01-20 12:31:21 +01:00
Armin Novak
6170aba5fb
Fixed variable initialisation and cleanup.
2015-01-20 12:31:16 +01:00
Armin Novak
918ca132f6
Fixed resource cleanup locations.
...
Additional error checks and logging.
2015-01-20 11:59:13 +01:00
Armin Novak
865bcc5d63
Added CHANNEL_EVENT_DISCONNECTED handling.
...
Additional error checks and logging.
2015-01-20 11:58:09 +01:00
Armin Novak
9e5ed07556
Added CHANNEL_EVENT_DISCONNECTED handling.
...
Additional error checks and logging.
2015-01-20 11:58:04 +01:00
Armin Novak
bbacca6db2
Added CHANNEL_EVENT_DISCONNECTED handling.
...
Additional error checks and logging.
2015-01-20 11:55:50 +01:00
Armin Novak
4171589647
Added CHANNEL_EVENT_DISCONNECTED handling.
...
Additional error checks and logging.
2015-01-20 11:55:22 +01:00
Armin Novak
cbf8b1cf01
Fixed resource cleanup locations.
...
Additional error checks and logging.
2015-01-20 11:53:12 +01:00
Armin Novak
56cdb57452
Added CHANNEL_EVENT_DISCONNECTED handling.
...
Additional error checks and logging.
2015-01-20 11:47:47 +01:00
Armin Novak
de01d7a445
Prettiefied WLog messages.
2015-01-20 11:46:25 +01:00
Armin Novak
3dc1f07847
Added CHANNEL_EVENT_DISCONNECTED handling.
...
Additional error checks and logging.
2015-01-20 11:45:36 +01:00
Armin Novak
5ce9c71a40
Prettiefied WLog messages.
2015-01-20 11:39:33 +01:00
Armin Novak
54ec26c758
Removed duplicated close call
2015-01-20 11:39:13 +01:00
Armin Novak
ddd8a1da80
Prettiefied WLog messages.
2015-01-20 11:23:12 +01:00
Armin Novak
54fa77a06a
Prettiefied WLog messages.
2015-01-20 11:20:38 +01:00
Armin Novak
90b46bf987
Prettiefied WLog messages.
2015-01-20 11:20:09 +01:00
Marc-André Moreau
e47f1c8b80
channels/smartcard: minor robustness fixes
2015-01-19 12:04:23 -05:00
Marc-André Moreau
d5b3f9cbd4
Merge branch 'master' of github.com:FreeRDP/FreeRDP
2015-01-08 14:22:05 -05:00
Mike McDonald
7febeb2dec
Added rename file and fixed some minor bugs.
2014-12-30 18:41:21 -05:00
Bernhard Miklautz
b485bb2067
rdpdr: use host name for redirected drives if set
...
When a client set the host name, redirected drives would still be shown
as coming from the computer name. For example if the computer the client
run on is called "foo" and the client set the /host-name to "bar" any
redirected drive is shown as "driveX on foo".
Now the host name is used for drives when set.
2014-12-30 13:34:11 +01:00
Marc-André Moreau
51554ff16c
channels: patch rdpdr/smartcard valgrind leaks, fix hang on disconnect
2014-12-28 14:56:13 -05:00
Marc-André Moreau
5024c42b76
channels/drdynvc: properly handle DYNVC_OPEN/DYNVC_CLOSE requests
2014-12-28 11:13:51 -05:00
Mike McDonald
b21331cf1a
First cut at server side implementation of RDPDR drive redirection.
2014-12-27 21:17:34 -05:00
Marc-André Moreau
b552aa9363
libfreerdp-core: add support for multiple redirection target addresses
2014-12-27 18:53:27 -05:00
Marc-André Moreau
27a8e50e60
channels: fix drdynvc, patch memory leaks
2014-12-27 15:20:29 -05:00
Marc-André Moreau
6c2ebb2b58
channels: redirection valgrind fixes
2014-12-27 13:50:50 -05:00
Marc-André Moreau
9ebc67ba02
channels/smartcard: cleanup SCardControl
2014-12-22 16:25:59 -05:00
Marc-André Moreau
0625be2720
channels/smartcard: fix SCardGetAttrib SCARD_AUTOALLOCATE support
2014-12-22 13:28:16 -05:00
Marc-André Moreau
08c8c6f285
channels/cliprdr: fix empty clipboard format lists, server-side locking
2014-12-20 13:07:30 -05:00
Marc-André Moreau
265e8b9e9d
cliprdr/server: make channel thread optional
2014-12-18 11:11:36 -05:00