Hardening
bdb975afe8
Merge pull request #2510 from akallabeth/build_date
...
Added version and build info functions
2015-03-30 19:14:59 +02:00
Bernhard Miklautz
79de8168f9
Integrate feedback from pull request
...
* orders.c: remove ; at eol
* rdpdr_main.c: simplify error case
* rdpsnd_pulse.c: fix incorrect check
* rdpsnd_main.c: adapt return value according to documentation
* update.c: fix incorrect return values
2015-03-30 18:29:32 +02:00
Armin Novak
8e521e7aee
Fixed return value in test.
2015-03-30 18:18:14 +02:00
Armin Novak
eedf45583a
Using sprintf_s now.
2015-03-30 18:17:07 +02:00
Armin Novak
0adab13719
Now returning const char*
2015-03-30 18:09:02 +02:00
Armin Novak
cf941304b3
Fixed windows _snprintf.
2015-03-30 18:05:46 +02:00
Armin Novak
827b4f76ca
Added test for freerdp version functions.
2015-03-30 17:57:16 +02:00
Armin Novak
8f228163a8
Added version and build info functions
...
Added functions to get
* Version String
* Build Time String
* Git Revision String
and appropriate tests.
2015-03-30 17:51:29 +02:00
Bernhard Miklautz
74c8400789
coding style fixes
...
Add missing space after if
2015-03-30 17:15:45 +02:00
Bernhard Miklautz
f469e069dc
stream: Stream_Ensure*Capacity: change return type
...
Change the return type of Stream_Ensure*Capacity from void to BOOL to be
able to detect realloc problems easily. Otherwise the only way to detect
this was to check if the capacity after the call was >= the required
size.
In case Stream_Ensure*Capacity fails the old memory is still available
and need to freed outside.
This commit also adds checks to most calls of Stream_Ensure*Capacity to
check if the call was successful.
2015-03-30 16:33:48 +02:00
Marc-André Moreau
851626f296
Merge pull request #2492 from bmiklautz/malloc_wrap
...
Fix compiler warnings and code hardening
2015-03-30 09:35:36 -04:00
Marc-André Moreau
ad6dc92e12
Merge pull request #2508 from nfedera/fix-2015-03-30-01
...
crypto: support MSFT iOS clients with faulty SNI
2015-03-30 08:23:59 -04:00
Norbert Federa
1ba681fecc
crypto: support MSFT iOS clients with faulty SNI
...
Microsoft iOS Remote Desktop Clients eventually send NULL-terminated
hostnames in SNI which is not allowed in the OpenSSL implementation.
Since we're not using SNI this commit adds an OpenSSL TLS extension
debug callback which modifies the SSL context in a way preventing it
from parsing this extension
2015-03-30 13:48:51 +02:00
Norbert Federa
abeb79f2bb
nego: fixed X.224 Connection Request PDU parsing
...
The X.224 Connection Request PDU might contain an optional cookie or
routing token before the optional RDP Negotiation Request (rdpNegReq).
If present, both of these fields must be terminated by a 0x0D0A
two-byte sequence. It seems that until now FreeRDP has incorrectly
assumed that a token or cookie must always be present.
If that was not the case, FreeRDP was searching for 0x0D0A until it
arrived at the end of the stream which prevented the remaining data
(RDP Negotiation Request, RDP Correlation Info) from being parsed.
2015-03-30 13:07:03 +02:00
Bernhard Miklautz
aa2181dcf2
Merge pull request #2483 from akallabeth/feat/freerdp_set_last_error_name
...
Feat/freerdp last error name
2015-03-26 16:42:54 +01:00
Bernhard Miklautz
7f3326d41c
Fix compiler warnings
...
gcc 4.7.2
* warning: value computed is not used [-Wunused-value]
* warning: unused variable ‘oss’ [-Wunused-variable]
2015-03-25 17:38:21 +01:00
Bernhard Miklautz
3c7662517c
hardening
...
Start to add missing checks for:
* *alloc
* *_New
2015-03-25 17:38:21 +01:00
Bernhard Miklautz
90579ae16f
gdi/gfx: remove unused variables
2015-03-25 17:38:21 +01:00
Bernhard Miklautz
f75ced240d
gdi: remove unnecessary includes
2015-03-25 17:38:20 +01:00
Bernhard Miklautz
b9cc206a78
gdi: remove dead code
2015-03-25 17:38:20 +01:00
Vic Lee
5f375d0a6f
tls: revert checking SSL_ERROR_SYSCALL which may cause deadlock.
2015-03-25 16:07:39 +08:00
Martin Fleisz
5fa777b11c
Merge pull request #2482 from llyzs/llyzs
...
tls: fix error handling of no error code.
2015-03-23 16:06:12 +01:00
Hardening
20433e6f29
Merge pull request #2443 from realjiangms/fix_region
...
Incorrect extents calculation in region16_intersect_rect (libfreerdp/codec/region.c)
2015-03-20 22:12:48 +01:00
zihao.jiang
a6311d29e7
Add ascii art for norbert_test_case
2015-03-21 01:07:54 +08:00
zihao.jiang
2a91988975
resolve comments from hardening
2015-03-21 00:04:30 +08:00
zihao.jiang
ce06229499
fix tab/space style
2015-03-20 23:40:48 +08:00
zihao.jiang
f94935224c
Fixes extents of region16_intersect_rect.
...
See Issue #2443 .
When there's more than 2 rectangles in the region structure, region16_intersect_rect would calculate extents by all 'intersected' sub rectangles.
But it always extend the extents to (0,0) because it initialize the new extents as (0,0,0,0) and union later rectangles with this empty point by simple MIN/MAX calculation.
Also fixed rectangle_is_empty although it has not been used yet. The function does not work as its name.
Reuse norbert case. That case is enough for the intersect fix, but the expected result is not correct. The test case is also fixed.
Added test case to check empty rectangle.
2015-03-20 20:55:06 +08:00
Vic Lee
2137ccc3db
tls: retry for all SSL_ERROR_SYSCALL errors.
2015-03-20 10:03:30 +08:00
Marc-André Moreau
cb8e61cf99
libfreerdp-core: fix rdg.c header include
2015-03-19 12:13:37 -04:00
Marc-André Moreau
69f4d78785
libfreerdp-core: fix rdg.h header include
2015-03-19 12:08:30 -04:00
Marc-André Moreau
6202f48c12
libfreerdp-core: add configurable TSG/RGB fallback, fix edge cases
2015-03-19 11:44:47 -04:00
Marc-André Moreau
a2ff1e8348
Merge branch 'gateway' of https://github.com/dvincent-devolutions/FreeRDP into gateway
2015-03-19 09:41:50 -04:00
Denis Vincent
08a3d40ef8
libfreerdp-core: minor code corrections
2015-03-19 09:17:56 -04:00
Armin Novak
3a429e5add
Removed unused define.
2015-03-19 14:17:48 +01:00
Armin Novak
48d8058f9b
fixed log message arguments.
2015-03-19 11:11:43 +01:00
Armin Novak
56dc61cc06
Added error name and string functions.
...
Added new functions allowing to get a string representation of an error code
and a description of the error for connect and base error classes.
2015-03-19 11:05:16 +01:00
Denis Vincent
205ccb70c8
libfreerdp-core: added fallback to RPC.
2015-03-18 16:13:32 -04:00
Marc-André Moreau
1380895a2a
libfreerdp-core: fix RDG http receive
2015-03-18 09:48:21 -04:00
Marc-André Moreau
3c4bee3d95
libfreerdp-core: fix RDG valgrind issues
2015-03-17 16:54:45 -04:00
Marc-André Moreau
dc913d9f2c
libfreerdp-core: fix some RDG valgrind issues
2015-03-17 16:09:17 -04:00
Marc-André Moreau
360e2c5e4e
libfreerdp-core: fix rdg event handles
2015-03-17 15:13:11 -04:00
Marc-André Moreau
bdf17450e5
Merge branch 'gateway' of https://github.com/dvincent-devolutions/FreeRDP into gateway
2015-03-17 14:54:04 -04:00
Denis Vincent
144d0d9b23
libfreerdp-core: Initial RDG support.
2015-03-17 14:54:16 -04:00
Marc-André Moreau
0e94ac663d
libfreerdp-codec: add support for 16 color palette image copy
2015-03-16 14:01:43 -04:00
Marc-André Moreau
9562439bd8
libfreerdp-codec: add support for 1bpp image copy
2015-03-16 13:27:27 -04:00
Marc-André Moreau
2094501d8b
freerdp: fix failing tests
2015-03-16 09:26:38 -04:00
Marc-André Moreau
ad02c75af8
libfreerdp-gdi: disable broken BitBlt tests
2015-03-16 08:55:06 -04:00
Marc-André Moreau
c21bff5415
Merge branch 'master' of github.com:FreeRDP/FreeRDP
2015-03-16 08:01:54 -04:00
Jean-Louis Dupond
ede7993fe8
libfreerdp-core: Initialize values correctly
2015-03-15 14:09:16 +01:00
Jean-Louis Dupond
8a0fe0861d
fix size error introduced in commit 99b14815a5
2015-03-15 11:50:10 +01:00