mirrors/FreeRDP
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
14,504 Commits 6 Branches 74 Tags
Commit Graph

4184 Commits

Author SHA1 Message Date
akallabeth
bd0558c47f Fixed missing check for fastpath input messages 
Input events are only allowed after a connection was established
(connection state is active)
This check aborts input sending when done before that.

(cherry picked from commit 102869f6a860140174da9dd3189babf6966c9149)
 2021-02-25 09:51:41 +01:00
Armin Novak
8d62ec233d Fixed const correctness of RECTANGLE_16 variable 
(cherry picked from commit 9549d090ab849c405cb486fad6c9dd3867b28c45)
 2021-02-25 09:51:41 +01:00
Armin Novak
5ea5980b10 Fixed pcap capture function const correctness 
(cherry picked from commit 87e89bc719110ea369ae431e12f4e91f99cc9304)
 2021-02-25 09:51:41 +01:00
Armin Novak
847de7f4ae Fix ColorFidelity use 
(cherry picked from commit 8187ab7732dd0184e1123b1c39790a246f9912a6)
 2021-02-25 09:51:41 +01:00
Armin Novak
605e89a38d Fix color fidelity issues with windows 7 
(cherry picked from commit 57b58df80644f142067a489640edc40f006329a7)
 2021-02-25 09:51:41 +01:00
Armin Novak
a4048b7d11 Fixed problematic cast of integer mask to bool 
(cherry picked from commit 8c353e9292f18e938b21f3369ba86d0f71359815)
 2021-02-25 09:51:41 +01:00
Martin Fleisz
d3202497ba primitives: Respect alpha values in YUV444 SSE pixel routine 
(cherry picked from commit 9eaa820818571d23bd8604fbbc1ff9fa7c634967)
 2021-02-25 09:51:41 +01:00
Martin Fleisz
ce61bc41cb core: Remove error code from string returned by rpc_error_to_string 
This PR removes the error code from the error string returned by
rpc_error_to_string. The error code is passed into the function so it is
not necessary to append it to the returned string as well.

The PR also fixes the screwed formatting of the error code tables.

(cherry picked from commit c78566d2a239648087949dc4ae58e18093f8bf6c)
 2021-02-25 09:51:41 +01:00
Martin Fleisz
76923c7890 Fix parsing of current keyboard locale 
(cherry picked from commit 2e59baa33c23cbd0e0ef6e432d8ef202caa34303)
 2021-02-25 09:51:41 +01:00
Martin Fleisz
270e40e92f
Merge pull request #6623 from akallabeth/stable-2.0-backports 
stable backports
 2021-01-11 10:47:45 +01:00
akallabeth
db20214c1f Backported #6670: Progressive decoding of subbanddiff 
Properly decode tiles without subbanddiff so connections with
xfreerdp /gfx /v:<foo> work with ogon and the required progressive
codec is correct.
 2020-12-15 17:00:22 +01:00
akallabeth
6522361760 Fixed #6656: invalid read of proxy port. 
(cherry picked from commit 3c237fd687c043d4488113d21292f1103bac9769)
 2020-12-10 07:39:41 +01:00
Armin Novak
e4b30a5cb6 Removed obsolete connectErrorCode 
(cherry picked from commit 3b63903d3fbca0c1b1614aa93ea9ede955da692d)
 2020-12-02 14:17:54 +01:00
akallabeth
67d404c783 Fixed remarks. 
(cherry picked from commit c0284239a759f47670c164e0f3ae9b29676e07f3)
 2020-12-02 09:43:22 +01:00
Bernhard Miklautz
c94e9ea14b new [orders]: BMF_24BPP support and some comments 
* cached brush orders missed the BMF_24BPP documented case
  ([MS-RDPEGDI] 2.2.2.2.1.2.7)
* add some comments on secondary (brush) order details

(cherry picked from commit efdc99528f6fb6d56537a5420bfa8e735219eba0)
 2020-12-02 09:43:22 +01:00
akallabeth
f00d7aa644 Fix warning #6515 
(cherry picked from commit 6d8f355633b7381745a55d48301e7f1e17d8efb4)
 2020-12-02 08:57:00 +01:00
kubistika
39f56443f2 reset codecs in gdi_pipeline_init 
(cherry picked from commit 42e63cbf9879048e36cb953fcebc24f3493e9568)
 2020-12-01 15:10:23 +01:00
Fabio Fantoni
99ebaacda6 remove unwanted log level set to debug in rfx 
I saw on debian packages (that have -DWITH_DEBUG_ALL=ON) remotefx logs always to
debug without respect log-level and log-filters settings making diffult
debugging of issue on other parts.
After a search I found this that set loglevel to debug that akallabeth confirmed
is unwanted, this patch remove it.

Closes #6606

(cherry picked from commit f3e5ebe315f81f61688b79aa979c8d4ea89f8e87)
 2020-12-01 15:10:23 +01:00
akallabeth
6c74c84f28 Refactored reading of optional order bytes 
(cherry picked from commit ef8f1fd9f0880bf786a0da3b567a4eb33d2bb230)
 2020-12-01 15:10:23 +01:00
akallabeth
ce788af28a Fixed parsing of FastGlyph order. 
(cherry picked from commit 0456fc307c2c6754f15e37de263f4465ec520975)
 2020-12-01 15:10:23 +01:00
akallabeth
87f1ed1f2d Use settings string setter to overwrite computername 
(cherry picked from commit 4d7cddd7c64c75d824d8a1eb0babcfc71f0df8d4)
 2020-12-01 15:10:23 +01:00
akallabeth
048bd8e656 Fixed #6442: Use cmake to provide source directory for test pem 
(cherry picked from commit 70881d39578177d3229f01011f62021b1b069cb5)
 2020-12-01 15:10:23 +01:00
Armin Novak
b0843b68b3 Refactored rdg_read_http_unicode_string warning fixes 
(cherry picked from commit bfa07e701d25fc936c84ad36d58c6ab1a9a33ec9)
 2020-12-01 15:10:23 +01:00
Armin Novak
507fecf50e Fixed warnings. 
(cherry picked from commit e50a8e09ee3feba4975c488618f5af350d851ad9)
 2020-12-01 15:10:23 +01:00
Armin Novak
6004eefec5 Fixed missing input length check for color pointer. 
(cherry picked from commit 47d02a76ce07cbfc655754a1ccfe79a9b6bc9357)
 2020-12-01 15:10:23 +01:00
Armin Novak
e805752c4e Fixed compilation warnings. 
(cherry picked from commit 57b405ca265966fd3790cb3f30d0b0c073268e7c)
 2020-12-01 15:10:23 +01:00
Armin Novak
ab1f6d8792 Fixed #6418: Warning due to invalid const qualifier 
(cherry picked from commit 226b072af82ab7000d26a2bf76ee585098b27875)
 2020-12-01 15:10:23 +01:00
Armin Novak
d27d31e496 Improve NLA auth token debugging 
(cherry picked from commit 10ed4ec42204aa4f56c5a4d82732ced6359f088c)
 2020-12-01 15:10:23 +01:00
Armin Novak
81180aff65 Improve NLA error code logging. 
(cherry picked from commit 32c9a519dfec5ee7c7bf815298c9650e5a7aabff)
 2020-12-01 15:10:23 +01:00
akallabeth
92488d5a3c Use freerdp_settings_[s|g]et* api to access proxy vaiables. 
Fixes #6414

(cherry picked from commit 44ea09e7ad0123b8486428c1ceaeeb96b5c01d35)
 2020-08-05 11:48:39 +02:00
Martin Fleisz
3522179074 Add GatewayMessageType to public API 
(cherry picked from commit 174f3257c9213e77663020d0b8a41220889848fd)
 2020-08-05 10:59:50 +02:00
Martin Fleisz
18c05a1d5f gateway: Add processing of consent and service messages with HTTP gateway 
(cherry picked from commit 130494e34a26d0b7065a2daddb56dd7b63241647)
 2020-08-05 10:59:50 +02:00
akallabeth
5f3ba52de6 Fix #6399: Call ConvertFromUnicode with length -1. 
The input string has ensured NULL termination, so let the function
determine the correct length.

(cherry picked from commit 36499527e747283019c21dbc84c5eff0a564e1d8)
 2020-07-31 11:30:43 +02:00
Armin Novak
13bd74f79c Set BIO data NULL on cleanup 
Recursive BIO free could double free, if the BIO data is not set
NULL when removed.

(cherry picked from commit 76d10561bbf24b82df43771e93a1692790c3dbbc)
 2020-07-23 10:54:05 +02:00
Norbert Federa
8526965eef core: fix invalid inttype and reference 
The error message in tpdu_read_header() printed the pointer address and
used PRIu16 for an UINT8 type

(cherry picked from commit 54fdf7947d4d35589dab9ec3e37839606ffcc985)

Fixes #6380
 2020-07-20 14:12:34 +02:00
akallabeth
da684f5335 Fixed missing input sanitation for GFX surfaces. 
Thanks to Sunglin and HuanGMz of the Knownsec 404 security team and pangzi of pwnzen

(cherry picked from commit 5592cb2e10da42592af98f5533d2e42181e86821)
 2020-07-15 18:23:57 +02:00
Giovanni Panozzo
138256fbc5 Fix seeking in Cache Brush and other Secondary Drawing Orders 
(cherry picked from commit 9f7e475c1652c2b1e30e0406ec0bc7ea3f2330ff)

Fixes #6374
 2020-07-15 16:45:14 +02:00
Kobi Mizrachi
db2d8b11e9 libfreerdp: core: add ServerHeartbeat callback 
(cherry picked from commit 2096ede5cc8caa209c532438e3a1173f6b47e2c4)
 2020-07-07 09:59:41 +02:00
akallabeth
0c58e0b6dc Added hint for errors due to missing offscreen-cache 
(cherry picked from commit 57e7a99393fd3db79cd2a78e6a447aaf2540c521)
 2020-07-06 11:14:05 +02:00
akallabeth
cb03d8701d Filter GSM codec for microphone redirection 
(cherry picked from commit c5984ff811f40b0382a251e76fc5f3690339f80a)
 2020-07-06 11:13:26 +02:00
Pascal Nowack
b898786263 nsc: Fix memory leak 
Fixes the following memory leak:

==115716== 16,662,960 bytes in 459 blocks are definitely lost in loss record 3,504 of 3,504
==115716==    at 0x48396AF: malloc (vg_replace_malloc.c:306)
==115716==    by 0x4C6A4E2: nsc_context_initialize_encode (nsc_encode.c:77)
==115716==    by 0x4C6A4E2: nsc_compose_message (nsc_encode.c:497)

(cherry picked from commit 9bd457405095c94a24175bc54bd99947fcf6a33d)
 2020-06-29 08:13:05 +02:00
Armin Novak
62530e2d9d Fixed #6298: Mask CACHED_BRUSH when checking brush style 
(cherry picked from commit ce1a9d8d1969ecbb4d24b9f4812654638a44abc2)
 2020-06-26 11:01:45 +02:00
akallabeth
cb2adc84c0 Fixed possible integer overflow in crypto_rsa_common 
Thanks @anticomputer for pointing this out

(cherry picked from commit 02c5ec66e5b47fe4cf2fc96e2cd387a18e3f2bb6)
 2020-06-22 12:14:04 +02:00
akallabeth
724ceade0f Reset freed HGDI_DC 
CVE-2020-4031 thanks to @antonio-morales for finding this.

(cherry picked from commit f753c25ad3d5dae7890fe73cfb3c091c015d97ed)
 2020-06-22 12:13:20 +02:00
akallabeth
6780420343 Fixed out of bound read in RLEDECOMPRESS 
CVE-2020-4033 thanks to @antonio-morales for finding this.

(cherry picked from commit 0a98c450c58ec150e44781c89aa6f8e7e0f571f5)
 2020-06-22 12:13:13 +02:00
akallabeth
12800786a8 Fixed OOB read in update_recv_secondary_order 
CVE-2020-4032 thanks to @antonio-morales for finding this.

(cherry picked from commit e7bffa64ef5ed70bac94f823e2b95262642f5296)
 2020-06-22 12:13:05 +02:00
akallabeth
746d10179c Fixed OOB read in update_read_cache_bitmap_v3_order 
CVE-2020-11096 thanks @antonio-morales for finding this.

(cherry picked from commit b8beb55913471952f92770c90c372139d78c16c0)
 2020-06-22 12:12:50 +02:00
akallabeth
c687b8c267 Fixed invalid access in update_recv_primary_order 
CVE-2020-11095 thanks @antonio-morales for finding this.

(cherry picked from commit 733ee3208306b1ea32697b356c0215180fc3f049)
 2020-06-22 12:12:41 +02:00
akallabeth
69eef641d0 Fixed pcap cleanup 
(cherry picked from commit 3ac7bb5d6a743b19e8686410d5ec6dcf74869ebe)
 2020-06-22 12:12:14 +02:00
akallabeth
d1da09f7e1 Fixed Out-of-bound read in glyph_cache_put 
CVE-2020-11098 thanks to @antonio-morales for finding this.

(cherry picked from commit c0fd449ec0870b050d350d6d844b1ea6dad4bc7d)
 2020-06-22 12:11:41 +02:00