Hardening
4cc037d148
Some fixes after Norbert code review
...
There were a bug when the rectangles extents where not at the origin.
Some debugging statement have laso been removed.
2014-02-05 14:07:22 +01:00
Hardening
2d16d929b6
Fix remoteFx encoder with topleft and bottomright rectangle
...
This patch fixes the case where with a topleft and a bottomright
rectangle, the encoder would send the full screen instead of only the
intersected tiles.
2014-02-04 16:22:34 +01:00
Hardening
d1e75efb8c
Add a region component
...
This patch adds a pixman_region like component in the utility components
of FreeRdp.
The data structure is exactly the same as in pixman_region but the implementation
differs as we need fewer methods.
The patch contains the corresponding unitary tests.
2014-02-04 11:12:00 +01:00
Marc-André Moreau
9bdfbcd556
wfreerdp: fix test build issues
2014-02-01 12:50:28 -05:00
Marc-André Moreau
d4486b3205
Merge branch 'awakecoding' of github.com:vworkspace/FreeRDP
2014-01-31 17:20:47 -05:00
vworkspace
aca384992f
Increased size of stream on GCC conference create request from 512 to 1024. For large numbers of static virtual channels, the stream was being overflowed and was causing crashes.
2014-01-31 13:52:37 -05:00
Marc-André Moreau
dd789ba9ba
Merge branch 'awakecoding' of github.com:vworkspace/FreeRDP
2014-01-31 10:48:31 -05:00
Mike McDonald
02c9d07bcf
Fixes to process new command line options (autodetect, heartbeat, multitransport), join the MCS message channel and process auto-detect PDUs during the connection sequence.
2014-01-29 22:53:32 -05:00
Marc-André Moreau
97dd904a36
libfreerdp-gdi: fix invalidation of region with line drawing
2014-01-28 21:46:47 -05:00
Marc-André Moreau
6bd4362e6d
Merge branch 'auto-detect' of github.com:vworkspace/FreeRDP
...
Conflicts:
include/freerdp/settings.h
libfreerdp/core/gcc.c
libfreerdp/core/gcc.h
libfreerdp/core/mcs.h
libfreerdp/core/rdp.c
2014-01-25 17:08:43 -05:00
Marc-André Moreau
3782c2ad72
Merge branch 'master' of github.com:FreeRDP/FreeRDP
2014-01-25 16:34:34 -05:00
Marc-André Moreau
95634f3e4c
libfreerdp-core: improve encoding and decoding of GCC core data block
2014-01-24 13:03:37 -05:00
Mike McDonald
63f6947872
Added heartbeat to rdpRdp struct and added calls to heartbeat constructor and destructor
2014-01-24 08:38:28 -05:00
Mike McDonald
ac8fe6ad61
Added heartbeat code
2014-01-23 22:23:47 -05:00
Mike McDonald
07083acc97
First cut at network characteristics auto-detect and multitransport protocol
2014-01-23 18:01:31 -05:00
Marc-André Moreau
1c0e874b5b
libfreerdp-core: more GCC and MCS fixes
2014-01-23 17:41:05 -05:00
Marc-André Moreau
38b125f336
libfreerdp-core: fix and update parsing of server-side GCC client data blocks
2014-01-23 16:00:02 -05:00
Marc-André Moreau
ae9c10e233
Merge pull request #1664 from vworkspace/auto-reconnect
...
Addition of auto reconnect to FreeRDP core and X11 client
2014-01-23 10:15:18 -08:00
Mike McDonald
a563362ea2
Changed #define for SOL_TCP to be IPPROTO_TCP instead of 6
2014-01-21 11:06:29 -05:00
Mike McDonald
c0d26443ce
Added #define for SOL_TCP to fix compilation error on iOS
2014-01-21 08:27:21 -05:00
Mike McDonald
25f834043e
Modified FreeRDP core to ignore SIGPIPE signal. This signal was being generated during a call to SSL_shutdown when the socket is in a disconnected state. The proper way to handle this is to ignore SIGPIPE and allow the write system call to report an errno of EPIPE.
2014-01-20 11:20:50 -05:00
Mike McDonald
5ce6b787ec
Revert "Fixed tls_read and tls_write to prevent a subsequent crash in SSL_shutdown when read/write errors occur."
...
This reverts commit 2a49238351
.
2014-01-20 11:09:45 -05:00
Mike McDonald
4e31b9bbb9
Revert "Modified TLS code to handle disconnects a little cleaner."
...
This reverts commit c273a4ac5e
.
2014-01-20 11:08:33 -05:00
Mike McDonald
3ddf681feb
Revert "Fixed comment in tls_disconnect."
...
This reverts commit 7f040406ac
.
2014-01-20 11:06:08 -05:00
Mike McDonald
7f040406ac
Fixed comment in tls_disconnect.
2014-01-17 11:54:35 -05:00
Mike McDonald
c273a4ac5e
Modified TLS code to handle disconnects a little cleaner.
2014-01-17 11:51:39 -05:00
Mike McDonald
2a49238351
Fixed tls_read and tls_write to prevent a subsequent crash in SSL_shutdown when read/write errors occur.
2014-01-17 10:24:13 -05:00
Mike McDonald
c4f6dcc24f
Added auto reconnect to FreeRDP core and X11 client
2014-01-16 17:38:56 -05:00
Daryl Poe
9897f72b97
add additional evdev key mappings for multimedia and Korean keyboards
2014-01-14 15:18:20 -07:00
Hardening
c1a6eda740
Improve performance for delta_encoder
...
This patch inline the case of the first line to drop the if() that was done
at each loop.
Some variable have been renamed for code clarity.
2014-01-14 09:44:38 +01:00
Marc-André Moreau
6dfaa8eefa
libfreerdp-codec: got planar encoder to work 100% correctly
2014-01-13 22:16:10 -05:00
Marc-André Moreau
7c6be746a6
libfreerdp-codec: minor planar codec fix (undocumented behaviour for RLE)
2014-01-12 16:28:06 -05:00
Marc-André Moreau
47f3b879db
libfreerdp-core: implement parsing of less frequent core rdp messages
2014-01-11 22:54:08 -05:00
Marc-André Moreau
843953048c
Merge branch 'master' of github.com:FreeRDP/FreeRDP
2014-01-08 11:16:35 -05:00
Hardening
f1d6afca6a
Fix CVE-2014-0791
...
This patch fixes CVE-2014-0791, the remaining length in the stream is checked
before doing some malloc().
2014-01-08 16:57:56 +01:00
Marc-André Moreau
eb8f34ffef
libfreerdp-codec: reduce size of GDI bitmap encoder
2013-12-20 16:02:20 -05:00
Marc-André Moreau
4c6218e594
libfreerdp-codec: make planar encoder pass compression/decompression tests
2013-12-20 02:41:25 -05:00
Marc-André Moreau
74a3232707
libfreerdp-codec: add new planar codec test data
2013-12-19 19:56:58 -05:00
Marc-André Moreau
05947dd0b2
libfreerdp-core: fix linux build
2013-12-18 22:02:59 -05:00
Marc-André Moreau
5e4f77b05f
Merge branch 'master' of github.com:mrthebunny/FreeRDP
2013-12-18 21:52:41 -05:00
Marc-André Moreau
51ad85e0ee
libfreerdp-core: send Access Denied TLS alert when server-side NLA fails
2013-12-18 19:44:18 -05:00
Benoît LeBlanc
9245d364cc
Fixed handling gateway authentication error
...
Handle NULL pdu
2013-12-18 12:59:53 -05:00
Benoît LeBlanc
5de7a4f082
Code cleanup
2013-12-18 12:44:40 -05:00
Hardening
33f0eb0915
More security fixes for capabilities
...
This patch fixes a security issue which would allow an attackant to set bytes to 1 at choosen places.
It also fixes a warning when DEBUG_CAPABILITIES is set.
2013-12-18 10:54:02 +01:00
Benoît LeBlanc
3adff0ec60
- added CANCELEDBYUSER error code.
...
- AUTHENTICATIONERROR error code correclty set on gateway authentication (http error 401)
- Better error handling on connection errors and user cancelation
2013-12-13 10:11:36 -05:00
Hardening
8767931431
Harden capability parsing
...
Don't check only the number of capabilities but also the remaining size in the stream
2013-12-13 15:08:43 +01:00
Benoît LeBlanc
469303a545
Fix: PromptCredentialsOnce / GatewayUseCredentials were always set to true regardless of the value present in the rdp file.
2013-12-12 11:32:36 -05:00
Marc-André Moreau
9d745cc038
Merge branch 'master' of github.com:mrthebunny/FreeRDP
2013-12-11 12:22:33 -05:00
Benoît LeBlanc
72f58b220d
Remove deprecated ParamChanged event
2013-12-10 17:37:08 -05:00
Marc-André Moreau
5f96f50e0d
libfreerdp-gdi: port old cunit gdi tests to ctest
2013-12-10 16:35:46 -05:00
Marc-André Moreau
62199fc46a
Merge branch 'master' of github.com:FreeRDP/FreeRDP
2013-12-10 11:54:03 -05:00
Marc-André Moreau
26f543cdf4
libfreerdp-codec: planar cleanup
2013-12-09 12:02:05 -05:00
Benoît LeBlanc
cb46bbade0
Merge branch 'master' of git://github.com/awakecoding/FreeRDP
2013-12-09 09:37:38 -05:00
Marc-André Moreau
718a0d0bbc
libfreerdp-codec: avoid pixel overflow with planar codec RLE test cases
2013-12-08 23:17:24 -05:00
Marc-André Moreau
1add4e628f
libfreerdp-codec: make planar codec encoder context reusable
2013-12-08 17:06:59 -05:00
Marc-André Moreau
6dfdc286ec
libfreerdp-core: disconnect client when accept fails
2013-12-08 14:43:11 -05:00
Hardening
98245b8177
Fixed typo in the initialization
2013-12-08 11:22:36 +01:00
Benoît LeBlanc
8c1f836ac8
- SSL verification callback: send correct hostname and port
...
- Gateway Authentication callback.
- Handling “use same credentials”
2013-12-06 22:15:45 -05:00
Hardening
d7b7fcc688
Parse the Surface frame marker flag
...
This patch adds the parsing for the surface framemarker flag, so that
we can test it later.
2013-12-06 23:25:31 +01:00
Marc-André Moreau
85b7ad90fe
libfreerdp-core: fix possible crash on unauthorized TS Gateway error
2013-12-05 17:31:33 -05:00
Marc-André Moreau
4d6f3b6de4
libfreerdp-client: fix bug in pInterface channel registration
2013-12-05 16:55:28 -05:00
Bernhard Miklautz
6763e059c3
tls: handle the case if endpoint has disconnected
2013-12-04 15:36:25 +01:00
Bernhard Miklautz
2b6b4a6685
updated file headers
2013-12-04 11:44:22 +01:00
Marc-André Moreau
2114fbb8f9
libfreerdp-codec: add new planar codec test case
2013-12-03 20:14:07 -05:00
Marc-André Moreau
f24610c7c0
Merge branch 'master' of github.com:awakecoding/FreeRDP
2013-12-03 18:50:40 -05:00
Marc-André Moreau
9096bd3b61
libfreerdp-codec: make planar codec bitmap 01 pass the test
2013-12-03 18:50:22 -05:00
Marc-André Moreau
c3723c66a8
Merge pull request #18 from hardening/gcc_fixes
...
More security in gcc.c
2013-11-29 09:59:55 -08:00
Marc-André Moreau
9d1c4c10a6
libfreerdp-codec: make planar decoder more robust
2013-11-29 04:12:59 -05:00
Marc-André Moreau
82b12621af
libfreerdp-codec: refactor planar decompression
2013-11-29 03:06:39 -05:00
Marc-André Moreau
d9e1c0abaa
libfreerdp-codec: add more planar unit tests
2013-11-29 02:16:16 -05:00
Marc-André Moreau
338d809e3a
libfreerdp-codec: extend planar codec unit tests
2013-11-28 19:51:29 -05:00
Hardening
1d6a07d2d5
More security in gcc.c
...
As strange as it looks, i have found more errors that could lead to
security issues in gcc.c.
2013-11-28 23:17:21 +01:00
Marc-André Moreau
cca020a711
libfreerdp-codec: reorganize planar RLE encoding logic
2013-11-28 15:49:22 -05:00
Marc-André Moreau
fcafbfe626
libfreerdp-codec: improve planar RLE compression
2013-11-27 18:21:05 -05:00
Marc-André Moreau
a5c1d0bbaa
libfreerdp-codec: detect planar overflow per set of planes, not individual planes
2013-11-27 16:23:20 -05:00
Marc-André Moreau
7d3ce08e96
libfreerdp-codec: simply planar RLE code
2013-11-27 14:46:38 -05:00
Marc-André Moreau
5bcdab95ff
libfreerdp-codec: partial planar RLE compression support
2013-11-26 22:16:31 -05:00
Marc-André Moreau
919b6c666a
libfreerdp-codec: compress and output RDP6 RLE planes
2013-11-26 18:04:29 -05:00
Marc-André Moreau
c64e10444b
libfreerdp-codec: get all steps of planar scanline delta encoding tested
2013-11-26 16:30:43 -05:00
Marc-André Moreau
52a1b328f2
libfreerdp-codec: start implementing delta-encoding of planar scanlines
2013-11-26 16:07:55 -05:00
Marc-André Moreau
021ef0533e
libfreerdp-codec: implement planar codec RLE scanline encoding
2013-11-26 15:16:40 -05:00
Marc-André Moreau
f429b909a9
libfreerdp-core: fix transport_free in cases where transport thread was not started
2013-11-26 11:30:44 -05:00
Marc-André Moreau
6d2608cbcb
Merge branch 'master' of github.com:mrthebunny/FreeRDP
2013-11-26 11:10:44 -05:00
Marc-André Moreau
c8c75fd4e0
libfreerdp-codec: implement working uncompressed RDP6 bitmap planar codec
2013-11-25 23:29:20 -05:00
Marc-André Moreau
d30656d441
libfreerdp-codec: start implementing uncompressed RDP6 planar codec
2013-11-25 22:26:08 -05:00
Marc-André Moreau
7446c6f02b
libfreerdp-codec: start unit tests for RDP6 planar compressor
2013-11-25 18:58:01 -05:00
Benoît LeBlanc
6a60f79e07
Merge branch 'master' of git://github.com/awakecoding/FreeRDP
...
# By Bernhard Miklautz (10) and others
# Via Marc-André Moreau (10) and Martin Fleisz (1)
* 'master' of git://github.com/awakecoding/FreeRDP: (32 commits)
libfreerdp-crypto: add robustness checks for VerifyX509Certificate
mfreerdp: fix possible crash on gdi termination
channels/cliprdr: add callback for data request response
channels/cliprdr: fix conflict with CLIPRDR_HEADER
fix a gdi leak bug.
channels/cliprdr: implement more of the callback interface
channels/cliprdr: start implementing clean callback interface
channels/rdpsnd: initial attempt at adding GSM610 support
winpr-thread: fixed bugs in _CreateProcessExA
ffmpeg-2 -- CodecID
ffmpeg-2 -- dsp_mask
ffmpeg-2 -- AVCODEC_MAX_AUDIO_FRAME_SIZE
check return value.
reformat coding styles.
fix name length to copy.
fix memory realloc size error.
libfreerdp-crypto: don't report SSL_ERROR_SYSCALL with errno value 0 as error
channels/rdpsnd: add wlog debug output
android toolchain: support for ndk r9b
android toolchain: fixed cmake syntax warning
...
2013-11-25 14:40:01 -05:00
Benoît LeBlanc
56c517170f
Added hostname and port to callback function for SSL certification verification.
2013-11-25 14:30:43 -05:00
Marc-André Moreau
4987f2b0e1
libfreerdp-crypto: add robustness checks for VerifyX509Certificate
2013-11-25 12:08:58 -05:00
Marc-André Moreau
128fb72ec6
mfreerdp: fix possible crash on gdi termination
2013-11-25 00:25:16 -05:00
Marc-André Moreau
83ad1730b8
Merge branch 'master' of github.com:FreeRDP/FreeRDP
...
Conflicts:
libfreerdp/core/input.c
libfreerdp/core/update.c
2013-11-23 16:39:29 -05:00
Marc-André Moreau
cf0dace9d9
Merge branch 'master' of github.com:mrthebunny/FreeRDP
2013-11-23 16:31:23 -05:00
Benoît LeBlanc
d734bde420
Fix leak: free gdi object (if it wasn’t freed before)
2013-11-22 13:37:28 -05:00
Marc-André Moreau
76c842285d
channels/rdpsnd: initial attempt at adding GSM610 support
2013-11-22 12:11:39 -05:00
Marc-André Moreau
690a6b624d
libfreerdp-crypto: don't report SSL_ERROR_SYSCALL with errno value 0 as error
2013-11-20 15:21:29 -05:00
Bernhard Miklautz
261651b43b
core: don't use c99 style initialization
...
fixes #1602
2013-11-18 20:29:00 +01:00
Marc-André Moreau
b0369cf284
libfreerdp-core: add external certificate management, pass X509 PEM certificate through client callback
2013-11-18 13:54:33 -05:00
Marc-André Moreau
5fc0f72c90
Merge branch 'master' of github.com:mrthebunny/FreeRDP
2013-11-15 09:36:39 -05:00
Benoît LeBlanc
c4de5a4e4b
Fixed compilation on windows (code was not standard C)
2013-11-15 08:21:36 -05:00
Marc-André Moreau
498227eb1b
libfreerdp-core: map more Disconnect Provider Ultimatum PDU reason codes to error info pdu
2013-11-14 23:41:46 -05:00