akallabeth
b03f9cc8b8
[core,mcs] added return checks
...
Fix missing checks in mcs_send_disconnect_provider_ultimatum
2023-01-27 11:05:12 +01:00
akallabeth
22f3bf6f78
[core,nla] initialize stack variables
2023-01-27 10:07:01 +01:00
akallabeth
f5d759c979
[core,nla] unify SecBuffer to ASN1 string
...
use a helper function to convert the buffer to a ASN1 string
2023-01-27 10:07:01 +01:00
akallabeth
c604801a67
[core,nla] simplify server side authentication
...
* Single point fo function return
* Clear all buffers after authentication
2023-01-27 10:07:01 +01:00
akallabeth
ca3cd8b7ec
[core,nla] fix a memory leak in server nla
...
Clear destination SecBuffer before calling credssp_auth_decrypt or
credssp_auth_encrypt
2023-01-27 10:07:01 +01:00
akallabeth
aeef6045b7
[core,credssp] initialize stack variables
2023-01-27 10:07:01 +01:00
akallabeth
f355c9addd
[core,capability] Fix reallocation of ReceivedCapabilityData
...
if the size is 0 do not abort but continue.
2023-01-27 10:07:01 +01:00
akallabeth
7afab06e4e
[fastpath] fix write PDU header functions
...
* Proper capacity checks with logging
* Fix return codes
* Remove unused fields from public structs
2023-01-27 10:07:01 +01:00
akallabeth
04ede67940
[core,fastpath] unify fastpath stream decryption
2023-01-27 10:07:01 +01:00
Armin Novak
ee6de6d293
[core] fix rdp encrypted autodetect messages
2023-01-27 10:07:01 +01:00
Armin Novak
bea41877ba
[core] add logging
...
* Log rdp_write_security_header flags
* Log rpd_read_security_header flags
2023-01-27 10:07:01 +01:00
akallabeth
f9f32a335e
[codec,progressive] fixed parsing of blocks
...
only provide a substream to the block parsing functions
2023-01-27 09:36:02 +01:00
akallabeth
ee07a13130
[cleanup] fix compiler warnings
2023-01-26 09:30:17 +01:00
Armin Novak
70f6c09ff4
[core] fix persistent bitmap cache setting
...
* Only activate if both, client and server support the capability
* Use settings getter to access setting
2023-01-26 09:30:17 +01:00
Armin Novak
1dc2225bd2
[winpr,wlog] include function name in log message
...
default to print the function the log message was called from
2023-01-25 16:26:39 +01:00
Armin Novak
641022b795
[logging] remove __FUNCTION__ from actual message
...
prefer the log formatter to provide that information.
2023-01-25 16:26:39 +01:00
Armin Novak
f4ee5226b0
[core,settings] fix freerdp_settings_set_string_from_utf16N
...
If the input string has a length, but the string length is 0 do not
return failure.
2023-01-25 16:26:39 +01:00
akallabeth
075506f6c8
[winpr,stream] use new Stream_CheckAndLogRequiredLength*
2023-01-25 14:27:32 +01:00
akallabeth
74530a7931
[format strings] ensure __LINE__ is of type size_t
...
__LINE__ is not particularily well defined (most fall back to int).
We want to ensure that all the uses in a format string match the format
specifier, so do an explicit cast
2023-01-25 14:27:32 +01:00
akallabeth
686c26794b
[gateway,rdg] improve websocket error log message
2023-01-25 14:27:32 +01:00
akallabeth
8ed37e68d2
[stream] use logging capacity checks
2023-01-25 14:27:32 +01:00
Armin Novak
d639702bed
[core] check return of rdp_write_header
2023-01-25 09:37:40 +01:00
Armin Novak
a111a19c58
[core] check return of rdp_write_security_header
2023-01-25 09:37:40 +01:00
Armin Novak
2fc24420d1
[core] fix server side skip channel join
...
move to state CONNECTION_STATE_RDP_SECURITY_COMMENCEMENT instead of
CONNECTION_STATE_SECURE_SETTINGS_EXCHANGE
2023-01-25 09:37:40 +01:00
akallabeth
d65b73ae9f
[core,license] fixed string conversion
2023-01-25 09:37:40 +01:00
akallabeth
e56cf03a79
[core,server] fixed peer multimonitor handling
...
if there is no RNS_UD_CS_SUPPORT_MONITOR_LAYOUT_PDU announced and we did
not handle the data received rerun in active state.
2023-01-25 09:37:40 +01:00
akallabeth
65a5a7a065
[core,certificate] initialize stack variables
2023-01-24 10:16:55 +01:00
akallabeth
b69c00c448
[core,certificate] const correct write function
2023-01-24 10:16:55 +01:00
akallabeth
033ffff428
[core] initialize stack variables, improve logging
2023-01-24 10:16:55 +01:00
akallabeth
f2b934866a
[core,connection] code cleanups
2023-01-24 10:16:55 +01:00
Armin Novak
9ab5bde349
[core,nego] use settings getter/setter
2023-01-24 10:16:55 +01:00
Armin Novak
e07fed8822
[core,settings] initialize variables
2023-01-24 10:16:55 +01:00
Armin Novak
e0a14edfbb
[core,crypto] log more parsing failures
2023-01-24 10:16:55 +01:00
Armin Novak
d4d2b4403c
[core] Improve redirection logging
2023-01-23 11:37:44 +01:00
Armin Novak
e66f2f8c75
[core] improve redirection logging
2023-01-23 11:37:44 +01:00
Armin Novak
2008024386
[utils] improve rdp_cluster_info_flags_to_string
2023-01-23 11:37:44 +01:00
Armin Novak
d8a6166e67
[core] improve rdp_security_flag_string
2023-01-23 11:37:44 +01:00
Armin Novak
073aefd766
[core] set TS_UD_CS_CLUSTER::Flags to REDIRECTION_VERSION5
...
REDIRECTION_VERSION6 breaks redirection for currently unknown reasons.
Revert to the last known good version until we receive an update on
documentation for the redirection handling
2023-01-23 09:17:01 +01:00
Armin Novak
5be9cf90df
[core] fix ClusterInfoFlags generation, added logging
2023-01-23 09:17:01 +01:00
Armin Novak
c01979fba1
[utils] added rdp_cluster_info_flags_to_string
2023-01-23 09:17:01 +01:00
akallabeth
23281121bf
[core] implement skip channel join
2023-01-20 11:19:18 +01:00
akallabeth
60424ef76f
[core] fixed client/server early capapbility flags
2023-01-20 10:57:30 +01:00
akallabeth
2fc5eaeb80
[core] implemented CS_CORE::EarlyCapabilityFlags filter
...
* Added missing definitions for RNS_UD_CS_SUPPORT_SKIP_CHANNELJOIN
and RNS_UD_SC_SKIP_CHANNELJOIN_SUPPORTED flags
* Updated stringification functions for these flags
* Implemented client and server EarlyCapabilityFlags filter for
these flags as FreeRDP currently does not implement them.
2023-01-20 10:57:30 +01:00
Martin Fleisz
22da7c532c
common: Fix RAIL support flags logging
2023-01-20 10:37:56 +01:00
Martin Fleisz
9c6a0eeeb1
core: Fix handling of RAIL HandshakeEx flag
...
When using Enhanced RAIL the HandshakeEx flag must also be set. However
in the current code it was always overwritten by the server flags (which
might lack the flag).
2023-01-20 10:37:56 +01:00
Armin Novak
2088fb045b
[core,redirection] fix string read, cleanup logs
2023-01-18 09:55:06 +01:00
Armin Novak
7a4f5858ea
[settings] announce REDIRECTION_VERSION6
2023-01-18 09:55:06 +01:00
Armin Novak
fd4ddcb640
[core] const correct certificate_clone
2023-01-18 09:55:06 +01:00
Armin Novak
78b8df86bc
[core] unify settings copy set/reset
2023-01-18 09:55:06 +01:00
Armin Novak
9e331a6fcb
[settings] add string functions for encryption
2023-01-18 09:55:06 +01:00