Commit Graph

109 Commits

Author SHA1 Message Date
akallabeth
537a877627 Replace fopen and path functions with wrappers (#7043)
Functions like fopen, PathFileExists, PathMakePath need to call
the wide character versions on windows for utf-8 support.

(cherry picked from commit 6b36c6d417)
2021-07-27 11:57:33 +02:00
akallabeth
9ce4bc351f Parse on a copy of the argument string for printer
If done on original the wrong backend is loaded on autoreconnect

(cherry picked from commit af1c6ebcb4)
2021-03-04 16:56:42 +01:00
akallabeth
ac9f5e8f5d Use localtime_s on windows
(cherry picked from commit c3a1ed780c)
2020-06-22 12:12:35 +02:00
akallabeth
8c3f6d2b19 Replaced localtime with localtime_r
(cherry picked from commit 240fdd07b1)
2020-06-22 12:11:54 +02:00
akallabeth
79cea7b5b6 Fixed #6157: Reset cups instance on disconnect.
(cherry picked from commit 13906f3ec6)
2020-05-18 16:40:23 +02:00
akallabeth
4c07a00403 Fixed int overflow in printer_write_setting
Thanks to hac425
2020-05-08 11:06:02 +02:00
akallabeth
a1a6790f99 Fixed oob read in irp_write and similar 2020-05-05 07:46:10 +02:00
Armin Novak
adb7aeb796 Fixed cups httpConnectEncrypt deprecation warning. 2020-04-28 14:03:19 +02:00
Armin Novak
436b68e416 Fixed #5895: cast warnings. 2020-02-19 10:21:43 +01:00
Armin Novak
fd968cdf84 Fixed dead store warning. 2019-11-25 10:32:55 +01:00
Armin Novak
72ca88f49c Reformatted to new style 2019-11-07 10:53:54 +01:00
Armin Novak
f01e042211 Code cleanups (strlen, casts, size_t, ...) 2019-10-29 11:58:43 +01:00
Martin Fleisz
9a33a82fb7
Merge pull request #5634 from akallabeth/error_code_update
Added missing error codes.
2019-10-03 08:45:44 +02:00
Armin Novak
0ffcba9350 Fix #5635: Silence double WITH_CUPS definition. 2019-10-02 16:24:12 +02:00
Armin Novak
134da33eb0 Fixed format string. 2019-10-02 16:01:36 +02:00
akallabeth
d5d3ebee60 Fix #5606: Fall back to loading default printer backend. 2019-09-22 16:22:41 +02:00
Armin Novak
88c654ee1d Modified printer backend to allow dynamic backends. 2019-09-06 09:28:29 +02:00
Armin Novak
37ed4bffd0 Fixed conversion warnings.
Range checks and type casts to remove all warnings in printer channel.
2019-02-21 11:43:59 +01:00
Armin Novak
2e5fd8d16b Fixed clang analyzer false positive memory leaks.
Added a justification for each #ifndef __clang_analyzer__
2019-01-29 17:17:30 +01:00
Armin Novak
0dae6933ce Fixed uninitialized return value. 2019-01-29 16:53:30 +01:00
Armin Novak
dd9814df84 Fixed review remarks. 2019-01-29 14:21:58 +01:00
Armin Novak
34c9404c98 Added OpenSSL include path globally. 2018-12-12 15:41:29 +01:00
Armin Novak
31d5a3b0c3 Don't reset configuration and driver name when supplied via command line. 2018-12-12 14:42:50 +01:00
Armin Novak
d13bd66f5a Implemented printer name based backend to remember settings. 2018-12-12 14:36:18 +01:00
Armin Novak
192680a001 Added callback to handle printer custom components in printer backend. 2018-12-12 10:57:53 +01:00
Armin Novak
a744378110 Fixed a warning in printer channel. 2018-09-18 14:45:25 +02:00
Armin Novak
2517755d25 Fixed thread function return and parameters. 2018-03-07 14:36:55 +01:00
Armin Novak
8b9e3fa51e Fixed use of reserved keywords for include guards. 2017-07-20 09:35:41 +02:00
Armin Novak
0490aeb018 Fixed clang malloc integer overflow warnings. 2017-07-20 09:29:48 +02:00
David PHAM-VAN
fd52a9ff52 Bugfix: wrong test regarding the first GetPrinter. This first call will always return FALSE because the goal of this call is to know the size needed. 2017-04-25 11:50:28 -07:00
David PHAM-VAN
c60d663d1a Remove unused variable and check return codes 2017-03-27 10:55:55 -07:00
David PHAM-VAN
1296756be8 Bugfix: Wrong encoding method used for printer name. 2017-03-13 14:56:12 -07:00
Armin Novak
1ef55e7665 Fixed #3778: Printer driver name conversion. 2017-02-17 11:40:52 +01:00
Ilya Shipitsin
102913e808 make cppcheck a bit happier:
[channels/printer/client/printer_cups.c:103]: (error) Resource leak: fp
[server/Mac/mf_event.c:195]: (error) Memory leak: event_queue
[server/shadow/shadow_capture.c:233]: (error) Memory leak: capture
[winpr/libwinpr/sspi/test/TestSchannel.c:440]: (error) Memory leak: lpTokenIn
[winpr/libwinpr/thread/argv.c:198]: (error) Memory leak: lpEscapedChars
[winpr/libwinpr/utils/sam.c:312]: (error) Memory leak: entry
2017-01-25 17:09:25 +05:00
Norbert Federa
f71b6b46e8 fix string format specifiers
- fixed invalid, missing or additional arguments
- removed all type casts from arguments
- added missing (void*) typecasts for %p arguments
- use inttypes defines where appropriate
2016-12-16 13:48:43 +01:00
Norbert Federa
c6e6b44143 countless WLog/printf format specifier fixes 2016-11-25 17:06:25 +01:00
Marc-André Moreau
dee76617d9 channels: remove thread-local storage usage 2016-11-15 11:41:01 -05:00
Armin Novak
943e295714 WLog using C99 compatible variadic macros. 2016-10-07 14:05:27 +02:00
Armin Novak
07010e6f99 Reformatted file. 2016-10-06 13:43:13 +02:00
Armin Novak
88a3b8dd76 Initializing channel context in each thread. 2016-10-06 13:43:12 +02:00
Armin Novak
4f62d848ac Refactored interlocked typedefs, avoid namespace collisions. 2016-10-06 13:43:09 +02:00
David PHAM-VAN
f5f3913c1f Fix Memory Leaks in Printer Redirection 2016-09-19 11:27:25 -07:00
Norbert Federa
90cdfa7646 cmake: replaced STATIC_CHANNELS with BUILTIN_CHANNELS 2016-06-15 13:36:27 +02:00
Marc-André Moreau
cedf6d98e2 freerdp: more UWP porting 2016-03-29 20:34:52 -04:00
Marc-André Moreau
4d629a7999 freerdp: UWP porting 2016-03-29 16:03:15 -04:00
Bernhard Miklautz
25506348d0 Merge pull request #3168 from akallabeth/visibility_fixes
Fixed default visibility.
2016-02-29 16:59:58 +01:00
Armin Novak
5acd80dd5b Exporting channel entry points. 2016-02-29 15:18:19 +01:00
Armin Novak
b7187d04a5 Printer driver from command line now used. 2016-02-26 16:14:18 +01:00
David FORT
60fed9d574 Mutualize definitions for the printer channel 2016-02-16 22:24:51 +01:00
Bernhard Miklautz
6fa3608111 cleanup cmake exports and pkg-config files
With this commit the "exported" components (usable with pkg-config and
cmake find module package)
* winpr - winpr library and headers
* freerdp - core library and headers
* freerdp-client - client specific library
* freerdp-server - server specific library
* rdtk - rdtk headers and library

To allow the installation of multiple different version (different major
number) the include files were moved into the respective sub folder:
freerdp -> freerdp{MAJOR}/freerdp (currently freerdp2/freerdp/)
winpr -> winpr{MAJOR}/winpr (currently winrp1/winpr/)
rdtk -> rdpk{MAJOR}/rdtk (currently rdtk0/rdtk/

The generated pkg-config and cmake find modules now also include the major
version number. Currently the following pkg-config are generated and
installed.
* winpr1
* freerdp2
* freerdp-server2
* freerdp-client2
* rdtk0

As cmake is able to handle multiple versions out of the box the
following can be used to find a specific module:

find_package(WinPR)
find_package(FreeRDP)
find_package(FreeRDP-Server)
find_package(FreeRDP-Client)
find_package(RdTk)

As cmake doesn't automatically resolve dependencies for packages it is
necessary to manually include the requirements. For example if
FreeRDP-Client is required WinPR and FreeRDP need to be included
(find_package) as well.

This commit also fixes the installation when STATIC_CHANNELS are built.
WITH STATIC_CHANNELS all channels are linked into libfreerdp-client, for
this all channels are generated as linker archive and linked together in
the final step. Before the intermediate linker archives were, although
not required and useful, installed. Same applies for server side
channels.
2016-01-12 17:32:33 +01:00