Norbert Federa
e3b3b52f6a
server: fix surface command types
...
- Legacy RemoteFX is encapsulated in a "Stream Surface Bits Command" (CMDTYPE_STREAM_SURFACE_BITS)
- NSCodec is encapsulated in a "Set Surface Bits Command" (CMDTYPE_SET_SURFACE_BITS)
References:
- MS-RDPRFX 3.1.8.3.1 RemoteFX Stream / Encode Message Sequencing
- MS-RDPNSC 2.2.2 NSCodec Compressed Bitmap Stream
2020-04-03 14:35:58 +02:00
Norbert Federa
d65de64676
Merge pull request #5982 from akallabeth/surface_stream_set_bits
...
Fix sending/receiving surface bits command.
2020-04-03 12:41:29 +02:00
akallabeth
cba63b6d43
Added fallback to CMDTYPE_STREAM_SURFACE_BITS
...
Since our samples were incorrect, add a fallback with a log warnings
to the old CMDTYPE_STREAM_SURFACE_BITS by default behaviour.
2020-04-03 12:18:59 +02:00
akallabeth
88ad9ca56b
Fix sending/receiving surface bits command.
...
* Pass on proper command type to application
* On send let the server implementation decide to send
2.2.9.2.1 Set Surface Bits Command (TS_SURFCMD_SET_SURF_BITS) or
2.2.9.2.2 Stream Surface Bits Command (TS_SURFCMD_STREAM_SURF_BITS)
Thanks to @viniciusjarina for tracing the issue down.
2020-04-03 12:00:53 +02:00
akallabeth
2a379bfe09
Fixed invalid seek size in patrial pdu parse case
2020-04-02 17:41:49 +02:00
akallabeth
21320d973c
Use safe seek for capability parsing
...
thanks to @hardening for pointing that one out.
2020-04-02 17:39:51 +02:00
akallabeth
ddfd0cdccf
Use substreams to parse gcc_read_server_data_blocks
2020-04-02 17:39:43 +02:00
akallabeth
6b2bc41935
Fix #6010 : Check length in read_icon_info
2020-04-02 17:34:02 +02:00
akallabeth
67c2aa52b2
Fixed #6013 : Check new length is > 0
2020-04-02 17:33:54 +02:00
akallabeth
3627aaf7d2
Fixed #6011 : Bounds check in rdp_read_font_capability_set
2020-04-02 17:28:17 +02:00
akallabeth
f8890a645c
Fixed #6005 : Bounds checks in update_read_bitmap_data
2020-04-02 17:28:10 +02:00
akallabeth
ed53cd148f
Fixed #6006 : bounds checks in update_read_synchronize
2020-04-02 17:28:04 +02:00
akallabeth
f5e73cc7c9
Fixed #6009 : Bounds checks in autodetect_recv_bandwidth_measure_results
2020-04-02 17:27:59 +02:00
akallabeth
9301bfe730
Fixed #6007 : Boundary checks in rdp_read_flow_control_pdu
2020-04-02 17:27:53 +02:00
akallabeth
58dc36b3c8
Fixed possible NULL dereference
2020-04-02 17:27:10 +02:00
Martin Fleisz
9223eea61e
Merge pull request #5974 from akallabeth/cmd_avc420_fix
...
Cmd avc420 fix
2020-04-02 08:41:47 +02:00
Martin Fleisz
99786970a3
Merge pull request #5884 from akallabeth/smartcard_ndr_strict
...
Smartcard tighter input validation
2020-03-31 08:34:04 +02:00
akallabeth
2749de506c
Added missing context and handle read.
2020-03-30 11:07:47 +02:00
Armin Novak
f360d445e2
Pack smartcard channel structs to 1 byte alignment
2020-03-27 18:24:25 +01:00
akallabeth
ac4ec690c9
Removed a few magic numbers.
2020-03-27 15:03:59 +01:00
akallabeth
80177efe69
Fixed typos, make status comparisons explicit.
2020-03-27 14:49:09 +01:00
akallabeth
9ef1e81c55
Formatted patch.
2020-03-27 14:16:18 +01:00
Julian Albrecht
7ecce5acbe
Adds touch support to wlfreerdp
2020-03-27 14:16:18 +01:00
LatinSuD
a6ccd38b68
Free clipboard respond to fix bug
...
Fixes #5997 (clipboard stops responding in the middle of a session)
2020-03-27 09:13:38 +01:00
Martin Fleisz
ca34fe4c12
Merge pull request #5985 from akallabeth/log_version_debug
...
Added buildconfig output to debug log level.
2020-03-26 09:55:46 +01:00
akallabeth
bc33a50c5a
Treat NULL and empty string as the same for credentials.
2020-03-24 12:34:35 +01:00
Martin Fleisz
43d3f89ce7
Merge pull request #5988 from akallabeth/rdp_parser_leak
...
Fixed memory leak in rdp file parser.
2020-03-24 12:17:05 +01:00
Martin Fleisz
38d1be72b4
Merge pull request #5987 from akallabeth/manual_ack_timeout
...
Add option to adjust the tcp ack timeout
2020-03-24 12:16:08 +01:00
akallabeth
fdf151698d
Fixed memory leak in rdp file parser.
2020-03-23 16:06:26 +01:00
akallabeth
453372a4bf
Add option to adjust the tcp ack timeout
...
On high latency links the default of 9 second timeout might be too
strict. Adjusting this for all users will result in a long time
for connections to fail, so let these with high latency links
adjust the value manually.
2020-03-23 08:59:38 +01:00
akallabeth
82449a9c7d
Added buildconfig output to debug log level.
2020-03-20 13:05:01 +01:00
akallabeth
cf2f674283
Initialize KeyboardHook with define instead of magic number
2020-03-18 17:22:08 +01:00
akallabeth
158bd74272
Allow externally supplied FREERDP_INSTALL_PREFIX
2020-03-18 17:22:08 +01:00
akallabeth
efb588db04
Added deprecation warning to gfx-h264
2020-03-15 10:33:53 +01:00
akallabeth
1441e78b70
Fixed gfx-h264 option parsing.
2020-03-15 10:33:34 +01:00
Kobi Mizrachi
3b673be378
server: proxy: fix wrong log level used in pf_modules_run_filter
2020-03-12 08:36:05 +01:00
Kobi Mizrachi
1484d0ac48
server: proxy: removed unnecessary cast after #5955
2020-03-12 08:36:05 +01:00
Kobi Mizrachi
73445e1462
server: proxy: use config path from argv if provided
2020-03-12 08:36:05 +01:00
Martin Fleisz
6313cccb6e
Merge pull request #5943 from akallabeth/x11_lock
...
X11 lock recursion checks
2020-03-10 16:03:54 +01:00
Armin Novak
4216646746
Fixed length checks for compressed rdp data.
2020-03-10 14:05:10 +01:00
Armin Novak
297ad536a2
Cleaned up bulk_compress/decompress, prettified log.
2020-03-10 14:05:10 +01:00
Armin Novak
c406f7a972
Fixed misleading log message.
2020-03-10 14:05:10 +01:00
Armin Novak
49b17e4e03
Refactored bulk compression
...
* Arguments now opaque
* Removed internal functions from external interface
2020-03-10 14:05:10 +01:00
Armin Novak
eca32456bb
Removed unused function
2020-03-10 14:04:53 +01:00
Armin Novak
87f5b768a9
Silenced warning due to missing debug define guard.
2020-03-10 14:04:53 +01:00
Armin Novak
ab21b1ef25
Silenced warning due to missing define guard.
2020-03-10 14:04:53 +01:00
Armin Novak
461bc825de
Removed unused function
2020-03-10 14:04:53 +01:00
Armin Novak
07cc1edaa0
Removed unused function
2020-03-10 14:04:53 +01:00
Armin Novak
106ab8cfbd
Removed unused function
2020-03-10 14:04:53 +01:00
Armin Novak
d29448bda8
Removed unused function
2020-03-10 14:04:53 +01:00