Commit Graph

246 Commits

Author SHA1 Message Date
Armin Novak
7cfd97f531 Added support for audin version 2
(cherry picked from commit 6f62d30bfd)
2022-10-24 12:01:25 +02:00
akallabeth
acd44ef292 Removed ALAW/ULAW from supported backend formats
pulse/alsa/oss do not reliably work with ALAW/ULAW codecs with all
hardware available.
Since these formats are poor quality anyway, deactivate them for
audin channel.

(cherry picked from commit c3e8720c87)
2022-10-12 09:00:40 +02:00
Felix Deimel
2d4b0858d9 Fixes https://github.com/FreeRDP/FreeRDP/issues/7408
(cherry picked from commit a8e8069503)
2022-10-07 13:27:47 +02:00
Pascal Nowack
3545728e5e channels/server: Add APIs for DVCs to get notified of channel id
This allows server implementations to watch these channel ids for their
creation statuses.
2022-06-08 16:19:31 +02:00
Pascal Nowack
b27efe5a62 audin/server: Do not overwrite values of the server audio formats
It just makes the usage of codecs impossible.
2022-06-08 16:19:31 +02:00
akallabeth
7f35f29546 Fixed compilation warnings 2022-05-13 12:56:18 +02:00
Felix Deimel
ec901e1062 Fixed memory leak in audin mac
(cherry picked from commit 24c87c5126)
2022-05-13 12:56:18 +02:00
akallabeth
548e96d3bc Update nAvgBytesPerSec in audin_winmm_set_format
The format channel count and alignment may have changed.
Update nAvgBytesPerSec accordingly

(cherry picked from commit c6e84c4929)
2022-01-27 16:05:26 +01:00
akallabeth
1c1dd91560 [audin] Always reset dsp_context before open (#7342)
(cherry picked from commit 834fdf0046)
2022-01-27 16:05:26 +01:00
akallabeth
84efc70a18 Fixed const warning in opensl es backend
(cherry picked from commit b5d85696f6b9c4702b2cdb9106c33851093c840e)
2022-01-10 11:18:13 +01:00
Armin Novak
d4f5003bc9 Fixed windows audio recording issues:
1. Fix recording channels to mono
2. Fix alignment of PCM data to 2 bytes

(cherry picked from commit 45d785196d)
2021-07-27 11:57:33 +02:00
Armin Novak
8fd6be5b0c Added API check to allow compilation/run with mac os < 10.14
(cherry picked from commit 1cd97c3270)
2021-03-05 10:06:54 +01:00
Martin Fleisz
63aa57b939 channels/audin: Request correct media type in audin channel on Mac
(cherry picked from commit 4a952977c1)
2020-12-02 14:10:45 +01:00
Armin Novak
aa6d116446 Added permission checks for mac audio backend.
(cherry picked from commit 0e0eb5f41f)
2020-12-02 14:10:01 +01:00
Armin Novak
cbd7964468 Added duplicate initialization check for plugins.
(cherry picked from commit 75aab487e2)
2020-12-01 15:10:23 +01:00
akallabeth
3fe4650b2c Fixed DestroyListener arguments and call order
(cherry picked from commit 0e08727d4e)
2020-05-18 16:41:20 +02:00
akallabeth
47b4867729 Destroy channel listeners on terminate
(cherry picked from commit 2f5e5359f6)
2020-05-18 16:40:52 +02:00
Armin Novak
0154d3ceb8 audin pulse log states by name 2020-02-25 14:57:42 +01:00
Martin Fleisz
53f7927bf3 audin: Fix possible crash in winmm backend 2020-01-16 10:23:17 +01:00
Martin Fleisz
05a865281e channels: Fix memory leak and make log messages more precise 2020-01-08 16:49:15 +01:00
Martin Fleisz
d21e0a6d6d Fix audio channel init when no audio devices are present
This PR fixes the handling of using rdpsnd or audin when the system has
no audio device available.
In case of a missing playback device the
Windows backend now correctly reports an error and the fake rdpsnd
backend is loaded.
If audin is enabled and no microphone is present the channel
initialization will report an error but it won't cut the connection (as
it did before).
2019-12-30 12:59:14 +01:00
Armin Novak
da6ff1ca65 Removed some unnecessary casts. 2019-12-05 11:40:56 +01:00
Armin Novak
72ca88f49c Reformatted to new style 2019-11-07 10:53:54 +01:00
Martin Fleisz
bc39b32d20
Merge pull request #5685 from akallabeth/multi_instance_arg_parse
COMMAND_LINE_ARGUMENT structs contain parser results, use one per instance
2019-11-06 09:09:22 +01:00
Armin Novak
f01e042211 Code cleanups (strlen, casts, size_t, ...) 2019-10-29 11:58:43 +01:00
Armin Novak
0c87eaee4d COMMAND_LINE_ARGUMENT structs contain parser results, use one per instance
Remove the old global structs as the parser modifies them. When using
multiple instances in the same process space this could break parsing.
2019-10-28 13:30:05 +01:00
Armin Novak
30c21279cb Fixed memory leak when freeing up audin formats. 2019-10-24 12:18:24 +02:00
Armin Novak
624d895106 Fixed sign issues 2019-04-05 09:22:35 +02:00
Armin Novak
ef1728faf5 Fixed NULL dereferences and uninitialized values 2019-01-30 16:11:10 +01:00
Peter Åstrand (astrand)
30cd1ba1ab Use lowercase for includes and libs
Makes build possible on case sensitive systems such as MinGW on Linux.
2019-01-09 09:36:28 +01:00
Ilya Shipitsin
bdc039e719 resolve several issues found by cppcheck
[client/X11/xf_floatbar.c:800] -> [client/X11/xf_floatbar.c:796]: (warning) Either the condition '!floatbar' is redundant or there is possible null pointer dereference: floatbar.
[client/X11/xf_floatbar.c:800] -> [client/X11/xf_floatbar.c:797]: (warning) Either the condition '!floatbar' is redundant or there is possible null pointer dereference: floatbar.
[client/X11/xf_floatbar.c:800] -> [client/X11/xf_floatbar.c:798]: (warning) Either the condition '!floatbar' is redundant or there is possible null pointer dereference: floatbar.
[libfreerdp/codec/dsp.c:1156] -> [libfreerdp/codec/dsp.c:1154]: (warning) Either the condition '!srcFormat' is redundant or there is possible null pointer dereference: srcFormat.
[channels/drdynvc/client/drdynvc_main.c:1453] -> [channels/drdynvc/client/drdynvc_main.c:1450]: (warning) Either the condition '!drdynvc' is redundant or there is possible null pointer dereference: drdynvc.
[channels/audin/client/opensles/audin_opensl_es.c:98] -> [channels/audin/client/opensles/audin_opensl_es.c:94]: (warning) Either the condition '!opensles' is redundant or there is possible null pointer dereference: opensles.
[channels/audin/client/opensles/audin_opensl_es.c:159] -> [channels/audin/client/opensles/audin_opensl_es.c:153]: (warning) Either the condition '!opensles' is redundant or there is possible null pointer dereference: opensles.
2019-01-02 20:35:24 +05:00
Armin Novak
0f45a570fa Added fallback for supported sample rates if original not supported.
Added format compatibility check between recording input and destination.
2018-11-14 13:27:20 +01:00
Armin Novak
93eea24120 Fixed possible NULL pointer dereference 2018-11-14 13:27:20 +01:00
Armin Novak
7aebf8ebd2 Silence code analyzers, check correct variable for NULL. 2018-10-25 13:19:45 +02:00
Martin Fleisz
00af869cd3
Merge pull request #4889 from akallabeth/shadow_server_audin_refactor
Shadow server audin refactor
2018-10-08 12:56:09 +02:00
Armin Novak
ac14763564 [audin] Abort version exchange if server version is not supported. 2018-10-04 13:53:18 +02:00
Armin Novak
47f8804073 Fixed audio recording with opensles. 2018-10-04 13:18:06 +02:00
Armin Novak
d56efaae8b Fixed server format selection. 2018-09-26 12:49:09 +02:00
Armin Novak
16531e1437 Fixed server audin callback, provide more information. 2018-09-26 12:49:09 +02:00
Armin Novak
18f97d03e7 Cleaned up defaults. 2018-09-26 12:49:09 +02:00
Armin Novak
106dde9571 Working mic redirection for shadow server. 2018-09-26 12:49:09 +02:00
Armin Novak
28efbbc01f Refactored audio_format* functions. 2018-09-26 12:49:09 +02:00
Armin Novak
dab5770fed Added microphone support to shadow server. 2018-09-25 11:14:10 +02:00
Ondrej Holy
926ac4f938 channels/audin: Fix leak found by covscan
leaked_storage: Variable out going out of scope leaks the storage it points to.
2018-08-22 13:35:43 +02:00
Armin Novak
44d1438eac Fixed mac audin 2018-08-01 12:56:17 +02:00
Armin Novak
7355b4e5f3 Fixed leak in audio format processing. 2018-07-31 10:33:19 +02:00
MartinHaimberger
2d7499b7c0
Merge pull request #4758 from akallabeth/dsp_fix
Audio/microphone fixes
2018-07-31 10:22:22 +02:00
Armin Novak
033abe93d4 Fixed callback parameter checks. 2018-07-30 11:22:11 +02:00
Armin Novak
3b187ef321 Code Cleanup 2018-07-19 16:21:03 +02:00
Martin Fleisz
b6a41b26e5 audin: Fix server-side dsp decoding
The decoder format was never set and so dsp_decode always failed
on the server side.
2018-07-19 16:00:31 +02:00