Bernhard Miklautz
28e63786cd
Integrate pull request feedback
...
Use while instead of for with additional variable where appropriate.
2015-06-25 10:33:54 +02:00
Bernhard Miklautz
9f6fa7ef4c
Fix possible endless loops on cleanup.
...
Some cleanup code possibly create endless loops because an unsigned
type was used as run variable but the check was >= 0 in the for loop.
2015-06-24 12:26:13 +02:00
Armin Novak
24fed46cda
Fixed grabage return value.
2015-06-23 12:08:47 +02:00
Armin Novak
212db120e0
Fixed NULL pointer dereference.
2015-06-23 12:07:38 +02:00
Bernhard Miklautz
09445c2b0e
nla and cmdline: integrated feedback
...
* fix possible problems with 0 size lengths
* add return value checks
2015-06-23 10:14:11 +02:00
Bernhard Miklautz
af81a91ea7
windows: fix compilation and warnings
2015-06-22 19:31:25 +02:00
Bernhard Miklautz
06502e6a91
misc: integrate pull request feedback
2015-06-22 19:24:30 +02:00
Bernhard Miklautz
421b74e85e
client/locale: properly check popen return value
...
popen returns NULL if an error occurs and not < 0.
2015-06-22 19:23:58 +02:00
Bernhard Miklautz
1b8dd139a9
cmd line: add missing checks
...
* strdup
* some allocs
2015-06-22 19:23:57 +02:00
Bernhard Miklautz
5de0e02c61
cache: fix regression
...
Fix a regression in cache_new introduced in commit
b4f147e242ea396ef92082d29866e5ab7d041b4e
2015-06-22 19:21:47 +02:00
David FORT
7c3f8f33ab
Fixes for malloc / calloc + other fixes
...
This patch contains:
* checks for malloc return value + treat callers;
* modified malloc() + ZeroMemory() to calloc();
* misc fixes of micro errors seen during the code audit:
** some invalid checks in gcc.c, also there were some possible
integer overflow. This is interesting because at the end the data are parsed
and freed directly, so it's a vulnerability in some kind of dead code (at least
useless);
** fixed usage of GetComputerNameExA with just one call, when 2 were used
in misc places. According to MSDN GetComputerNameA() is supposed to return
an error when called with NULL;
** there were a bug in the command line parsing of shadow;
** in freerdp_dynamic_channel_collection_add() the size of array was multiplied
by 4 instead of 2 on resize
2015-06-22 19:21:47 +02:00
Bernhard Miklautz
77927c213e
android: fix misc compiler warnings
...
with gcc version arm-linux-androideabi-gcc (GCC) 4.8
2015-06-22 19:09:59 +02:00
Bernhard Miklautz
bf73f4e4f1
Fix unchecked strdups
...
* add missing checks
* adapt function return values where necessary
* add initial test for settings
2015-06-22 19:09:59 +02:00
Marc-André Moreau
3b3ffce042
Merge pull request #2705 from akallabeth/sspi_fix_v2
...
Sspi fix v2 - Fixes static build
2015-06-22 10:19:22 -04:00
Marc-André Moreau
20f78405c8
Merge pull request #2684 from Skool/master
...
Add bépo layout
2015-06-22 09:31:15 -04:00
Marc-André Moreau
9aabec73f5
Merge pull request #2713 from bmiklautz/divbyzero
...
core/metrics: prevent division by zero
2015-06-22 08:53:36 -04:00
Marc-André Moreau
1e39d7728c
Merge pull request #2702 from akallabeth/nla_null_identity_support
...
NLA Use current users credentials if none provided.
2015-06-22 08:53:05 -04:00
Bernhard Miklautz
41ef7ca17c
core/metrics: prevent division by zero
2015-06-19 17:21:16 +02:00
Norbert Federa
91a9b23b91
core: message channel pdu broken with rdp security
...
rdp_recv_message_channel_pdu always read the rdp security header
even if it was already previously read (which is the case if rdp
security is active)
This caused malfunctions and disconnects when heartbeat or bandwidth
autodetect packets were sent/received in rdp security mode.
Credit goes to @MartinHaimberger for identifying the broken code
part.
2015-06-19 14:49:17 +02:00
Vic Lee
2e11eac79a
Merge pull request #2675 from akallabeth/path_make_path
...
Added PathMakePath function.
2015-06-18 02:43:47 +00:00
Armin Novak
3c329aa207
Using InitSecurityInterfaceEx(0) now.
2015-06-17 13:23:44 +02:00
Armin Novak
34253f2664
Let SSPI module choose which implementation to use.
2015-06-15 15:21:21 +02:00
Armin Novak
219ca1c02b
NLA identity now a pointer, allowing NULL.
...
When NLA identity is NULL, the current user context
is used on windows.
2015-06-15 15:03:13 +02:00
Vic Lee
145fc10412
Merge pull request #2687 from akallabeth/known_hosts_v2
...
Store SSL fingerprints with host and port
2015-06-12 12:52:53 +00:00
Armin Novak
b43c9f9060
Renamed file to known_hosts2.
2015-06-12 09:30:01 +02:00
Norbert Federa
20aa10e6ae
codec/color: support for 8bpp color pointer
2015-06-11 16:34:42 +02:00
Norbert Federa
86d398f0a3
codec/color: support for 16bpp color pointer
2015-06-11 13:12:21 +02:00
Armin Novak
9dd9c35cee
Updated tests.
2015-06-11 11:34:36 +02:00
Armin Novak
3dda4eb0cf
Added NULL pointer checks, fixed warnings.
2015-06-11 11:34:22 +02:00
Armin Novak
7fc1c65165
Added subject and issuer to saved data.
...
When a certificate has changed, display not only the
fingerprint but also subject and issuer of old certificate.
2015-06-11 11:21:23 +02:00
Armin Novak
7786cf1376
Fixed fingerprint comparison, return value was inverted.
2015-06-11 09:59:04 +02:00
Armin Novak
90d836193c
Fixed formatting.
2015-06-11 09:58:58 +02:00
Armin Novak
3d27055539
Added test for fingerprint read.
2015-06-11 09:24:55 +02:00
Armin Novak
b983d8e595
Fixed data replace.
2015-06-11 09:24:53 +02:00
Armin Novak
acc96388a5
Added certificate_get_fingerprint function to read out old one.
2015-06-11 09:14:15 +02:00
Vic Lee
d75ac1ec12
autodetect: use high-precision timer.
2015-06-11 15:12:27 +08:00
Armin Novak
2204df97f8
Added port to certificate warnings.
2015-06-10 10:59:40 +02:00
Armin Novak
ef0b9abf15
Using binary mode for fopen.
2015-06-10 10:47:59 +02:00
Armin Novak
ebad760aff
Opening correct file.
2015-06-10 10:40:01 +02:00
Armin Novak
f4843e8ab3
Opening file on use now.
2015-06-10 10:34:02 +02:00
Armin Novak
05755b73ad
Working unit test for known_hosts functions.
2015-06-10 09:15:38 +02:00
Armin Novak
98fc5b6e93
Fixed bugs found due to test.
2015-06-10 09:15:28 +02:00
Armin Novak
991fc39a62
Added unit test.
2015-06-09 18:03:32 +02:00
Armin Novak
6192230737
Added legacy known_hosts support.
...
If no entry for the <host> <port> combination
was found in the v2 file and there is a legacy file
check if a matching <host> entry can be found.
In case there is a matching entry and the <fingerprint>
also matches, create a new entry in the v2 file using the
current port.
2015-06-09 16:12:41 +02:00
Armin Novak
6da4a5aaf0
Using '<host> <port> <fp>' format for known hosts.
2015-06-09 15:33:13 +02:00
Armin Novak
5b7a44cd4a
Removed CreateDirectoryA, handled by PathMakePath
2015-06-09 13:17:15 +02:00
Armin Novak
7403cdc60c
Added PathMakePath function.
2015-06-09 13:16:28 +02:00
Bernhard Miklautz
07407927c2
Merge pull request #2670 from akallabeth/windows_config_paths
...
Adjusted config paths
2015-06-09 12:35:45 +02:00
tdb
aa0849224c
fix French bépo layout id to match the bépo.fr installer
2015-06-08 17:01:43 +02:00
tdb
c9e750214a
Add Bépo Layout
2015-06-05 10:52:40 +02:00