Commit Graph

664 Commits

Author SHA1 Message Date
Armin Novak
7cf95bcf6e Fixed compile error. 2013-09-13 09:17:06 +02:00
Armin Novak
32a9bd366c Fixed reading of SCARD_IO_REQUEST structures in Transmit_Call. 2013-09-12 15:50:12 +02:00
Armin Novak
513c963670 Smartcard arguments now optional. 2013-09-12 14:55:25 +02:00
Armin Novak
8f024d46cf Fixed setting of name and path of smartcard, now determining on number
of valid arguments.
2013-09-12 14:41:11 +02:00
Armin Novak
31abdb9103 Fixed setting of smartcard filter name and path. 2013-09-12 14:34:18 +02:00
Armin Novak
27cb9ee604 Now printing debug message for unhandled data. 2013-09-12 14:10:44 +02:00
Armin Novak
c33821d026 Resource cleanup now done using goto
Length now checked at all places.
2013-09-12 13:53:15 +02:00
Armin Novak
02abe530a8 Added debug output, if some message block could not be read. 2013-09-12 12:30:46 +02:00
Armin Novak
9455c4fa5d Fixed smartcard argument checks.
Fixed smartcard package reading.
2013-09-12 12:18:35 +02:00
Bernhard Miklautz
8baa04e7e5 Merge pull request #1448 from akallabeth/coverity_fixes
Multiple resource leak and NULL pointer dereferencing fixes
2013-09-10 00:56:30 -07:00
Armin Novak
3b931a9d69 Reverted accidental commit. 2013-09-06 11:08:45 +02:00
Armin Novak
c986f30c4a Fixed smartcard related issues with double free. 2013-09-06 10:55:26 +02:00
Armin Novak
81a5e727d6 Added proper thread sync for input thread.
Channels thread now listening to message pipe quit signal posted
when shutting down the channel.
2013-09-06 09:02:46 +02:00
Marc-André Moreau
f790831e7d Merge branch 'master' of github.com:awakecoding/FreeRDP into xrdp-ng 2013-09-05 15:23:19 -04:00
Armin Novak
8442c79e10 Added assertions and ExitThread calls. 2013-09-05 14:27:34 +02:00
Armin Novak
8e6b79376c Fixed possible race found by bmiklautz 2013-09-05 13:41:32 +02:00
Armin Novak
6c7ad72295 Fixed thread handling. 2013-09-05 13:40:16 +02:00
Armin Novak
d7d5869cb6 Fixed thread handling. 2013-09-05 13:39:15 +02:00
Armin Novak
733a39779c Fixed thread handling. 2013-09-05 13:39:05 +02:00
Armin Novak
d2fec8f612 Fixed thread handling. 2013-09-05 13:38:56 +02:00
Armin Novak
1d416ff387 Fixed thread handling. 2013-09-05 13:38:47 +02:00
Armin Novak
3b54ba3449 Fixed thread handling. 2013-09-05 13:38:35 +02:00
Armin Novak
07139276b5 Added newlines at end of file, prevents clang from crashing... 2013-09-05 12:14:35 +02:00
Armin Novak
6ac0b10158 Removed buffer copy, still fixes memory leak. 2013-09-05 12:14:34 +02:00
Armin Novak
854aa3fcfa Fixed memory leak. 2013-09-05 12:14:34 +02:00
Armin Novak
7bc0cbdabf Fixed clang issues. 2013-09-05 12:14:34 +02:00
Armin Novak
e5c138a5b9 Fixed various memory leaks, allocation size issues and API misuse
warnings shown by clang as well as some compiler warnings.
2013-09-05 12:14:34 +02:00
Armin Novak
a3b531c036 Fixed issues found with clang-analyzer 2013-09-05 12:14:33 +02:00
Armin Novak
1e2455fa4a Fixed various memory leaks and compiler warnings. 2013-09-05 12:14:33 +02:00
Armin Novak
a3c319c973 Fixed coverity issue 1047567 2013-09-05 12:14:33 +02:00
Armin Novak
82382d88ba Fixed coverity issue 1047568 2013-09-05 12:14:33 +02:00
Armin Novak
82f0efd6e6 Fixed coverity issue 1047635 2013-09-05 12:14:31 +02:00
Armin Novak
42ceabbebb Fixed coverity issue 1047636 2013-09-05 12:14:31 +02:00
Armin Novak
d1c24aa873 Fixed coverity issue 1047640. 2013-09-05 12:14:31 +02:00
Armin Novak
8ecbb86acf Fixed issue #1281, thread shutdown now properly waiting for quit. 2013-09-05 09:33:12 +02:00
Marc-André Moreau
7edfe66274 freerdp: various missing link dependencies and symbol exports 2013-09-03 21:48:26 -04:00
Marc-André Moreau
ee36541fb7 freerdp: merge with master 2013-09-03 18:49:48 -04:00
Marc-André Moreau
1b7abe9e4f Merge branch 'master' of github.com:FreeRDP/FreeRDP 2013-09-03 18:42:47 -04:00
Marc-André Moreau
c11da95165 Merge branch 'master' of github.com:awakecoding/FreeRDP into xrdp-ng 2013-09-03 18:41:14 -04:00
Mike McDonald
3e1f72a011 Fixed minor formatting issues 2013-08-28 21:37:45 -04:00
Mike McDonald
cfe90ae829 Added RDPSND device plugin for iOS 2013-08-28 21:03:34 -04:00
Mike McDonald
772f738c47 Added RDPSND device plugin for iOS 2013-08-28 21:02:48 -04:00
Hardening
c7c5be0bf7 Extract shared code in RAIL channel
This patch starts a code mutualisation for a RAIL server-side
implementation. The file rail_common.c contains code that is shared
by both client and server.
2013-08-29 00:06:50 +02:00
Marc-André Moreau
c878200e00 channels/server: refactor to match WTSApi + avoid conflicts 2013-08-20 19:26:36 -04:00
Marc-André Moreau
552cee7431 channels/server: start refactoring to fully match WTSApi 2013-08-20 18:06:19 -04:00
Marc-André Moreau
73c02a7637 channels/cliprdr: fix unicode conversion 2013-08-19 12:21:40 -04:00
Marc-André Moreau
23a8354656 channels: rdpsnd refactoring, drdynvc initial server-side code 2013-08-18 21:52:55 -04:00
Marc-André Moreau
3d0d65e917 channels/rdpdr: server-side device list and user logged on pdu 2013-08-18 20:27:50 -04:00
Marc-André Moreau
363bd27d76 channels/rdpdr: start server-side device redirection 2013-08-18 18:09:12 -04:00
Marc-André Moreau
af93bee5d2 channels/cliprdr: implement initialization of server-side cliprdr 2013-08-18 15:39:28 -04:00
Marc-André Moreau
bca442a477 channels/cliprdr: start exchanging messages with server-side cliprdr 2013-08-16 21:17:24 -04:00
Marc-André Moreau
0fd705c6c7 channels/cliprdr: start server-side implementation 2013-08-16 16:46:47 -04:00
Armin Novak
6f9183c7aa Using a monitor thread for tty input now to work around a WaitForMultipleObjects
limitation of winpr.
Using infinite timeout now in threads to reduce CPU usage to nearly zero.
2013-08-16 15:51:44 +02:00
Armin Novak
60d38daf0a Reset file descriptor set only, if necessary now. 2013-08-16 12:40:06 +02:00
Armin Novak
7f89966efc Fixed compilation error, now using WaitForMultipleObjects. 2013-08-16 10:50:07 +02:00
Armin Novak
1a96bdc7a5 Fixed initialization of serial device, now aborting pending
read / write operations.
2013-08-16 10:34:54 +02:00
Marc-André Moreau
f82c825176 Merge pull request #1422 from akallabeth/serial_event_fix
Serial event fix and resource leakage fixes
2013-08-14 08:45:04 -07:00
Armin Novak
e40d921da3 Removed EAGAIN handling, again passing on the error to the server. 2013-08-14 17:33:46 +02:00
Marc-André Moreau
1b25d81086 Merge pull request #1415 from akallabeth/clipboard_fix_clean
Clipboard fix
2013-08-14 06:54:52 -07:00
Marc-André Moreau
729f73d52b Merge pull request #1405 from akallabeth/printer_stop_fix
Fix hang on shutdown with printer redirection
2013-08-14 06:54:15 -07:00
Armin Novak
bb0e5f2660 Fixed invalid access to tty in thread, which was already removed by
serial_process_irp_close
Retry read now, if non blocking IO returns EAGAIN.
2013-08-14 15:14:40 +02:00
Armin Novak
d4945f7a81 Fixed high CPU usage. 2013-08-14 13:23:55 +02:00
Armin Novak
755bd6980b Fixed resource leaks and missing thread sync. 2013-08-14 13:23:54 +02:00
Armin Novak
1d2adcbe26 Fixed resource leaks. 2013-08-14 13:23:54 +02:00
Armin Novak
7d27062edd Using WaitForMultipleObjects now to reduce CPU load. 2013-08-13 14:04:17 +02:00
Armin Novak
1a681ad117 Moved generated tables.c to binary folder. 2013-08-12 13:41:11 +02:00
Armin Novak
d41f2fa2ed Added links to documentation of message sequences for clipboard data exchange. 2013-08-12 12:47:47 +02:00
Armin Novak
a57f1302f4 Fixed invalid package size allocation and calculation in cliprdr_process_format_list_event
Enabled and fixed error handling in cliprdr_process_format_list_response
2013-08-09 16:23:00 +02:00
Armin Novak
44c80c29cc Fixed #1404, using WaitForMultipleObjects now. 2013-08-08 14:46:21 +02:00
Marc-André Moreau
9be33f83ea channels/rdpei: make use of critical section 2013-08-03 16:45:53 -04:00
Marc-André Moreau
36f361b2d5 Merge pull request #1389 from akallabeth/urbdrc_cmake_fixes
Urbdrc cmake fixes
2013-08-03 13:18:04 -07:00
Armin Novak
71ec4e5a32 Added libusb detection CMake script. 2013-08-02 15:49:53 +02:00
Armin Novak
e1ca852e00 Fixed linking with libusb, now linking against correct library. 2013-08-02 15:49:53 +02:00
Armin Novak
bb1e6ce5e0 Now using libraries detected by CMake for linking against libusb. 2013-08-02 15:49:53 +02:00
Armin Novak
3e56dd108a Added proper CMake checks for libraries linked with urbdrc 2013-08-02 15:49:53 +02:00
Daryl Poe
174f2114dc fix segfault due to pulse input race condition
(cherry picked from commit be51676541)
2013-07-29 18:19:47 +02:00
Marc-André Moreau
b0450f556e channels/disp: initial MS-RDPEDISP support (8.1 Preview build) 2013-07-15 10:43:38 -04:00
Marc-André Moreau
a306d3f9fc channels/rdpei: fix multitouch with Word 2013 2013-07-11 11:04:20 -07:00
Marc-André Moreau
5926fa36dd libfreerdp-client: use PubSub for OnChannelConnected/OnChannelDisconnected 2013-07-11 08:53:15 -07:00
Marc-André Moreau
f5c2181218 channels/disp: update 2013-07-10 14:04:43 -07:00
Marc-André Moreau
eca98fe8cc channels/disp: initial RDP8.1 MS-RDPEDISP implementation 2013-07-08 18:36:03 -04:00
Norbert Federa
db6c0083d0 channels/serial: bring it back to life
- Fixes #1166
- Fixed a possible segfault caused by invalid command line parameters
- Removed serial->in_event which had no effect at all on the program logic
2013-07-03 14:09:04 +02:00
Marc-André Moreau
863b51f938 freerdp: merge with master 2013-06-28 12:50:24 -04:00
Marc-André Moreau
7bb9e5e408 Merge pull request #1308 from dbungert/tsmf
Assorted tsmf and gstreamer fixes
2013-06-28 09:40:29 -07:00
Marc-André Moreau
237f5a63d5 Merge pull request #1288 from dbungert/dvcmanDupeChannels
Free incompletely initialized dvcs.
2013-06-28 09:36:40 -07:00
Daniel Bungert
c95b5c49a6 Assorted tsmf and gstreamer fixes:
* tsmf audio volume fixes
  * The first audio volume message is received before everything is
    initialized.  Cache this data until we're ready.
  * Handle the cases of gstreamer unitialized/partially ready/
    fully ready.
  * Default to 50% as a fallback if the above fails.
* Improved detection of the primary monitor.
* Fix an unexpected shutdown when the server asks us to resize the media
  overlay to (width=0,height=0).
* Permit multiple presentations - required for repeat of audio files
  and also is seen in some video cases.
* Several leak fixes.
* Fix logging related compile warnings and other usage of PRIu64.
2013-06-19 12:33:46 -04:00
Bernhard Miklautz
0fd6439123 server/sample: fix build
Needs now also to be linked against winpr-error
2013-06-13 14:53:09 +02:00
Daniel Bungert
475a44f0e2 Free incompletely initialized dvcs.
If dynamic channels are not completely initialized, the server will
reuse those channel numbers for new channels.
This causes interesting problems when the server asks for a channel
by number, as we can end up with multiple channels with the same number.

Log example of the problem:
DBG_DVC drdynvc_process_receive (341): Cmd=0x1
DBG_DVC drdynvc_process_create_request (249): ChannelId=0 ChannelName=PNPDR
DBG_DVC drdynvc_process_create_request (265): no listener
DBG_DVC drdynvc_process_receive (341): Cmd=0x1
DBG_DVC drdynvc_process_create_request (249): ChannelId=0 ChannelName=TSMF
DBG_DVC tsmf_on_new_channel_connection (378):
DBG_DVC dvcman_create_channel (415): listener TSMF created new channel 0
DBG_DVC drdynvc_process_create_request (260): channel created
DBG_DVC drdynvc_process_receive (341): Cmd=0x3
DBG_DVC drdynvc_process_data (311): ChannelId=0
Warning dvcman_receive_channel_data (517): ChannelId 0 not ready!

In this log, we received data intended for TSMF, but the channel lookup
found the incompletely initialized PNPDR.
2013-06-11 16:49:27 -04:00
Marc-André Moreau
3317592ecb channels/rdpei: fix long press (multitouch right-click) 2013-06-11 16:15:46 -04:00
Marc-André Moreau
977191bba2 channels/rdpei: start implementing strict state machine logic 2013-06-06 18:37:52 -04:00
Marc-André Moreau
7c877e1a61 channels/rdpei: restructure 2013-06-06 18:14:59 -04:00
Marc-André Moreau
2bd6808432 freerdp: merge with master 2013-06-05 10:31:01 -04:00
Hardening
5ad5e5821a Refactored printf(msg) to fprintf(stderr, msg) 2013-06-02 11:07:59 +02:00
Marc-André Moreau
7cf9526a78 channels/tsmf: fix set source video rect 2013-05-29 12:21:54 -04:00
Marc-André Moreau
e45f149db4 channels/rdpsnd: fix potential uninitialized value 2013-05-25 15:49:44 -04:00
Marc-André Moreau
e9d362b58e channels/printer: fix printer redirection and test with cups-pdf 2013-05-20 15:50:22 -04:00
Marc-André Moreau
8095bec3ec channels/drdynvc: call OnChannelDisconnected 2013-05-20 15:23:54 -04:00
Vic Lee
25229f520f channels/server: provide error codes to distinguish between not-registered and not-ready state. 2013-05-19 16:46:02 -07:00
Marc-André Moreau
367ebf32a3 freerdp: make use of stream macros to access members 2013-05-15 12:14:26 -04:00
Marc-André Moreau
9229548cd7 xfreerdp: fix initialization when multitouch hardware is not present 2013-05-15 11:39:28 -04:00
Marc-André Moreau
0ee55ddcfe channels/rdpei: fix warnings 2013-05-14 22:01:36 -04:00
Marc-André Moreau
c3efeccbd6 xfreerdp: partial cleanup of multitouch code 2013-05-14 19:26:01 -04:00
Marc-André Moreau
e6aec6c936 xfreerdp: initial multitouch functionality 2013-05-14 17:45:52 -04:00
Marc-André Moreau
c23da2f80b channels/rdpei: minor improvements 2013-05-14 01:06:25 -04:00
Marc-André Moreau
b385e61bc0 xfreerdp-client: start trying to send multitouch events 2013-05-13 19:17:25 -04:00
Marc-André Moreau
d96249e19f libfreerdp-client: start propagating channels initialization to client 2013-05-13 17:39:53 -04:00
Marc-André Moreau
e72f898956 channels/drdynvc: refactor and start exporting interface 2013-05-13 16:07:42 -04:00
Marc-André Moreau
8e151409be libfreerdp-client: export and register successfully interface pointer for channel 2013-05-12 21:23:12 -04:00
Marc-André Moreau
608f00b7df libfreerdp-client: propagate and export pInterface extended channel pointer 2013-05-12 20:40:48 -04:00
Marc-André Moreau
2f02ad3b68 libfreerdp-client: split channels code into multiple files 2013-05-12 19:52:24 -04:00
Marc-André Moreau
b18ffa2c88 libfreerdp-client: internal channels code cleanup 2013-05-12 19:08:08 -04:00
Marc-André Moreau
929b3b3076 channels/tsmf: implement set source video rect (0x116) 2013-05-10 17:36:27 -04:00
Marc-André Moreau
dc0aa4c72d Merge branch 'master' of github.com:FreeRDP/FreeRDP 2013-05-10 16:43:19 -04:00
Marc-André Moreau
ba0b4ee524 libfreerdp-client: load rdpdr when rdpsnd is loaded 2013-05-10 16:39:16 -04:00
Daryl Poe
089bfbea2c handle drdynv version 3 2013-05-10 13:57:22 -06:00
Marc-André Moreau
335d13d65f channels/rdpei: implement client pdus 2013-05-09 00:21:33 -04:00
Marc-André Moreau
e3a4d125cd channels/rdpei: start implementing multitouch 2013-05-08 23:18:42 -04:00
Marc-André Moreau
fdf3ddcf9e freerdp: purge deprecated stream utils 2013-05-08 17:48:30 -04:00
Marc-André Moreau
fd230443c5 freerdp: purge old stream utils 2013-05-08 16:27:21 -04:00
Marc-André Moreau
5b92413843 freerdp: purge deprecated stream utils 2013-05-08 16:09:16 -04:00
Marc-André Moreau
b4cac74136 xfreerdp-server: fix RemoteFX encoding 2013-05-01 18:15:55 -04:00
Marc-André Moreau
51715636a5 freerdp: remove some deprecated stream utils 2013-04-29 22:35:15 -04:00
Martin Fleisz
c0dffd6edf Android: Added SDCard redirection support 2013-04-25 07:30:33 -07:00
Marc-André Moreau
0cbdd6b641 freerdp: merge with master 2013-04-09 10:18:03 -04:00
Marc-André Moreau
5325ad386c wfreerdp: fix build 2013-04-01 18:21:21 -04:00
Marc-André Moreau
9129bc3c7a channels/client: name refactoring 2013-03-29 18:55:59 -04:00
Marc-André Moreau
7d88e404d2 channels/client: refactor global channel manager list 2013-03-29 18:38:39 -04:00
Marc-André Moreau
506c665df2 channels/client: start breaking down into smaller blocks channel code 2013-03-29 17:53:18 -04:00
Marc-André Moreau
f4df4e4b26 channels: partial cleanup 2013-03-29 14:49:09 -04:00
Bernhard Miklautz
81a97144f1 channel/tsmf: fix for gstreamer detection
Print warning if gstreamer is there but xrandr is missing.
2013-03-29 16:17:03 +01:00
Bernhard Miklautz
23cac314a1 channel/tsmf: fixed gstreamer plugin build
Gstreamer wasn't build because it requires xrandr which wasn't
detected.

Fixes #1146
2013-03-29 13:17:12 +01:00
Marc-André Moreau
d187becc28 freerdp: merge with master 2013-03-28 21:20:36 -04:00
Marc-André Moreau
3417a3aab5 freerdp: merge RDP_EVENT type with wMessage 2013-03-28 21:13:56 -04:00
Marc-André Moreau
f757623f7f channels: replace event_type, event_class with id for events 2013-03-28 20:23:16 -04:00
Marc-André Moreau
8ad5932a3d channels: continue event refactoring 2013-03-28 19:33:31 -04:00
Marc-André Moreau
72bf8ea032 libfreerdp-utils: start migrating old eventing system 2013-03-28 18:29:57 -04:00
Hardening
7701c9d934 Replace printf(...) by fprintf(stderr, ...) 2013-03-28 23:06:34 +01:00
Marc-André Moreau
068f0de4d4 libfreerdp-utils: purge old file utils 2013-03-22 15:52:43 -04:00
Marc-André Moreau
dbbb341098 libfreerdp-utils: purge thread utils 2013-03-21 17:58:18 -04:00
Marc-André Moreau
75d4c70dd0 channels/printer: remove usage of thread utils 2013-03-21 17:40:04 -04:00
Marc-André Moreau
996e7c5dbd channels/audin/server: remove usage of old thread utils 2013-03-21 17:28:55 -04:00
Marc-André Moreau
8c8a82c31f libfreerdp-utils: purge old STREAM utils 2013-03-21 16:45:25 -04:00
Marc-André Moreau
a8201b0d1b libwinpr-utils: combine old and new stream utils 2013-03-21 15:19:33 -04:00
Marc-André Moreau
62eec0c2b5 libfreerdp-utils: rename internal members of STREAM to match new wStream 2013-03-21 15:01:46 -04:00
Marc-André Moreau
882c914e6c channels/tsmf: fix build 2013-03-21 14:45:03 -04:00
Marc-André Moreau
4d240b627d channels/tsmf: remove usage of old thread utils 2013-03-20 21:42:52 -04:00
Marc-André Moreau
16ba581553 channels/serial: remove usage of old thread utils 2013-03-20 21:22:47 -04:00
Marc-André Moreau
6ad532fbf4 channels/parallel: remove usage of old thread utils 2013-03-20 20:57:51 -04:00
Marc-André Moreau
6a71f2e442 channels/audin: remove usage of old thread utils 2013-03-20 20:44:31 -04:00
Marc-André Moreau
2cfb8761d8 channels/rdpei: stub RDP8 multi-touch extension 2013-03-19 16:52:07 -04:00