mirrors/FreeRDP
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
14,589 Commits 6 Branches 74 Tags 84 MiB
96bb569674
Commit Graph

2260 Commits

Author SHA1 Message Date
kubistika
faa833f97a rdpsnd: client: add rdpContext getter 2019-08-29 14:39:17 +02:00
Armin Novak
fdf1715213 Unified DriveStoreRedirect parsing. 2019-08-23 12:06:21 +02:00
Armin Novak
935ed36e68 Add dynamicDrives hotplug option. 2019-08-23 10:27:01 +02:00
Armin Novak
52af56d956 Added rdpsnd latency calculation. 2019-08-22 10:11:26 +02:00
Kyle Evans
d796920f8f (FreeBSD) Build fixes for urbdrc 2019-08-19 16:57:56 +02:00
Armin Novak
c1d98d7e0a Proper parsing of clipboard capability sets. 2019-08-19 09:30:40 +02:00
Armin Novak
74cffef053 Clipboard server callback arguments const 2019-08-19 09:30:40 +02:00
kubistika
f429275f86 channels: cliprdr: server: add autoInitializationSequence 2019-08-19 09:30:40 +02:00
kubistika
cf474bdb74 channels: cliprdr: server: call ClientCapabilities callback 2019-08-19 09:30:40 +02:00
kubistika
6cebbc2a16 channels: cliprdr: add lastRequestedFormatId 
This one is for proxy use. The proxy must know what format is requested by the other side
of the connection, for determining if the message should be passed
or ignore (for example, if we want to allow only text, the proxy must
verify that the requested format received in Format Data Request PDU is
a text format.
 2019-08-19 09:30:40 +02:00
Martin Fleisz
30c0127a29
Merge pull request #5510 from akallabeth/mac_realtime_sound 
Mac realtime sound
 2019-08-14 12:54:54 +02:00
Armin Novak
18e4245791 Added proper latency estimation for winmm sound backend. 2019-08-13 10:55:12 +02:00
Armin Novak
23069d1fe2 Convert input PCM to float format. 2019-08-12 08:13:43 +02:00
Armin Novak
5ffe2eed4e Mostly working AVAudio backend. 2019-08-02 14:00:32 +02:00
Bernhard Miklautz
a311075202 fix [channels/smartcard]: fix StatusW_Call 
According to 2.2.2.18 Status_Call cbAtrLen is unused an must be ignored
upon receipt.
 2019-07-30 09:48:47 +02:00
Martin Fleisz
445764100b
Merge pull request #5396 from widgetii/master 
Artur Zaprzala's rdp2tcp channel driver
 2019-07-09 16:17:29 +02:00
Martin Fleisz
b80a26f82c rail: Fixes incorrect setting of TS_RAIL_EXEC_FLAG_FILE 
The TS_RAIL_EXEC_FLAG should only be set if ExeOrFile refers to a file
path. If we don't supply a published app name (using ||) but the name of
an application (i.e. notepad.exe) this flag was incorrectly set causing
an remote app execution error (error 5 - file not found).
 2019-07-09 08:21:45 +02:00
Dmitry Ilyin
cb235debf5 PR fixes 2019-06-25 11:52:22 +03:00
Armin Novak
14c99ac061 Patch from #5436: fix input handling with gstreamer and vaapisink 2019-06-18 13:43:44 +02:00
David Fort
2da425aa03
Merge pull request #5424 from kubistika/rdpgfx 
rdpgfx: CacheImportOffer implementation
 2019-06-13 11:35:15 +02:00
Kobi
d9366df448 RDPEDISP server side implementation (#5414) 
* libfreerdp: Add RDPEDISP server implementation

* server/proxy: Add RDPEDISP support
 2019-06-11 16:13:42 +02:00
kubistika
bf618fb929 rdpgfx/client: Update gfx->UnacknowlegedFrame correctly 2019-06-06 10:24:27 +03:00
kubistika
49e7c5ddc0 rdpgfx/server: Fix formatting: rdpgfx_recv_cache_import_offer_pdu 2019-06-06 07:53:34 +03:00
kubistika
bf97d3e041 rdpgfx/client: Expose QoeFrameAck 2019-06-06 07:53:34 +03:00
kubistika
98e09af2ff rdpgfx/client: Implement CacheImportOffer PDU 2019-06-06 07:53:34 +03:00
kubistika
e2eeb9f870 rdpgfx: Add WITH_DEBUG_RDPGFX option 2019-06-04 10:29:05 +03:00
Idan Freiberg
2ee8b2cbbd channels: ssh-agnet: cmake: turn off server side channel by default in ChannelsOptions.cmake (#5420) 
CMake v3.5.1 throws the following error if this is not set:
```
CMake Error at channels/CMakeLists.txt:48 (if):
  if given arguments:

    "OFF" "OR"

  Unknown arguments specified
Call Stack (most recent call first):
  channels/sshagent/ChannelOptions.cmake:6 (define_channel_options)
  channels/CMakeLists.txt:273 (include)
```
 2019-06-03 09:47:35 +02:00
David Fort
6563bc28c4 rail: added verbose logs (#5402) 
* rail: added verbose logs

* rail: fix buffer initialisation in debug message
 2019-05-23 12:15:26 +02:00
Dmitry Ilyin
c537b1749c format after VS2010 2019-05-15 22:41:25 +03:00
Dmitry Ilyin
39bd28bcb8 VS2010 adaptation 2019-05-15 20:33:35 +01:00
Dmitry Ilyin
eee7d4b783 proper code format 2019-05-15 20:12:33 +03:00
Armin Novak
8666d7e59b Fixed mapping of new client sysparam values. 2019-05-15 15:25:04 +02:00
Dmitry Ilyin
f6c0c7ba7c fix for loop for ancient compilers 2019-05-14 21:44:33 +03:00
Dmitry Ilyin
2cfb2839f4 Artur Zaprzala's rdp2tcp channel driver 2019-05-14 21:04:39 +03:00
Martin Fleisz
ccd1fc71e9
Merge pull request #5327 from akallabeth/sign_compare_fixes_v3 
Leak and warning fixes for 2.0
 2019-05-09 13:21:36 +02:00
Martin Fleisz
6633e01891
Merge pull request #5392 from akallabeth/gfx_avc_flag_fixes 
Fixed GFX flags and CapsConfirm return checks
 2019-05-09 13:16:08 +02:00
Armin Novak
f22b77d49c Fixed GFX flags and CapsConfirm return checks 2019-05-09 12:46:10 +02:00
Armin Novak
a2834ae233 Fixed rails set_caretwidth 2019-05-09 12:28:27 +02:00
Armin Novak
2cc714a57d Updated RAILS implementation 
* Implement new messages and callbacks
* Announce most recent channel features
* Added settings to configure flags to announce
 2019-05-08 17:25:15 +02:00
Armin Novak
60a82854c1 For smartcard trace functions use const arguments 2019-05-08 15:13:03 +02:00
Armin Novak
4b72a85e91 Fixed possible memory leak. 2019-05-08 15:12:40 +02:00
Armin Novak
ea421ed52e Fixed index data type 2019-05-08 15:12:40 +02:00
Martin Fleisz
50566c2171
Merge pull request #5385 from akallabeth/some_unused_parameter_silenced 
Some unused parameter silenced
 2019-05-08 14:16:05 +02:00
Armin Novak
8f7e1579fd Silenced unused parameter warnings in smartcard trace 2019-05-08 12:27:51 +02:00
Armin Novak
48a12ae131 Fixed memory leak and return values in rdpgfx_recv_caps_advertise_pdu 2019-05-08 12:05:58 +02:00
Armin Novak
7b2608a938 Added gfx capability filter option. 
With this new option it is possible to selectively disable certain
GFX capability versions. This way buggy behaviour can be addressed
at runtime.
 2019-05-08 11:43:22 +02:00
Armin Novak
1bb933b991 Fixed missing argument checks. 
The arguments for rdpgfx_send_frame_acknowledge_pdu must be checked
as in some call stacks they might be NULL.
 2019-05-07 13:46:24 +02:00
Armin Novak
3b7e46fb0e Updated GFX to 10.6 spec 2019-05-07 12:10:13 +02:00
akallabeth
95b8b43d4d
Merge pull request #5376 from kubistika/bugfix/rdpgfx-server-v10.6-PDUs 
rdpgfx: Fix GFX v10.6 PDUs parsing and naming according to the spec
 2019-05-06 15:32:32 +02:00
akallabeth
314fcee41e
Merge pull request #5377 from m4ntis/gfx/fix-caps-confirm-recv 
client/rdgpfx_main.c: Fix rdpgfx_recv_caps_confirm_pdu caps length read
 2019-05-06 12:51:23 +02:00
Mati Shabtay
2048708235 client/rdpgfx_main.h: Formatting 2019-05-05 16:27:11 +03:00
Armin Novak
841cb70f91 Fixed const correctness of gfx function pointer 
Signed-off-by: Mati Shabtay <matishabtay@gmail.com>
 2019-05-05 16:17:15 +03:00
Mati Shabtay
eee234c239 rdpgfx/client: Add callbacks for manual caps sending and frame acking 2019-05-05 15:56:35 +03:00
Mati Shabtay
e9dfe13a70 client/rdgpfx_main.c: Fix rdpgfx_recv_caps_confirm_pdu caps length read 2019-05-05 13:39:04 +03:00
kubistika
e9faaedc85 rdpgfx: Fix GFX v10.6 PDUs parsing and naming according to the spec 2019-05-05 12:34:57 +03:00
r-barnett
40ef08ddc5 Fix smartcard segfault when no devices are present (#5364) 
* Don't assume smartcard reader list is not empty.

* Check status of retrieval of smartcard device list before trying to filter it

* style fixes
 2019-05-02 06:11:57 +02:00
Martin Fleisz
25fc56a625
Merge pull request #5260 from akallabeth/rail_spec_update 
Rail spec update
 2019-04-29 11:27:26 +02:00
Martin Fleisz
6eb108058e
Merge pull request #5306 from akallabeth/gfx_server_caps_input_checks 
Fixed input stream length checks in rdpgfx_recv_caps_advertise_pdu
 2019-04-29 11:27:06 +02:00
Armin Novak
5e42c8943d Fixed typo in RAIL_ZORDER_SYNC 2019-04-26 13:14:30 +02:00
Armin Novak
8af9c138e3 Fixed input stream length checks in rdpgfx_recv_caps_advertise_pdu 2019-04-26 13:11:46 +02:00
Pascal J. Bourguignon
431c37f3a9 5360 segfault using smartcard without any readers (#5361) 
* Fix: corrected test for astyle.

* Fix: added test for NULL readers returned by ConvertFromUnicode.
 2019-04-26 09:10:41 +02:00
Mati Shabtay
e1ef302a8d rail_orders.c: Fix wrong callback call on server handshake ex recv (#5345) 2019-04-25 10:55:24 +02:00
David Fort
7ae72ee512
Merge pull request #5240 from akallabeth/sign_compare_fixes_v2 
Sign compare fixes v2
 2019-04-05 14:13:03 +02:00
Mati Shabtay
6e8c02c9ee Added optional PreFrameAck callback to RdpgfxClientContext (#5303) 
* RdpgfxClientContext: Add PreFrameAck callback

* client/rdpgfx_main.c: Call PreFrameAck callback before acking frame

* client/rdpgfx_main.c: Fix windows_msbuild_vs2010 CI build

* client/rdpgfx_main.c: Fix error logs log level
 2019-04-05 13:37:51 +02:00
Armin Novak
9218712ecf Remove unnecessary clipboard data copy. 2019-04-05 10:04:36 +02:00
David Fort
e0d60a0310 clipboard: correctly handle flags during renegociatiion (#5323) 2019-04-05 09:36:53 +02:00
Armin Novak
624d895106 Fixed sign issues 2019-04-05 09:22:35 +02:00
Armin Novak
27d2a9e040 Fixed unused argument warnings. 2019-04-05 09:14:35 +02:00
Armin Novak
5612cbd8e6 Fixed dead store warnings 2019-04-05 09:14:35 +02:00
Armin Novak
6c9130f7d6 Fixed sign-compare warnings. 2019-04-05 09:14:35 +02:00
Armin Novak
4360033405 Fixed const free warning. 2019-04-05 09:13:24 +02:00
Armin Novak
426137a7f0 Fixed sign-compare warnings 2019-04-05 09:13:24 +02:00
Armin Novak
93ad9a2092 Fixed sign-compare warnings 2019-04-05 09:13:24 +02:00
Armin Novak
3eb3ad3cab Fixed sign-compare warnings 2019-04-05 09:13:24 +02:00
Armin Novak
856252a62f Fixed sign-compare warnings 2019-04-05 09:13:24 +02:00
Armin Novak
b9b3f3eda7 Fixed sign-compare warnings 2019-04-05 09:13:24 +02:00
Armin Novak
116383897e Fixed sign-compare warnings 2019-04-05 09:13:24 +02:00
Armin Novak
4430187e8d Fixed sign-compare warnings 2019-04-05 09:13:24 +02:00
Armin Novak
52b03cd408 Addin function pointers now expect const strings 2019-04-05 09:13:24 +02:00
David Fort
37358e81d0
Merge pull request #5285 from akallabeth/urbdrc_preparations 
Channel, log debug and semaphore related fixes
 2019-04-04 18:21:47 +02:00
David Fort
39f7486211
Merge pull request #5318 from akallabeth/filetime_fix 
Fix #5317: Change file attributes before modifying file time.
 2019-04-04 18:06:22 +02:00
David Fort
058ae0db57
Merge pull request #5273 from akallabeth/mac_compile_warning_fix 
Fixed mac compilation warnings.
 2019-04-04 18:03:50 +02:00
Armin Novak
485061e4d0 Fix #5317: Change file attributes before modifying file time. 2019-03-29 15:45:52 +01:00
Mati Shabtay
5d808226af client/rdpgfx_main.c: Fix wire to surface 2 pixel format decode 2019-03-18 16:07:18 +02:00
Mati Shabtay
88b7859c87 server/rdpgfx_main.c: Fixed caps advertise PDU recv (#5304) 2019-03-15 08:37:35 +01:00
Armin Novak
11cefecb7b Temporarily disable GFX version >= 10.3 2019-03-04 09:07:27 +01:00
Armin Novak
9be2324be8 Disabled RDPGFX_CAPVERSION_106 for good. 2019-02-28 13:43:11 +01:00
Armin Novak
69e9571d9e Fixed EGFX capability parsing, respect length fields. 
Disable RDPGFX_CAPVERSION_106 as we currently do not support scaled
outputs.
 2019-02-27 17:15:43 +01:00
Armin Novak
e8c8e7b6d0 Updated EGFX support to 10.6 2019-02-27 16:36:15 +01:00
Armin Novak
0bba166020 Force close channel, use defines instead of magic numbers 
* When senging a close request for a dynamic channel close the channel
  immediately. A response from the server is not guaranteed.
* Use the *_PDU defines instead of magic numbers when creating
  dynamic channel messages.
 2019-02-26 15:29:30 +01:00
Armin Novak
9566ae0e90 Fixed mac compilation warnings. 2019-02-21 17:30:12 +01:00
Armin Novak
3680d9f7d2 Fixed cast warnings from freerdp_load_channel_addin_entry 2019-02-21 13:54:25 +01:00
Armin Novak
37ed4bffd0 Fixed conversion warnings. 
Range checks and type casts to remove all warnings in printer channel.
 2019-02-21 11:43:59 +01:00
Armin Novak
aacf5bddc4 Updated rail channel, supporting all new messages. 2019-02-19 15:04:11 +01:00
Armin Novak
5904cad1f7 Replaced hardcoded xfreerdp program name 2019-02-12 10:53:30 +01:00
Martin Fleisz
22e666d2d0
Merge pull request #5225 from akallabeth/rdprd_caps_read_fix 
Fixed size checks when reading rdpdr capabilities.
 2019-02-08 09:05:27 +01:00
Bernhard Miklautz
162a69b0f0
Merge pull request #5139 from akallabeth/drive_hotplug_shutdown_crash_fix 
Fixed crash on drive hotplug shutdown.
 2019-02-07 10:08:41 +01:00
Armin Novak
ef1728faf5 Fixed NULL dereferences and uninitialized values 2019-01-30 16:11:10 +01:00
Armin Novak
0d3c1d4aab Fixed rect assignment in geometry channel. 2019-01-30 13:46:59 +01:00
Armin Novak
79416f5d32 Fixed missing initializers 2019-01-29 17:48:49 +01:00
Armin Novak
2e5fd8d16b Fixed clang analyzer false positive memory leaks. 
Added a justification for each #ifndef __clang_analyzer__
 2019-01-29 17:17:30 +01:00
Armin Novak
d5720b7999 Fixed clang scanbuild false positive memory leak. 
The memset did confuse the analyzer. Remove it as the variable
is already initialized to zero.
 2019-01-29 17:17:24 +01:00
Armin Novak
0dae6933ce Fixed uninitialized return value. 2019-01-29 16:53:30 +01:00
Armin Novak
51039f6535 Fixed compiler warnings #5210 2019-01-29 16:15:23 +01:00
David Fort
70805402be
Merge pull request #5140 from akallabeth/print_custom_component 
Added callback to handle printer custom components in printer backend.
 2019-01-29 15:18:53 +01:00
Armin Novak
dd9814df84 Fixed review remarks. 2019-01-29 14:21:58 +01:00
Armin Novak
711c726222 Fixed static analyzer warnings for dynamic channel. 2019-01-29 12:07:05 +01:00
Armin Novak
17bfa1c0d1 Added missing data range checks for geometry channel. 2019-01-29 11:57:24 +01:00
Armin Novak
8b7da77f36 Fixed size checks when reading rdpdr capabilities. 2019-01-29 11:50:27 +01:00
akallabeth
0a8ebcfcac
Merge pull request #5187 from astrand/mingw-part1 
Mingw build fixes part1
 2019-01-29 10:46:21 +01:00
Armin Novak
4ba73e0c73 Fixed warnings found by compiler and static analysis. 2019-01-24 11:53:52 +01:00
Armin Novak
65812bdbc0 Clipboard data pointer arguments are now const. 2019-01-23 16:55:13 +01:00
Vic Lee
e2df67ab34 rdpsnd/winmm: remove an unnecessary blocking event. 2019-01-18 17:51:14 +08:00
Armin Novak
805741bdf6 Fixed #5185 broken file size initialization. 2019-01-14 14:54:33 +01:00
Peter Åstrand (astrand)
30cd1ba1ab Use lowercase for includes and libs 
Makes build possible on case sensitive systems such as MinGW on Linux.
 2019-01-09 09:36:28 +01:00
Martin Fleisz
aa442de059
Merge pull request #5174 from chipitsine/master 
resolve several issues found by cppcheck
 2019-01-07 15:21:46 +01:00
Ilya Shipitsin
05462d27fb remove identical code, found by coverity 2019-01-04 20:56:57 +05:00
Ilya Shipitsin
bdc039e719 resolve several issues found by cppcheck 
[client/X11/xf_floatbar.c:800] -> [client/X11/xf_floatbar.c:796]: (warning) Either the condition '!floatbar' is redundant or there is possible null pointer dereference: floatbar.
[client/X11/xf_floatbar.c:800] -> [client/X11/xf_floatbar.c:797]: (warning) Either the condition '!floatbar' is redundant or there is possible null pointer dereference: floatbar.
[client/X11/xf_floatbar.c:800] -> [client/X11/xf_floatbar.c:798]: (warning) Either the condition '!floatbar' is redundant or there is possible null pointer dereference: floatbar.
[libfreerdp/codec/dsp.c:1156] -> [libfreerdp/codec/dsp.c:1154]: (warning) Either the condition '!srcFormat' is redundant or there is possible null pointer dereference: srcFormat.
[channels/drdynvc/client/drdynvc_main.c:1453] -> [channels/drdynvc/client/drdynvc_main.c:1450]: (warning) Either the condition '!drdynvc' is redundant or there is possible null pointer dereference: drdynvc.
[channels/audin/client/opensles/audin_opensl_es.c:98] -> [channels/audin/client/opensles/audin_opensl_es.c:94]: (warning) Either the condition '!opensles' is redundant or there is possible null pointer dereference: opensles.
[channels/audin/client/opensles/audin_opensl_es.c:159] -> [channels/audin/client/opensles/audin_opensl_es.c:153]: (warning) Either the condition '!opensles' is redundant or there is possible null pointer dereference: opensles.
 2019-01-02 20:35:24 +05:00
Bernhard Miklautz
9f6abd2701 fix [channels]: remove sshagent server side 
The server side channel wasn't tested and does not work this way with
FreeRDP. Rely on the server side channel that come with the RDP
server(s).
 2018-12-13 10:17:46 +01:00
Armin Novak
34c9404c98 Added OpenSSL include path globally. 2018-12-12 15:41:29 +01:00
Armin Novak
31d5a3b0c3 Don't reset configuration and driver name when supplied via command line. 2018-12-12 14:42:50 +01:00
Armin Novak
d13bd66f5a Implemented printer name based backend to remember settings. 2018-12-12 14:36:18 +01:00
Armin Novak
192680a001 Added callback to handle printer custom components in printer backend. 2018-12-12 10:57:53 +01:00
Armin Novak
598ece4ae7 Fixed crash on drive hotplug shutdown. 2018-12-12 09:32:09 +01:00
Bernhard Miklautz
2fe1c786c4
Merge pull request #5075 from akallabeth/clipboard_channel_cleanup 
Fixed clipboard channel cleanup.
 2018-12-11 09:12:24 +00:00
Armin Novak
fdf9ca3273 Fixed #5113: The timestamps for FileFullDirectoryInformation were inverted. 2018-12-07 10:59:52 +01:00
Armin Novak
81a0cd7010 Fixed clipboard channel cleanup. 2018-11-28 11:40:57 +01:00
Armin Novak
6c02a1c7d8 Fixed version check for remote assistance channel. 2018-11-22 11:11:31 +01:00
Armin Novak
6de2129a90 assistance v2 support 2018-11-22 11:11:31 +01:00
Bernhard Miklautz
010e3485cb
Merge pull request #4989 from akallabeth/dsp_encode_resample 
Added resampling to freerdp_dsp_encode.
 2018-11-15 15:54:56 +00:00
Bernhard Miklautz
d915491717
Merge pull request #5012 from akallabeth/rail_app_icons 
Rail app icons
 2018-11-15 08:50:56 +00:00
Armin Novak
5490ceb4ed Fixed source format for freerdp_dsp_encode in rdpsnd_server_send_wave_pdu 2018-11-14 13:27:20 +01:00
Armin Novak
0f45a570fa Added fallback for supported sample rates if original not supported. 
Added format compatibility check between recording input and destination.
 2018-11-14 13:27:20 +01:00
Armin Novak
93eea24120 Fixed possible NULL pointer dereference 2018-11-14 13:27:20 +01:00
Armin Novak
83f959ce6b Fixed format issues with server sound channel (review by @llysz) 2018-11-14 13:27:20 +01:00
Bernhard Miklautz
e980d20e8e
Merge pull request #4973 from Devolutions/fix_drive_redirection 
Allow fixed drive redirection (Windows) and fix macos drive duplication.
 2018-11-14 11:57:13 +00:00
Armin Novak
e500abc092 Fixed rail_string_to_unicode_string size calculation. 2018-11-14 11:03:59 +01:00
Jonathan Lafontaine
35d7a1e38d Allow fixed drive redirection on Windows (a:, c:, ...) and fix macos drive duplication. 2018-10-29 10:17:42 -04:00
Armin Novak
7aebf8ebd2 Silence code analyzers, check correct variable for NULL. 2018-10-25 13:19:45 +02:00
Norbert Federa
af992f4ce1 channels/client: fix alsa/pulse warning and checks 
- pa_stream_writable_size() returns (size_t) -1 on error
- fix missing cast in alsa client sound channel code
 2018-10-23 09:45:20 +02:00
Armin Novak
fe7a37dcbd Cleaned up resource cleanup for rdpsnd alsa backend. 2018-10-22 14:53:46 +02:00
Armin Novak
3ed50aaca2 Implemented rdpsnd_pulse_get_volume 2018-10-22 13:17:25 +02:00
Armin Novak
9ff17dc0f4 fixed return value check in rdpsnd_recv_volume_pdu 2018-10-22 12:27:19 +02:00
Armin Novak
e2e1071ff5 Seal length in wave pdu alignment. 2018-10-22 12:16:18 +02:00
Armin Novak
1a015612a6 Align wave pdu size 2018-10-22 12:00:07 +02:00
Armin Novak
fb76f88cac Added missing length check and log message information. 2018-10-22 11:59:42 +02:00
Armin Novak
3d49697d19 Improved debug logging for sound device handling. 2018-10-22 10:27:16 +02:00
Armin Novak
ff7e91fed0 Removed unnecessary pulse context check. 2018-10-22 10:18:17 +02:00
Armin Novak
03dcfaf8db Unified sound device reopen in a single function. 2018-10-22 10:04:02 +02:00
Norbert Federa
0572572eb9 fix issue with fnObjectFree and related casts 
- remove unnecessary/dangerous OBJECT_xxx function-style casts
- fix -Wstrict-prototypes issue with OBJECT_NEW_FN definition
 2018-10-19 11:30:01 +02:00
Norbert Federa
d35470f8af rdpsnd: always call rdpsnd_server_send_formats 
Since the rdpsnd_server_send_formats function is no longer exported
we must always call it, even if the rdpsnd server application uses
its own thread.
 2018-10-18 10:21:15 +02:00
Armin Novak
3920c570dd Fixed memory leak with audio formats. 2018-10-15 16:33:56 +02:00
Martin Fleisz
00af869cd3
Merge pull request #4889 from akallabeth/shadow_server_audin_refactor 
Shadow server audin refactor
 2018-10-08 12:56:09 +02:00
Martin Fleisz
ea5a0adfcf
Merge pull request #4913 from akallabeth/audin_opensles 
Fixed audio recording with opensles.
 2018-10-08 10:13:51 +02:00
Armin Novak
ac14763564 [audin] Abort version exchange if server version is not supported. 2018-10-04 13:53:18 +02:00
Armin Novak
47f8804073 Fixed audio recording with opensles. 2018-10-04 13:18:06 +02:00
Armin Novak
a8a6accc15 Fixed compiler warnings. 2018-10-03 15:16:59 +02:00
Armin Novak
2cf0662559 Unified format support for rdpsnd. 2018-09-26 12:49:52 +02:00
Armin Novak
d56efaae8b Fixed server format selection. 2018-09-26 12:49:09 +02:00
Armin Novak
16531e1437 Fixed server audin callback, provide more information. 2018-09-26 12:49:09 +02:00
Armin Novak
a83c805ade Fixed format debug message. 2018-09-26 12:49:09 +02:00
Armin Novak
18f97d03e7 Cleaned up defaults. 2018-09-26 12:49:09 +02:00
Armin Novak
106dde9571 Working mic redirection for shadow server. 2018-09-26 12:49:09 +02:00
Armin Novak
28efbbc01f Refactored audio_format* functions. 2018-09-26 12:49:09 +02:00
Martin Fleisz
c3ec6d293b
Merge pull request #4862 from akallabeth/printer_warning_fix 
Fixed a warning in printer channel.
 2018-09-26 09:37:23 +02:00
Martin Fleisz
1d64a24647
Merge pull request #4888 from akallabeth/shadow_server_audin 
Added microphone support to shadow server.
 2018-09-25 14:38:09 +02:00
Armin Novak
dab5770fed Added microphone support to shadow server. 2018-09-25 11:14:10 +02:00
Armin Novak
93846c801a Allow empty rail strings. 2018-09-25 09:54:47 +02:00
David Fort
ba69925b8d
Merge pull request #4501 from akallabeth/drive_file_size_fix 
Removed xrdp workarounds.
 2018-09-24 16:00:27 +02:00
Armin Novak
baee520e3d Fix for #4866: Added additional length checks 2018-09-20 09:06:01 +02:00
Armin Novak
f63286dbea Fixed smartcard filter for empty arguments. 2018-09-19 11:13:02 +02:00
Armin Novak
a744378110 Fixed a warning in printer channel. 2018-09-18 14:45:25 +02:00
Martin Fleisz
5686a0f907
Merge pull request #4840 from akallabeth/smartcard_filter 
Added multi filter for smartcard. (based on #4837 by @informatimago)
 2018-09-17 09:08:32 +02:00
Armin Novak
5819946b84 Fixed rail unicode string conversion and const correctness. 2018-09-14 10:04:16 +02:00
Armin Novak
4596588e0f Set freed pointer to NULL avoiding double free. 2018-09-04 15:22:06 +02:00
Armin Novak
b2ce309b28 Added multi filter for smartcard. (based on #4837 by @informatimago) 2018-09-04 14:34:32 +02:00
Armin Novak
5bc3993e3f Fixed buffer size and function name 2018-08-27 14:34:42 +02:00
Armin Novak
fad20be6e6 Fixed missing includes. 2018-08-27 14:34:42 +02:00
Armin Novak
62c1696d4c Removed use of unchecked sprintf 2018-08-27 14:34:42 +02:00
Armin Novak
114abad767 Removed use of strcpy. 2018-08-27 14:34:09 +02:00
Armin Novak
d90e5da865 Fixed unused label warning. 2018-08-24 13:40:36 +02:00
Martin Fleisz
8248dcb3bb
Merge pull request #4816 from akallabeth/drive_cmd_fix 
Fix #4680: Return proper directory name.
 2018-08-24 09:45:26 +02:00
Armin Novak
ab18f8f222 Fix #4680: Return proper directory name. 2018-08-23 10:04:26 +02:00
Ondrej Holy
97f25e8ab4 channels/smartcard: Fix leak found by covscan 
leaked_storage: Variable "operation" going out of scope leaks the storage it points to.
 2018-08-22 13:35:43 +02:00
Ondrej Holy
3baa716706 channels/smartcard: Format code by astyle 
Run ./scripts/format_code.sh before the following changes.
 2018-08-22 13:35:43 +02:00
Ondrej Holy
ab7ab7a7ce channels/server: Silence false positive warnings from covscan 
Change the code a bit to silence false positive warnings from covscan.

leaked_storage: Ignoring storage allocated by "audin_server_context_new(NULL)" leaks it.
leaked_storage: Ignoring storage allocated by "rdpsnd_server_context_new(NULL)" leaks it.
leaked_storage: Ignoring storage allocated by "cliprdr_server_context_new(NULL)" leaks it.
leaked_storage: Ignoring storage allocated by "echo_server_context_new(NULL)" leaks it.
leaked_storage: Ignoring storage allocated by "rdpdr_server_context_new(NULL)" leaks it.
leaked_storage: Ignoring storage allocated by "drdynvc_server_context_new(NULL)" leaks it.
leaked_storage: Ignoring storage allocated by "rdpei_server_context_new(NULL)" leaks it.
leaked_storage: Ignoring storage allocated by "remdesk_server_context_new(NULL)" leaks it.
leaked_storage: Ignoring storage allocated by "encomsp_server_context_new(NULL)" leaks it.
leaked_storage: Ignoring storage allocated by "rdpgfx_server_context_new(NULL)" leaks it.
 2018-08-22 13:35:43 +02:00
Ondrej Holy
4ba3c46cd0 channels/server: Format code by astyle 
Run ./scripts/format_code.sh before the following changes.
 2018-08-22 13:35:43 +02:00
Ondrej Holy
170d5859d2 channels/serial: Fix leak found by covscan 
leaked_storage: Variable "ids" going out of scope leaks the storage it points to.
 2018-08-22 13:35:43 +02:00
Ondrej Holy
d3ab04d786 channels/remdesk: Fix leak found by covscan 
leaked_storage: Variable "pass" going out of scope leaks the storage it points to.
 2018-08-22 13:35:43 +02:00
Ondrej Holy
405c133381 channels/rdpgfx: Fix leak found by covscan 
leaked_storage: Variable "s" going out of scope leaks the storage it points to.
 2018-08-22 13:35:43 +02:00
Ondrej Holy
36a68b4eae channels/rdpgfx: Format code by astyle 
Run ./scripts/format_code.sh before the following changes.
 2018-08-22 13:35:43 +02:00
Ondrej Holy
1001807c5f channels/rdpdr: Prevent buffer overflow found by covscan 
buffer_size_warning: Calling strncpy with a maximum size argument of 256 bytes on destination array "irp->PathName" of size 256 bytes might leave the destination string unterminated.
buffer_size_warning: Calling strncpy with a maximum size argument of 256 bytes on destination array "irp->ExtraBuffer" of size 256 bytes might leave the destination string unterminated.
 2018-08-22 13:35:43 +02:00
Ondrej Holy
472576e6e0 channels/rdpdr: Format code by astyle 
Run ./scripts/format_code.sh before the following changes.
 2018-08-22 13:35:43 +02:00
Ondrej Holy
10bddb9fd9 channels/rdpdr: Fix leak found by covscan 
leaked_storage: Variable "newbuf" going out of scope leaks the storage it points to.
leaked_storage: Variable "keys" going out of scope leaks the storage it points to.
leaked_storage: Variable "pKeys" going out of scope leaks the storage it points to.
leaked_storage: Variable "s" going out of scope leaks the storage it points to.
leaked_storage: Variable "computerNameW" going out of scope leaks the storage it points to.
leaked_storage: Variable "s" going out of scope leaks the storage it points to.
 2018-08-22 13:35:43 +02:00
Ondrej Holy
865ee84ab5 channels/rail: Fix leak found by covscan 
leaked_storage: Variable "s" going out of scope leaks the storage it points to.
 2018-08-22 13:35:43 +02:00
Ondrej Holy
4b8f2d5137 channels/drive: Fix leak found by covscan 
leaked_storage: Variable "outStr" going out of scope leaks the storage it points to.
 2018-08-22 13:35:43 +02:00
Ondrej Holy
7b740f152f channels/addin: Fix leak found by covscan 
leaked_handle: Handle variable "hFind" going out of scope leaks the handle.
 2018-08-22 13:35:43 +02:00
Ondrej Holy
926ac4f938 channels/audin: Fix leak found by covscan 
leaked_storage: Variable out going out of scope leaks the storage it points to.
 2018-08-22 13:35:43 +02:00
Armin Novak
dbd630a38c drive_file_query_information: Use GetFileAttributesExW 2018-08-13 13:40:59 +02:00
Armin Novak
98c254ffa0 Fixed invalid return value type. 2018-08-01 12:56:18 +02:00
Armin Novak
44d1438eac Fixed mac audin 2018-08-01 12:56:17 +02:00
MartinHaimberger
30626a5dc3
Merge pull request #4773 from akallabeth/drive_multi_fix 
Remember if drive was added by automout.
 2018-07-31 13:35:05 +02:00
Armin Novak
7355b4e5f3 Fixed leak in audio format processing. 2018-07-31 10:33:19 +02:00
MartinHaimberger
2d7499b7c0
Merge pull request #4758 from akallabeth/dsp_fix 
Audio/microphone fixes
 2018-07-31 10:22:22 +02:00
Armin Novak
adc0882f8d Removed obsolete winodws path hack. 2018-07-30 13:16:45 +02:00
Armin Novak
93fa8eb0d2 Fixed windows automount drive arguments. 2018-07-30 12:58:15 +02:00
Armin Novak
4035ed46c8 Added automount flag for windows and macos implementations. 2018-07-30 12:37:19 +02:00
Armin Novak
e8393a22e2 Remember if drive was added by automout. 2018-07-30 12:31:11 +02:00
Armin Novak
033abe93d4 Fixed callback parameter checks. 2018-07-30 11:22:11 +02:00
Armin Novak
3b187ef321 Code Cleanup 2018-07-19 16:21:03 +02:00
Martin Fleisz
b6a41b26e5 audin: Fix server-side dsp decoding 
The decoder format was never set and so dsp_decode always failed
on the server side.
 2018-07-19 16:00:31 +02:00
Armin Novak
d40daedb9c Fixed FFMPEG backend: Do not drop samples for package alignment. 2018-07-19 15:17:54 +02:00
Armin Novak
d7e88b1b81 Fixed winmm backend logging. 2018-07-19 11:55:48 +02:00
Armin Novak
a003890b34 Fixed opensles compilation errors. 2018-07-19 11:51:26 +02:00
Armin Novak
ec83f3d4f1 Fixed number of samples returned. 2018-07-18 12:33:52 +02:00
Armin Novak
7c8a556377 Fixed alignment issues. 2018-07-18 12:14:37 +02:00
Armin Novak
8664a3c91e Fixed alsa and pulse backend receive buffer sizes 2018-07-17 16:18:21 +02:00
Armin Novak
b9645c9247 Using dynamic logger again. 2018-07-17 11:20:45 +02:00
Martin Fleisz
0ec9579013 rdpsnd: Fix sending of wave2 PDU 
According to MS-RDPEA 2.2.3.10 the Wave2 PDU's header BodySize field
should be equal the size of the PDU minus the header (4 Bytes).
 2018-07-11 15:06:31 +02:00
Armin Novak
4465bcfa86 Fixed remarks 2018-07-04 11:03:32 +02:00
Armin Novak
bf70ee6267 Keep extra data of audio format locally cached. 2018-07-03 09:54:29 +02:00
Armin Novak
a554207c11 Added target dependencies. 2018-07-02 16:58:14 +02:00
Armin Novak
7cd25027ad Fixed empty lib. 2018-07-02 16:38:21 +02:00
Armin Novak
373bfac9ab Added support for WAVE2 PDU in server side audio channel. 2018-07-02 16:20:39 +02:00
Armin Novak
e44d10a3e0 Merge remote-tracking branch 'origin/pr/4701' into reconnect_fixes 2018-06-19 12:46:58 +02:00
Armin Novak
a716dc244c Removed duplicate resource free. 2018-06-18 10:23:57 +02:00
Pascal J. Bourguignon
15f2bafeab Cleaned up const char** -> char** for argv, since we definitely do modify the argv! 
(we overwrite the password and pin arguments).
This implies changes in the argument parsing tests that now must pass a mutable argv
(copied from the statically declared test argvs).
Some other const inconsistency have been dealt with too.
 2018-06-06 16:43:09 +02:00
David Fort
0255a7db15
Merge pull request #4654 from akallabeth/alsa_latency_patch 
Return real alsa latency if buffer is filled.
 2018-05-16 09:53:30 +02:00
Armin Novak
c078aee238 Return real alsa latency if buffer is filled. 2018-05-16 08:52:55 +02:00
Armin Novak
0cf4dcc016 Fix missing sound arrival time for wave2 PDU 2018-05-15 14:57:00 +02:00
Martin Fleisz
c4e8685a29
Merge pull request #4623 from akallabeth/mac_sound_backend_fix 
Fixed mac sound backend initialization.
 2018-05-04 13:08:45 +02:00
Armin Novak
87c19b30d0 Fixed uninitialized return and early resource cleanup. 2018-05-04 12:36:29 +02:00
Armin Novak
fb032f91b7 Fixed uninitialized value. 2018-05-04 12:36:18 +02:00
Armin Novak
670c1190c4 Fixed formats supported by backend. 2018-05-04 09:44:06 +02:00
Armin Novak
17d43edafb Fixed mac sound backend initialization. 2018-05-03 16:12:12 +02:00
David Fort
456b0e8934
Merge pull request #4453 from akallabeth/sound_channel_refactor 
Sound channel refactoring
 2018-05-03 11:56:58 +02:00
Armin Novak
066cb52caa Fixed treat_wave sample length and checks. 2018-05-03 10:08:56 +02:00
David Fort
8cba201999
Merge pull request #4548 from akallabeth/autoreconnect_fix 
Autoreconnect fix
 2018-04-27 09:39:30 +02:00
Ruben De Visscher
1835a39aaf Fix inconsistent cBytes value between WinScard and pcsc-lite. 2018-04-24 10:33:44 +02:00
Johannes Weberhofer
277fc1ca4b
Include geometry.h in video channel 
Fix for #4562
 2018-04-17 08:20:54 +02:00
Armin Novak
8758638c2a Ensure audin channel uses supported protocol version 1. 2018-04-16 10:23:45 +02:00
David Fort
d07d06b28c rdpsnd: add support for wave2 PDU in client (#2) 
To achieve this the announced version number is bumped to 8.
 2018-04-16 08:56:09 +02:00
Bernhard Miklautz
c0afb8bd6b
Merge pull request #4322 from akallabeth/rail_fixes 
Rail fixes for GFX mode
 2018-04-11 10:49:44 +02:00
Armin Novak
3606b66cc3 Fix rdpsnd channel detached handling. 
Do not play samples if detached, but handle every other message
just like with an attached channel.
 2018-04-11 08:48:29 +02:00
Armin Novak
82ad911ee5 Added fake rdpsnd backend. 2018-04-09 17:39:08 +02:00
Armin Novak
030e9fc12f Fixed channel duplicate disconnect handling 2018-04-09 11:27:54 +02:00
Armin Novak
6c7bfe892f Fixed channel duplicate disconnect handling 2018-04-09 11:27:01 +02:00
Armin Novak
357391bd93 Fixed channel duplicate disconnect handling 2018-04-09 11:26:43 +02:00
Armin Novak
1761a66b5e Fixed channel duplicate disconnect handling 2018-04-09 11:26:36 +02:00
Armin Novak
d784954bca Fixed channel duplicate disconnect handling 2018-04-09 11:26:31 +02:00
Armin Novak
973a4c30b8 Fixed channel duplicate disconnect handling 2018-04-09 11:26:26 +02:00
Armin Novak
75717411df Fixed channel duplicate disconnect handling 2018-04-09 11:26:21 +02:00
Armin Novak
3f712cab70 Fixed formatting of changed files. 2018-04-05 13:14:16 +02:00
Armin Novak
2e801a8425 Free dsp context on close. 2018-04-05 13:14:16 +02:00
Armin Novak
1c127fab7d Added AudioFormatFlags fallback. 2018-04-05 13:14:16 +02:00
Armin Novak
ec5dab973f Initialized ALSA backend format. 2018-04-05 13:14:16 +02:00
Armin Novak
65a82e9cdc Fix #4462: Fallback typedef for AudioFormatID on MacOS < 10.10 2018-04-05 13:14:16 +02:00
Armin Novak
f89c1857b9 Rewrite of sound and microphone channels 
The sound and microphone redirection channels (and in part TSMF)
did not properly decouple encoding/decoding from the backends used
to play/record sound.
Encapsulating encoding/decoding in rewritten freerdp_dsp_* functions
with variable backends, simplifying alsa/oss/pulse/... audio backends.
 2018-04-05 13:14:16 +02:00
MartinHaimberger
55973288f2
Merge pull request #4514 from akallabeth/com_lpt_fix 
Com lpt fix
 2018-04-04 12:52:39 +02:00
MartinHaimberger
08271709e4
Merge pull request #4416 from akallabeth/audin_fix 
Audin fix
 2018-04-04 10:04:58 +02:00
Armin Novak
e0d112d548 Removed all calls to WLog_Init and WLog_Uninit 
Since the calls are no longer required remove their usage.
 2018-04-03 13:06:41 +02:00
Armin Novak
0c49152a3d Fixed #4412: memory corruption in audin channel. 2018-03-26 16:29:50 +02:00
Armin Novak
c53d72211a Audin channel use dynamic logger where possible. 2018-03-26 14:40:23 +02:00
Ilya Shipitsin
14c15c680d resolve several possible null pointer dereference 
issue detected by cppcheck

[channels/drive/client/drive_main.c:454] -> [channels/drive/client/drive_main.c:443]: (warning) Either the condition '!irp' is redundant or there is possible null pointer dereference: irp.
[client/X11/xf_window.c:582] -> [client/X11/xf_window.c:580]: (warning) Either the condition '!xfc' is redundant or there is possible null pointer dereference: xfc.
[winpr/libwinpr/path/test/TestPathShell.c:40] -> [winpr/libwinpr/path/test/TestPathShell.c:43]: (warning) Either the condition '!path' is redundant or there is possible null pointer dereference: path.
[winpr/libwinpr/path/test/TestPathShell.c:49] -> [winpr/libwinpr/path/test/TestPathShell.c:52]: (warning) Either the condition '!path' is redundant or there is possible null pointer dereference: path.
 2018-03-24 17:46:39 +05:00
Armin Novak
a266147ddf Added debug message. 2018-03-23 11:21:13 +01:00
Armin Novak
d8e8bf8476 Removed xrdp workarounds. 
These workarounds limit functionality with other server implementations
and should be fixed in xrdp.
 2018-03-20 11:31:53 +01:00
Armin Novak
44eebbb6e0 Fixed compiler warnings. 2018-03-07 14:47:06 +01:00
Armin Novak
2517755d25 Fixed thread function return and parameters. 2018-03-07 14:36:55 +01:00
Martin Fleisz
2396e37d8a rdpei: Fix possible NULL ptr access 2018-03-06 16:35:56 +01:00
Martin Fleisz
9b4de7903f drive: Fix possible NULL ptr access 2018-03-06 16:34:36 +01:00
Martin Fleisz
ffa5fb07c2 drdynvc: Fix possible NULL pointer accesses 2018-03-06 16:03:13 +01:00
Armin Novak
6623927fe4 Free gsmBuffer on channel close. 2018-02-19 14:04:42 +01:00
Armin Novak
3b67190d17 Clean up GSM context on channel close. 2018-02-19 13:05:53 +01:00
Martin Fleisz
3c4385e1f1
Merge pull request #4440 from akallabeth/silence_unused_profiler 
Disable unused variable warning from profiler.
 2018-02-15 12:22:50 +01:00
Armin Novak
1a902c249c Fix PROFILER_* macros 
Add the semicolon to the macro to allow clean
undefinition if the profiler is not used.
This used to break VisualC compilers.
 2018-02-15 11:30:38 +01:00
Martin Fleisz
19a00f2099
Merge pull request #4325 from akallabeth/fixes_com 
Fixes serial redirection name check and SAM file parser
 2018-02-15 10:39:33 +01:00
Martin Fleisz
6283ce8a20
Merge pull request #4415 from akallabeth/drdynvc_dyn_log 
Prefer dynamic logger in dynamic channel.
 2018-02-15 10:06:05 +01:00
Armin Novak
77a9e2edfc Do not export internal variables. 2018-02-14 13:51:38 +01:00
David Fort
484abe0567 video: fix invalid geometry and invalid argument passing to time pubsub 2018-02-14 00:08:52 +01:00
Armin Novak
a6a57e3619 Prefer dynamic logger in dynamic channel. 2018-02-13 13:46:25 +01:00
Armin Novak
79d9ae8775 Fixed gemoetry mapping. 2018-02-13 10:52:53 +01:00
David Fort
73bef4ca23 video, geometry: fixed geometry handling 
It was not working when moving the video window.
 2018-02-13 10:52:53 +01:00
David Fort
b8e3b232de video: mutualize things in the common channel code 2018-02-13 10:52:53 +01:00
David Fort
73eb4ba77e drdynvc: fixed stream leak on error 2018-02-13 10:51:45 +01:00
David Fort
731ef4f8c0 geometry: drop server-side option for geometry 2018-02-13 10:51:45 +01:00
David Fort
4b240dad0e video+geometry: fixed leaks, a segfault and concurrent accesses 2018-02-13 10:51:07 +01:00
David Fort
a07efb73ec video: an implementation of MS-RDPEVOR for X11 
Implements the decoding of video streams using common H264 decoders. We also implement
a trivial feedback algorithm.

Sponsored by: Rangee GmbH (http://www.rangee.de)
 2018-02-13 10:51:07 +01:00
David Fort
b84839b21c video: a skeleton for MS-RDPEVOR client 
Basics for implementing the client side of the MS-RDPEVOR channel.

Sponsored by: Rangee GmbH (http://www.rangee.de)
 2018-02-13 10:51:07 +01:00
David Fort
adac409d1b geometry: change the channel API to mutualize things 
Try to mutualize things that are platform independant in the geometry client
channel.

Sponsored by: Rangee GmbH (http://www.rangee.de)
 2018-02-13 10:51:07 +01:00
Armin Novak
1ec1c9b7a3 Add dynamic channel queue object free function. 2018-02-09 11:04:31 +01:00
Armin Novak
25076cfce1 Fixed a memory leak. 2018-02-09 10:23:48 +01:00
Armin Novak
c586a300cf Fixed init once return. 2018-02-07 13:22:07 +01:00
David Fort
7ceb85c7a8
Merge pull request #4340 from akallabeth/init_once 
Fix remaining issues with #2006
 2018-02-07 10:34:18 +01:00
MartinHaimberger
5e7b94530e
Merge pull request #4387 from akallabeth/hotplug_fix 
Fixed #4384: Drive hotplug detection
 2018-02-07 10:32:05 +01:00
Armin Novak
92811ea5b5 Added return checks. 2018-02-02 10:41:20 +01:00
Armin Novak
3b70d1178b Added AVC444 chroma support to shadow server. 2018-02-02 10:39:33 +01:00
Armin Novak
64cfd750f9 Fixed #4384: Drive hotplug detection 2018-01-25 15:43:53 +01:00
Jukka-Pekka Virtanen
2e8f2c693d [MS-RDPESC] 2.2.2.18 Status_Call.cbAtrLen: Unused. MUST be ignored upon receipt. 
The [MS-RDPESC] clearly states in section 2.2.2.18 that Status_Call's
cbAtrLen must not be used when generating Status_Return response. This
is also how FreeRDP 1.1 behaves.
 2018-01-11 16:23:15 +02:00
Armin Novak
4dd0ccd703 Added argument checks. 2018-01-08 13:21:00 +01:00
Armin Novak
674fae5ce6 Refactored function visibility. 2018-01-08 13:17:49 +01:00
Armin Novak
899666ee1f Fixed #2006: Use InitOnceExecuteOnce 2018-01-08 12:41:32 +01:00
David Fort
e1cc601963
Merge pull request #4323 from akallabeth/scanbuild_fixes 
Scanbuild and other warnings fixed
 2018-01-08 11:16:21 +01:00
akallabeth
900ec855de
Merge pull request #4334 from h3xx/fix-ffmpeg-support 
Fix building against current ffmpeg
 2018-01-08 09:21:53 +01:00
Dan Church
ed571e74a5
Provide support for older versions of libavcodec 
My method was to find the LIBAVUTIL_VERSION_* at the commit where the
updated AV_ prefixed constants became available, add one "micro" version
to it, then if it's not at least that version, provide the unprefixed
constant. It just so happens that the same commit introduced all
the AV_* constants.
 2017-12-29 11:13:03 -06:00
Dan Church
78df32c77f
Fix future ffmpeg support 
The AV_ prefixed constants have been available since
ffmpeg@def97856de6021965db86c25a732d78689bd6bb0 (2015-07-07), or version
2.8.

The non-prefixed constants are set to be removed in the next ffmpeg
release, and were removed in
ffmpeg@302554835e39b79b977ed60c9afe81b44590dfef (2016-12-05).
 2017-12-28 09:41:45 -06:00
David Fort
191b8f950f Fix for #4330 
Since ec027bf dynamic resolution is broken when used with egfx. Before that commit
we were tracking a server sent resize by setting a DesktopResize callback. This callback
is called when the desktop is resized by the server. Anyway the problem was that when this
callback is called, the activation sequence is not always completed, which were leading to
some freeze with 2012r2 servers (sending packets before the sequence is finished).
So with the faulty commit, we are tracking server resizes by subscribing to the Actived
event, that is called at the end of a reactivation sequence, so we're sure to not send packets
when not fully activated.
Anyway the issue that shows on (#4330) is that when you use egfx, no reactivation sequence happens,
the server only sends a ResetGraphics message with the new size, and so we miss the resized event.
This fix introduces a new GraphicsReset event, makes the display channel subscribe to that event,
and react accordingly.
 2017-12-23 13:50:54 +01:00
David Fort
158840429d micro code style changes 2017-12-23 10:26:25 +01:00
Armin Novak
d823586c3e Fixed parallel channel argument checks 2017-12-21 15:16:24 +01:00
Armin Novak
bb7ba6ff26 Fixed smartcard related scanbuild warnings. 2017-12-21 10:53:36 +01:00
Armin Novak
6a21bdae3d Fixed various scanbuild warnings. 2017-12-21 09:34:35 +01:00
Martin Fleisz
80a49f46dc
Merge pull request #4320 from ondrejholy/coverity-fixes 
Coverity Scan fixes
 2017-12-20 14:17:20 +01:00
akallabeth
71fd6f3116
Merge pull request #4313 from hardening/dyn_res_update 
disp: implement dynamic resolution for X11
 2017-12-19 13:49:02 +01:00
Ondrej Holy
e2f9a08107 tsmf: Prevent string overflow and unterminated strings 
Device variable can overflow, or be unterminated. Replace strcpy
by strncpy and be sure that the string is terminated (sizeof() - 1).
 2017-12-19 12:21:34 +01:00
akallabeth
097f8edd97
Merge pull request #4312 from bmiklautz/smartcard-cleanup 
Smartcard fixes and cleanup
 2017-12-14 16:56:29 +01:00
Bernhard Miklautz
36c6478627 fix client/smartcard: indentation and return value 
Integrate feedback from pull request review.
 2017-12-14 16:21:19 +01:00
Bernhard Miklautz
5a1c0081c5 fix smartcard: SCardStatus unicode handling 
* fix StatusW_Call to rely and use SCardStatusW
* fix trace call in  StatusW_Call - needs to be called after the sizes
  are set
* unify SCardStatus functions for pcsc - let the internal function handle unicode directly

This fixes an issue with size calculations of SCardStatusW.
 2017-12-14 15:46:14 +01:00
David Fort
80dab90f1a disp: implement dynamic resolution for X11 
If the display channel is available we use it to allow the user to resize the
xfreerdp window. When the window is resized we announce a new monitor layout and
the server reacts by doing a reactivation sequence to the new size.
The minimum window size is limited to 300x300 as 2012 servers crash horribly
if we send them a smaller layout.
 2017-12-14 15:13:11 +01:00
Martin Fleisz
5cec90c781
Merge pull request #4305 from hardening/xrandr_fix 
Fix XRandr for old systems and MacOSX
 2017-12-13 17:24:41 +01:00
Bernhard Miklautz
94b35cb4f7 fix channel/smartcard: leak in Connect[AW] 
smartcard_Connect[AW] leaked the reader buffer in error case.
 2017-12-13 17:04:06 +01:00
Bernhard Miklautz
9fc754170b fix channel/smartcard: SCardStatus 
Add support for fmszReaderNamesIsNULL. Formating of the touched files
was also updated.
 2017-12-13 17:04:06 +01:00
Bernhard Miklautz
bc8bdc3e54 fix channel/smartcard: compiler warnings 
* remove unused variables
* remove unused jump label
 2017-12-13 17:04:06 +01:00
Bernhard Miklautz
e3d45c4580 fix channel/smartcard: remove SCardAddReaderName 
SCardAddReaderName isn't part of the SCard API.

Note: removing this also removes the possibility to redirect single
smartcard readers with /smartcard:READERNAME. However this features
wasn't implemented in a general way and will be re-added as part of
the smart card channel directly.
 2017-12-13 17:04:06 +01:00
Bernhard Miklautz
1e6fea7fa7 fix channel/smartcard: simplify channel variables 
Path was not really used and name was duplicated. Use the device->Name
directly.
 2017-12-13 17:04:06 +01:00
Bernhard Miklautz
f8a3e7acd4 fix channel/smartcard: GetStatusChange return code 
In case SCardGetStatusChange returned an error the call didn't return
any data but STATUS_NO_MEMORY as the calloc failed. This caused problems
with multiple applications server side (hangs and incorrect behavior).

Now the case when no readers are returned is handed correctly and the
data is also filled and send if the call fails.
 2017-12-13 17:04:06 +01:00
Bernhard Miklautz
46a7538322 fix channel/smartcard: async request handling 
The smart card channel tried to mimic mstsc's behavior on if an IRP was
processed synchronously or asynchronously. As the channel uses one thread per
context it could happen, especially with PCSC, that the main
channel thread was blocked waiting for an smart card operation to
complete. To prevent that behavior only call known safe functions in the
main thread (like CreateContext) and call the rest asynchronously.

For example the channel would block if a ListReaders is invoked on
the same context where a GetStatusChange (infinite timeout)
was already pending. Only when a status change happened the channel
would continue.

Note: Due to the one context per thread design it's important that
cancel isn't queued an alway run synchronously. Otherwise a specific
context might lock.
 2017-12-13 17:04:06 +01:00
Bernhard Miklautz
3dc4e283db fix channel/smartcard: return value handling 
Device control calls always returned SCARD_S_SUCCESS even if an error
occurred. This caused server side software (including the card manager)
to behave incorrectly.
 2017-12-13 17:04:06 +01:00
Bernhard Miklautz
99c69cde27 fix channel/smartcard: error handling 
According to MS-RDPESC the smart card channel must set the IoStatus to
an NTSTATUS in case a encoding or decoding error happens. The smart card
channel did this correctly but the output stream was modified
incorrectly causing the smart card remote manager to stop in error
cases.
 2017-12-13 17:04:06 +01:00
Martin Fleisz
6aa914363a
Merge pull request #4301 from hardening/geometry 
geometry: a skeleton for the MS-RDPEGT channel
 2017-12-13 09:09:33 +01:00
David Fort
3b670703fb
Merge pull request #4277 from akallabeth/mac_server 
Mac fixes
 2017-12-12 10:40:14 +01:00
David Fort
41823080f9 Fix users of Stream_GetPosition() that returns size_t 2017-12-11 22:38:58 +01:00
David Fort
a6cfd3c49a geometry: a skeleton for the MS-RDPEGT channel 
The base for implementing the MS-RDPEGT client channel that allows to track window
geometry.
 2017-12-08 11:26:29 +01:00
David Fort
1e48405d19 drdynvc: fix invalid check 
There were a copy'n paste error in the check of a malloc.
 2017-12-01 14:20:24 +01:00
David Fort
e73da4a656 display control channel: add a callback called when we receive capabilities 
We need a signal to know when the channel is ready and it's safe to send the
monitor layouts.
 2017-12-01 14:19:39 +01:00
Armin Novak
f96a46acd5 Fix #4278: Fix nasty range check bug 2017-11-26 14:59:37 +01:00
Armin Novak
57958cb178 Fixed #3810: Renamed color functions 2017-11-24 13:21:43 +01:00
David Fort
a5af2cc865 clipboard: add some checks for the message 2017-11-23 17:37:55 +01:00
Armin Novak
feda4e07df Removed linux specific include. 2017-11-20 11:46:09 +01:00
Martin Fleisz
4ff1251488
Merge pull request #4236 from akallabeth/scan_fix_remastered 
Scanbuild warning fixes
 2017-11-17 13:02:46 +01:00
Armin Novak
4ab26a334a Fixed resource cleanup. 2017-11-15 15:56:25 +01:00
Armin Novak
77134d9def Fixed formatting. 2017-11-15 15:56:25 +01:00
Armin Novak
f39346ebe5 Fixed leaks and formatting. 2017-11-15 15:56:25 +01:00
Armin Novak
9859cfb736 Fixed dead store. 2017-11-15 15:54:38 +01:00
Armin Novak
4eb5b8e349 Replaced atoi 2017-11-15 15:52:16 +01:00
Ben Cohen
8d54945b96 Remove underscores from define in sshagent_main.h 2017-11-10 20:16:00 +00:00
Ben Cohen
6093ec62e0 Fix comments at the start of these files and adjust copyrights 2017-11-10 20:16:00 +00:00
Ben Cohen
badb70174a Add server side plugin [UNTESTED] 
This is based on xrdpapi/xrdp-ssh-agent.c from xrdp PR #867.
 2017-11-10 20:16:00 +00:00
Ben Cohen
c27541e9ac Add rdpcontext so read thread can report channel error 
Also fix copyright dates...
 2017-11-10 20:16:00 +00:00
Ben Cohen
639930869a Remove EAGAIN/EWOULDBLOCK from blocking read/write 2017-11-10 20:16:00 +00:00
Ben Cohen
7e262213ca Fix socket fd leak and other changes 
1. In connect_to_sshagent() if connect() fails, the socket agent_fd is
   leaked.  It needs to be closed before returning.

2. Fix copyright messages.

3. Make if statement with call to CreateThread() clearer to read.
 2017-11-10 20:16:00 +00:00
Ben Cohen
0e90841a18 Forward ssh-agent data between ssh-agent and RDP 
Add the sshagent plugin to forward the ssh-agent protocol over an RDP
dynamic virtual channel, just as the normal ssh-agent forwards it over
an SSH channel.  Add the "/ssh-agent" command line option to enable it.
Usage:

Run FreeRDP with the ssh-agent plugin enabled:

   xfreerdp /ssh-agent ...

In the remote desktop session run xrdp-ssh-agent and evaluate the output
in the shell as for ssh-agent to set the required environment variables
(specifically $SSH_AUTH_SOCK):

   eval "$(xrdp-ssh-agent -s)"

This is the same as for the normal ssh-agent.  You would typically do
this in your Xsession or /etc/xrdp/startwm.sh.

Limitations:

1. Error checking and handling could be improved.

2. This is only tested on Linux and will only work on systems where
clients talk to the ssh-agent via Unix domain sockets.  It won't
currently work on Windows but it could be ported.
 2017-11-10 20:16:00 +00:00