akallabeth
d6b7e90d69
Merge pull request #10514 from akallabeth/double-free
...
[channels,rail] fix use after free
2024-08-27 09:25:04 +02:00
Armin Novak
7aae7896ae
[channels,rail] fix use after free
2024-08-27 09:08:15 +02:00
akallabeth
f928f9465b
Merge pull request #10513 from hardening/freerdp_peer_new_fix
...
core: relax check in freerdp_peer_new
2024-08-27 08:41:49 +02:00
David Fort
f1b299c3e2
core: relax check in freerdp_peer_new
...
Not all socket kinds have the TCP_NODELAY option (especially local UNIX sockets),
so don't make the setsockopt fatal.
2024-08-26 19:53:49 +02:00
akallabeth
598746a26b
Merge pull request #10511 from akallabeth/rails-simplify
...
[channels,rail] simplify sending
2024-08-26 14:31:08 +02:00
akallabeth
7f13d1993d
[channels,rail] simplify sending
...
* Fix #5347 : Do not create useless copy of data to send.
2024-08-26 14:14:47 +02:00
akallabeth
00eb86970d
Merge pull request #10510 from akallabeth/serial-cleanup
...
Serial cleanup
2024-08-26 13:47:10 +02:00
akallabeth
7054b26916
[channels,parallel] compilation checks
...
* Only compile channel related command line if enabled
* Warn on unsupported platforms
2024-08-26 13:30:30 +02:00
akallabeth
387dabc4dd
[channels,serial] add CMake messages
...
Inform user about platforms that do not support serial redirection
2024-08-26 13:26:15 +02:00
akallabeth
1ec18ce827
[channels,serial] default to off on APPLE
2024-08-26 13:23:09 +02:00
akallabeth
050eef537a
[client,common] guard /serial argument
...
only enable if serial redirection support is compiled in
2024-08-26 13:21:13 +02:00
akallabeth
d08e44d883
[channels,serial] only build on linux
...
* Guard by CMake
* Remove code #ifdef to ease porting
2024-08-26 13:18:52 +02:00
akallabeth
f855fdc66a
Merge pull request #10509 from akallabeth/cmake-system-inc
...
[cmake] mark dependency includes SYSTEM
2024-08-26 12:40:10 +02:00
akallabeth
eb7d8fdeb0
[channels,serial] improve command line parsing
...
* Gracefully exit on invalid serial driver
* Gracefully exit on onvalid serial port flags
2024-08-26 12:37:03 +02:00
akallabeth
0b21fddef6
[channels,serial] improve IRP processing logging
2024-08-26 12:37:01 +02:00
akallabeth
df04e4c888
[channels,parallel] unify IRP processing logging
2024-08-26 12:36:58 +02:00
akallabeth
d81dd9d9ff
[winpr,comm] fix stopping of serial threads
...
Since most unhandled threads get cancelled do not rely on
SERIAL_EV_WINPR_WAITING flag.
2024-08-26 12:36:56 +02:00
akallabeth
221dd7ce1d
[winpr,comm] improve error handling
2024-08-26 12:36:51 +02:00
akallabeth
1ca069c771
[channels,serial] fix IrpThread handling
...
* Proper terminated threads cleanup
* Proper remaining threads termination on close
2024-08-26 12:35:54 +02:00
akallabeth
348ddf61c0
[channels,serial] delay IRP thread start
...
wait until irp_thread_func has completed before starting the thread.
This prevents a race condition when accessing the IRP structure which is
freed up once the thread terminates.
2024-08-26 12:35:51 +02:00
akallabeth
9f911bea62
[winpr,comm] cleanup comm_sercx2_sys
...
* WINPR_ASSERT arugments
* remove use of restricted keywords (variables/functions starting with _)
2024-08-26 12:23:14 +02:00
akallabeth
2a7572e6b3
[winpr,comm] cleanup comm_serial_sys
...
* WINPR_ASSERT arguments
* remove use of restricted keywords (variables/functions starting with _)
2024-08-26 12:23:11 +02:00
akallabeth
652c5310f2
[channel,serial] cleanup code
...
* WINPR_ASSERT arugments
* remove use of restricted keywords (variables/functions starting with _)
* Better logging and error checks
2024-08-26 12:23:04 +02:00
akallabeth
56d660f258
[cmake] mark dependency includes SYSTEM
...
Mark all dependency include paths SYSTEM so warnings from system headers
are excluded from ci warning statistics
2024-08-26 11:10:49 +02:00
akallabeth
36686ba348
Merge pull request #10508 from akallabeth/cov-fix-high
...
[coverity] fix warnings
2024-08-26 09:51:23 +02:00
akallabeth
679de71056
[core,nla] remove platform guards for PasswordHash
...
Fixes #10507 : do not ask for password if PasswordHash is supplied on
windows.
2024-08-26 09:23:55 +02:00
akallabeth
86e2789d9b
[coverity] fix warnings
2024-08-26 09:19:06 +02:00
akallabeth
2812775c96
Merge pull request #10504 from akallabeth/sdl-monitors
...
[client,sdl] add support for /monitors argument
2024-08-23 15:03:46 +02:00
akallabeth
95b88baa8f
Merge pull request #10503 from akallabeth/coverity-fix
...
[coverity] fix some warnings
2024-08-23 14:14:04 +02:00
akallabeth
49dc431045
[client,sdl] add support for /monitors argument
2024-08-23 14:00:47 +02:00
akallabeth
fc6ba9f8f9
Merge pull request #10502 from akallabeth/ci-autoclose
...
[ci,autoclose] improve detection
2024-08-23 12:40:34 +02:00
akallabeth
ba7fd06ec4
[coverity] fix some warnings
...
* mostly dead store and identical code branches.
* some possible integer overflows
2024-08-23 12:38:41 +02:00
akallabeth
a3d2c33f96
[ci,autoclose] improve detection
...
* Increase operations-per-run to 90, 60 is still too low.
* Exempt assigned pull requests and issues
* Exempt pull requests and issues with a milestone
2024-08-23 11:45:40 +02:00
akallabeth
3f5f53d3dc
Merge pull request #10501 from akallabeth/ci-autoclose
...
[ci,autoclose] increase operations per run
2024-08-23 11:15:35 +02:00
akallabeth
fb57a96eba
[ci,autoclose] increase operations per run
2024-08-23 11:00:58 +02:00
David Fort
c7b519472b
Merge pull request #10494 from fifthdegree/asn1_int_fix
...
Fix ASN.1 integer decoding
2024-08-21 22:46:37 +02:00
Isaac Klein
3fb7bd92cc
Don't accept 0-length ASN.1 integers for decoding
2024-08-21 14:02:26 -04:00
akallabeth
73b7401bbb
Merge pull request #10498 from akallabeth/solid-fill
...
Solid fill
2024-08-21 15:44:53 +02:00
Armin Novak
8f55f33951
[gdi,bitmap] initialize buffer solid black
2024-08-21 15:14:43 +02:00
Armin Novak
502640caca
[gdi,gfx] SolidFill always use alpha 0xff
2024-08-21 15:13:53 +02:00
akallabeth
20986e927f
Merge pull request #10496 from akallabeth/warn_fixes
...
Warn fixes
2024-08-21 10:19:28 +02:00
Armin Novak
17d44e847f
[coverity] fix various warnings
2024-08-21 09:47:34 +02:00
Armin Novak
fe76bafd57
[channels,drive] fix out of bound access
2024-08-21 09:20:25 +02:00
Isaac Klein
9c413abee1
Fix ASN.1 integer decoding
...
Treat ASN.1 encoded integers with a leading zero byte and the MSB of the
second byte set as non-negative
2024-08-20 19:14:02 -04:00
akallabeth
0fe5831187
Merge pull request #10491 from akallabeth/tcp_probe_addrinfo
...
[core,tcp] retry all DNS entries until success
2024-08-20 14:08:06 +02:00
akallabeth
79abff4329
Merge pull request #10492 from akallabeth/sdl-dialog-msg
...
[client,sdl] remove tab from dialog messages
2024-08-20 13:54:51 +02:00
akallabeth
37008506c2
[client,sdl] remove tab from dialog messages
2024-08-20 13:31:41 +02:00
akallabeth
7fe1164d26
Merge pull request #10490 from akallabeth/desktop-resize-deadlock
...
Desktop resize deadlock
2024-08-20 13:28:04 +02:00
akallabeth
1265498b1f
Merge pull request #10489 from akallabeth/verify-cert-improve
...
Verify cert improve
2024-08-20 13:13:57 +02:00
akallabeth
4286a4c164
[core,tcp] retry all DNS entries until success
...
When resolving some DNS name with getaddrinfo try all returned entries
matching the configuration (IPv4|IPv6|any) until the socket can be
connected. Fixes #5335
2024-08-20 13:10:12 +02:00
