mirrors/FreeRDP
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
14,368 Commits 6 Branches 74 Tags 84 MiB
813204554d
Commit Graph

2205 Commits

Author SHA1 Message Date
akallabeth
813204554d Fixed fallback to getlogin for android 
(cherry picked from commit caff01877d)
 2020-06-22 12:13:56 +02:00
akallabeth
eb1cf9a2ac Fixed broken const variable. 
(cherry picked from commit 1c6a6923f8)
 2020-06-22 12:13:31 +02:00
akallabeth
ac9f5e8f5d Use localtime_s on windows 
(cherry picked from commit c3a1ed780c)
 2020-06-22 12:12:35 +02:00
akallabeth
23161efa62 Fixed codition with side effects 
(cherry picked from commit 1a02af5a12)
 2020-06-22 12:12:21 +02:00
akallabeth
3606dfa921 Replaced getlogin with getlogin_r 
(cherry picked from commit 36478d3d0b)
 2020-06-22 12:12:02 +02:00
akallabeth
8c3f6d2b19 Replaced localtime with localtime_r 
(cherry picked from commit 240fdd07b1)
 2020-06-22 12:11:54 +02:00
Bernhard Miklautz
7f2de8419a fix [client channels]: move exported API calls to client/common 
The functions mappedGeometryRef and mappedGeometryUnref are API
functions ([1]) but were implemented in the geometry channel.
In case FreeRDP was built with BUILTIN_CHANNELS=OFF those functions
weren't available globally but used by the video channel.

Now the functions are fixed part of the freerdp-client library and
therefore available for all channels.

[1] exported in freerdp/client/geometry.h

Fixes #6236

(cherry picked from commit 1628939227)
 2020-06-22 09:30:42 +02:00
Armin Novak
b300c8a738 Do not remove transfer data on usb cancel transfer 
(cherry picked from commit a5e2d62e48)
 2020-06-16 11:20:18 +02:00
Armin Novak
fd42acc594 Fixed double free in urb_isoch_transfer_cb 
(cherry picked from commit ef4de12887)
 2020-06-16 11:20:18 +02:00
Armin Novak
192f922502 Fixed sign compare warnings with constants. 
(cherry picked from commit 5ec66cc6c7)
 2020-06-16 11:20:18 +02:00
Kubistika
66dfa56cc2 drdynvc: client: fix #6252 use-after-free 
(cherry picked from commit 6ed765c960)
 2020-06-16 09:08:52 +02:00
akallabeth
bc8ace351f Fixed formatting. 
(cherry picked from commit d1b310d970)
 2020-06-16 09:08:41 +02:00
Ondrej Holy
3f86260eaa smartcard: Teoretical fix of uninitialized values 
This tries to fixes the following defects reported by covscan tool:
 - channels/smartcard/client/smartcard_operations.c:958: uninit_use_in_call: Using uninitialized value "ret.cReaders" when calling "smartcard_pack_locate_cards_return".
 - channels/smartcard/client/smartcard_operations.c:932: uninit_use_in_call: Using uninitialized value "ret.cReaders" when calling "smartcard_pack_locate_cards_return".

But I am not sure about it...

(cherry picked from commit 5345988352)
 2020-06-16 09:08:34 +02:00
Ondrej Holy
5dbb255feb smartcard: Fix usage of uninitialized values 
This fixes the following defect reported by covscan tool:
 - channels/smartcard/client/smartcard_pack.c:942: uninit_use_in_call: Using uninitialized value "tmp" when calling "ConvertFromUnicode".
 - channels/smartcard/client/smartcard_pack.c:894: uninit_use_in_call: Using uninitialized value "tmp" when calling "ConvertFromUnicode".
 - channels/smartcard/client/smartcard_pack.c:475: uninit_use_in_call: Using uninitialized value "tmp" when calling "ConvertFromUnicode".

(cherry picked from commit e70e25715f)
 2020-06-16 09:08:28 +02:00
Patrick Chin
fa647175cb Fix memory leaks in client/encomsp_main.c and client/remdesk_main.c 
(cherry picked from commit 28e29f8ad5)
 2020-06-16 09:07:37 +02:00
Florian Staudacher
5491795588 report only actual bytes received, not allocated buffer size (interrupt produces data, timeout doesn't) 
(cherry picked from commit 2e4f27ac9f)
 2020-06-16 09:07:16 +02:00
Florian Staudacher
f681d2450f only call 'libusb_set_interface_alt_setting' when value is changed 
(cherry picked from commit ea8c922355)
 2020-06-16 09:06:45 +02:00
Armin Novak
0c779b4fef Fixed memory leak in rdpei 
(cherry picked from commit 8c2c19bbc8)
 2020-06-16 09:05:24 +02:00
akallabeth
ca246a6bfd Clear dynamic channel lists on disconnect. 
(cherry picked from commit a1eb3e66b3)
 2020-05-20 15:41:24 +02:00
akallabeth
5a1167f7e3 Fixed #6197: NULL check in urbdrc 
(cherry picked from commit fb3a0e6b5a)
 2020-05-20 15:41:24 +02:00
Armin Novak
ff31ac6da7 Fixed #6195: Wrong length read/write in rdpei 
(cherry picked from commit a18a732d4b)
 2020-05-20 15:41:24 +02:00
akallabeth
77b5043d21 Reset pointer to NULL after free. 
(cherry picked from commit 33c7f808154c6682d3b84526a46d79f3e8d5c1ac)
 2020-05-20 15:41:24 +02:00
akallabeth
9d5bb41445 Removed unused variable warnings 
(cherry picked from commit 8052708f3354a686de98b62d641e9d0eb61a74db)
 2020-05-20 15:41:24 +02:00
akallabeth
3a2ce9b8bd Fixed rails debug string warnings. 
(cherry picked from commit e58ea30305e8754ada82018c4f2042ec1b72337c)
 2020-05-18 17:10:01 +02:00
Vladyslav Hordiienko
9b473e03d0 fix typo in GFX logs 
(cherry picked from commit a79635fd1c)
 2020-05-18 16:56:03 +02:00
akallabeth
f88705c10c Extend lifetime of streampool in drdynvc 
The stream pool can not be released until all streams have been
returned. This might happen as late as channel termination, so
change the lifetime scope accordingly.

(cherry picked from commit 5bd4cfcdc0)
 2020-05-18 16:56:03 +02:00
akallabeth
a84d2783f9 Fixed drdynvc_send stream release 
(cherry picked from commit a497e78d37)
 2020-05-18 16:56:03 +02:00
akallabeth
3fe4650b2c Fixed DestroyListener arguments and call order 
(cherry picked from commit 0e08727d4e)
 2020-05-18 16:41:20 +02:00
akallabeth
47b4867729 Destroy channel listeners on terminate 
(cherry picked from commit 2f5e5359f6)
 2020-05-18 16:40:52 +02:00
akallabeth
74629de51b drdynvc channel cleanup. 
* Clean channel listeners on channel close
* Remove limit on listeners for channels
* Remove limit on channels

(cherry picked from commit 5b2a4434d8)
 2020-05-18 16:40:44 +02:00
akallabeth
79cea7b5b6 Fixed #6157: Reset cups instance on disconnect. 
(cherry picked from commit 13906f3ec6)
 2020-05-18 16:40:23 +02:00
akallabeth
c266a81323 Fixed #6163: Force linking to objective C runtime 
Sound channel requires the objective C runtime, force linking to
fix build issues on older mac os versions

(cherry picked from commit eee1d7176b)
 2020-05-18 16:39:28 +02:00
akallabeth
fae7b99a84 Fixed #6162: Clipboard temporary path length limit 
The limit of clipboard temporary paths is 260 '\0' terminated
wide characters. Fix the checks to enforce that properly.

(cherry picked from commit 06bfcfad67)
 2020-05-18 16:38:29 +02:00
akallabeth
d858616852 Changed smartcard no reader log message level to info 
(cherry picked from commit 728f6aff516a12ac8720aa0c9fa1730cde348dca)
 2020-05-08 11:11:12 +02:00
akallabeth
3e4a835c29 Fixed wrong error return from drdynvc_write_data 
When the channel was closed a wrong error code was returned.

(cherry picked from commit 6446d609fc95830d7c9c1e6a91829146d567e277)
 2020-05-08 11:11:12 +02:00
akallabeth
b1c7c9f59d Create data copy in case of dynamic sound channel. 
(cherry picked from commit f016f1ec09)
 2020-05-08 11:11:12 +02:00
akallabeth
1baac780e5 Use dedicated sound decoder thread. 2020-05-08 11:06:02 +02:00
akallabeth
eee9dead2d Fixed compiler warnings for usb channel 2020-05-08 11:06:02 +02:00
Armin Novak
a8c6f012d8 Silence SCARD_E_TIMEOUT warnings 
These occur quite often for status calls, so reduce log verbosity.
 2020-05-08 11:06:02 +02:00
akallabeth
e928888dab Fixed various input buffer length checks in URBDRC 
Thanks to hac425 CVE-2020-11039
 2020-05-08 11:06:02 +02:00
akallabeth
c1cef2d68c Fixed int overflow in smartcard_ndr_read 
Thanks to hac425
 2020-05-08 11:06:02 +02:00
akallabeth
af2ce439e1 Fixed int overflow in msusb_mspipes_read 
Thanks to hac425
 2020-05-08 11:06:02 +02:00
akallabeth
4c07a00403 Fixed int overflow in printer_write_setting 
Thanks to hac425
 2020-05-08 11:06:02 +02:00
akallabeth
98a4cd28bd Fixed int overflow in PresentationContext_new 
Thanks to hac425 CVE-2020-11038
 2020-05-08 11:06:02 +02:00
akallabeth
7c94b425e6 Fixed oob read in rdpsnd_recv_wave2_pdu 
Check format index before using it.
Thanks to hac425 CVE-2020-11041
 2020-05-05 07:46:10 +02:00
akallabeth
00b5ff301f Fixed clipboard 'called with invalid type' warning 2020-05-05 07:46:10 +02:00
akallabeth
f3de3ee16b Fix short format name configuration and format list return. 2020-05-05 07:46:10 +02:00
akallabeth
55f18cb8a5 Fix oob read in msusb_msconfig_read 2020-05-05 07:46:10 +02:00
akallabeth
a1a6790f99 Fixed oob read in irp_write and similar 2020-05-05 07:46:10 +02:00
akallabeth
b375d84ed6 Fixed oob read in parallel_process_irp_create 2020-05-05 07:46:10 +02:00