Armin Novak
80d2462833
Hide redirection implementation details.
2018-12-05 10:55:06 +01:00
Armin Novak
5ca8eca18e
Made nego self contained.
2018-12-05 10:55:06 +01:00
David Fort
7ad24b6069
Merge pull request #5080 from akallabeth/scanbuild-ex-warn
...
Scanbuild ex warn
2018-11-29 16:24:28 +01:00
Armin Novak
aeeaba5bc3
Fixed a memory leak.
2018-11-29 12:14:20 +01:00
Armin Novak
7ec9e942fb
Fixed zero sized allocation.
2018-11-29 12:11:33 +01:00
Armin Novak
16a7613194
Fixed zero sized allocation.
2018-11-29 12:11:33 +01:00
Bernhard Miklautz
1a33b3383c
Merge pull request #5070 from akallabeth/gw_fixes_redirection
...
Fixed buffer reset in fields_present_to_string
2018-11-29 11:10:14 +00:00
David Fort
e7a44bc437
Merge pull request #5057 from akallabeth/order_settings_init_generic
...
Unified initialization of OrderSupport
2018-11-28 17:46:18 +01:00
Armin Novak
263cc74580
Fixed buffer reset in fields_present_to_string
2018-11-26 14:11:29 +01:00
Bernhard Miklautz
52d1b35a63
Merge pull request #5046 from akallabeth/silence_wlog
...
Do not compile extended debugging by default.
2018-11-26 11:10:59 +00:00
Bernhard Miklautz
0b8010f8d6
Merge pull request #5065 from akallabeth/tcp_connect_multi_fix
...
Fixed a possible NULL dereference.
2018-11-26 10:57:20 +00:00
Armin Novak
5623a4761f
Fixed a possible NULL dereference.
2018-11-23 10:32:52 +01:00
Armin Novak
7d89ea22d4
Unified initialization of OrderSupport
...
Added a library internal function freerdp_settings_set_default_order_support
which initializes the OrderSupport array of settings.
Now clients no longer need to set this up on their own, if they
do not implement their own hardware accelerated order processing.
2018-11-23 10:11:50 +01:00
Armin Novak
391528f40a
Fixed a broken length check in rdg_process_packet
...
HTTP gateway connections aborted due to this.
Additionally add more verbose error logging in RDG.
2018-11-23 09:45:09 +01:00
akallabeth
d0d414dfa0
Fix #5059 : Changed return type of peer_free to void.
2018-11-22 19:08:25 +01:00
Martin Fleisz
6c97d318ec
Merge pull request #5022 from akallabeth/gw_rdg_error_mapping
...
Improved error mapping and tightened checks in rdg_process_packet
2018-11-22 15:10:58 +01:00
Armin Novak
3110b5f5c5
Simplified string empty check.
2018-11-22 14:29:22 +01:00
Armin Novak
8df39fdad4
Use blocking sockets in freerdp_tcp_connect_multi
...
The non blocking connect in freerdp_tcp_connect_multi did not
work reliably.
Fall back to blocking connect (which might take longer until the connection
is established) instead of not being able to connect at all.
2018-11-22 11:11:31 +01:00
Armin Novak
1ed436c8fc
Fixed socket cleanup in connect multi.
2018-11-22 11:11:31 +01:00
Armin Novak
4b3f4cc2fc
Fixed event check in freerdp_tcp_connect_multi
2018-11-22 11:11:31 +01:00
David Fort
5e7ac925f5
Merge pull request #5045 from akallabeth/license_double_free_fix
...
Fixed double free in license_free_binary_blob
2018-11-21 16:03:18 +01:00
Martin Fleisz
947aa80033
Merge pull request #5016 from akallabeth/windows_server_build_fix
...
Windows server build fix
2018-11-21 16:02:47 +01:00
Armin Novak
17bbe7a23f
Do not compile extended authentication debugging by default.
2018-11-21 15:36:31 +01:00
Armin Novak
feb993b948
Fixed double free in license_free_binary_blob
2018-11-21 15:07:36 +01:00
Armin Novak
cdf1ee61f0
Proper field to string debug functions for each response in RDG
2018-11-21 14:37:38 +01:00
Armin Novak
a97bf21109
Fixed broken DEBUG_RDP log message.
2018-11-21 09:55:38 +01:00
Armin Novak
445a5a42c5
Fixed CVE-2018-8786
...
Thanks to Eyal Itkin from Check Point Software Technologies.
2018-11-20 11:08:31 +01:00
Bernhard Miklautz
ef0c7e81a7
Merge pull request #4953 from akallabeth/region_signed
...
signed gdi regions to adjust negative coordinates
2018-11-20 10:07:30 +00:00
Armin Novak
666ef4ab34
Fix #4864 : Register pointer cache after PostConnect is called
...
With #4950 client side pointer implementation was made optional.
This addresses an issue that each client had to call
pointer_cache_register_callbacks on its own.
2018-11-20 09:49:39 +01:00
akallabeth
b6eca4fc54
signed gdi regions to adjust negative coordinates
2018-11-19 12:52:43 +01:00
Bernhard Miklautz
b7354ce438
Merge pull request #4940 from akallabeth/check_window_order_support
...
Added checks for order type window support.
2018-11-19 09:15:14 +00:00
Armin Novak
7839091f8b
Skip redirection resolve test if we're connecting via gateway.
2018-11-16 15:48:10 +01:00
Armin Novak
870b7025b7
Improved error mapping and tightened checks in rdg_process_packet
2018-11-16 15:41:19 +01:00
Bernhard Miklautz
fe1a79759e
Merge pull request #5018 from hardening/windowpos
...
cmdline: add window-position argument to set initial window position
2018-11-15 16:46:57 +00:00
Bernhard Miklautz
b8cf70b13a
Merge pull request #4964 from akallabeth/rdg_fixes
...
Rdg/RPC and gateway fixes
2018-11-15 13:48:22 +00:00
David Fort
e118d14f6a
cmdline: add window-position argument to set initial window position
...
This is useful if you want the window to be at a given position. The patch also mutualizes
the parsing of <xpos>x<ypos> or <width>x<height> arguments.
2018-11-15 14:40:03 +01:00
Armin Novak
4d7bece6ea
Fixed order mask
2018-11-15 09:52:54 +01:00
Armin Novak
dd80a09781
Allow window orders with AllowUnanouncedOrdersFromServer
2018-11-15 09:52:54 +01:00
Armin Novak
c0b13cf43f
Added checks for order type window support.
2018-11-15 09:52:50 +01:00
Bernhard Miklautz
d915491717
Merge pull request #5012 from akallabeth/rail_app_icons
...
Rail app icons
2018-11-15 08:50:56 +00:00
Armin Novak
a2cd934184
Fixed windows build warnings.
2018-11-15 09:01:53 +01:00
akallabeth
268a2c0cf8
Merge pull request #4979 from hardening/CAL
...
license: support CAL license
2018-11-14 13:45:31 +01:00
Armin Novak
98a537d05d
Better description and formatting for update_read_icon_info
2018-11-14 11:57:57 +01:00
Armin Novak
7e12955c55
Made all internal functions static.
2018-11-14 11:57:57 +01:00
ilammy
7a2b6e1301
libfreerdp-core: fix reading TS_ICON_INFO
...
The spec says that CbColorTable field is present when Bpp is 1, 4, 8.
Actually, bpp == 2 is not supported by TS_ICON_INFO according to the
spec (though, DIB definitely supports 16-color images).
MS-RDPERP 2.2.1.2.3 Icon Info (TS_ICON_INFO)
CbColorTable (2 bytes):
This field is ONLY present if the bits per pixel (Bpp)
value is 1, 4, or 8.
Omitting 8-bit value breaks 256-color icons which are incorrectly
read with color and alpha data mixed up.
2018-11-14 10:53:45 +01:00
Armin Novak
138eb13fea
Updated RDP_VERSION definitions.
2018-11-14 10:14:48 +01:00
Armin Novak
ecac998340
Fixed rdg bio cleanup.
...
When attaching the RDG BIO to the TLS BIO also transfer ownership.
2018-11-13 12:22:09 +01:00
Armin Novak
3c35a098f5
Fixed direct rdg front bio access.
2018-11-13 11:24:04 +01:00
Armin Novak
e070bbea8d
Fixed leaks in rdg_send_channel_create
2018-11-13 11:22:37 +01:00
Armin Novak
342ff8cf0b
Fixed broken server name packet size
2018-11-13 11:22:37 +01:00