Commit Graph

69 Commits

Author SHA1 Message Date
Armin Novak
485061e4d0 Fix #5317: Change file attributes before modifying file time. 2019-03-29 15:45:52 +01:00
Armin Novak
4ba73e0c73 Fixed warnings found by compiler and static analysis. 2019-01-24 11:53:52 +01:00
Armin Novak
805741bdf6 Fixed #5185 broken file size initialization. 2019-01-14 14:54:33 +01:00
Armin Novak
fdf9ca3273 Fixed #5113: The timestamps for FileFullDirectoryInformation were inverted. 2018-12-07 10:59:52 +01:00
David Fort
ba69925b8d
Merge pull request #4501 from akallabeth/drive_file_size_fix
Removed xrdp workarounds.
2018-09-24 16:00:27 +02:00
Armin Novak
ab18f8f222 Fix #4680: Return proper directory name. 2018-08-23 10:04:26 +02:00
Armin Novak
dbd630a38c drive_file_query_information: Use GetFileAttributesExW 2018-08-13 13:40:59 +02:00
Armin Novak
d8e8bf8476 Removed xrdp workarounds.
These workarounds limit functionality with other server implementations
and should be fixed in xrdp.
2018-03-20 11:31:53 +01:00
David Fort
a132922376 Add checks for DR channel 2017-10-04 10:30:47 +02:00
Bernhard Miklautz
bbd11eef1d Merge pull request #4045 from akallabeth/drive_fixes_overlayfs
Drive fixes overlayfs
2017-09-22 17:22:00 +02:00
Armin Novak
32de218c3f Fixed file seek. 2017-08-08 10:52:11 +02:00
Armin Novak
6a06c8d991 Additional error checks for drive channel. 2017-07-24 11:31:48 +02:00
Norbert Federa
36b8f54c5e Fixed a few compiler warnings 2017-07-10 17:52:05 +02:00
Armin Novak
98736c9d4d Fix #3995: File size information 2017-06-09 13:02:50 +02:00
Armin Novak
6b960a4319 Fix #3962: Remove trailing slashes from path. 2017-05-17 16:43:16 +02:00
Armin Novak
0a309fcbec Use unicode constants for WCHAR 2017-05-17 16:17:16 +02:00
Ilya Shipitsin
c78a2f0333 resolve issues identified by cppcheck
[channels/drive/client/drive_file.c:125]: (error) Memory leak: path_slash
[server/Windows/wf_dxgi.c:195]: (error) Invalid number of character '(' when these macros are defined: 'WITH_DXGI_1_2'.
2017-05-01 16:40:02 +05:00
Armin Novak
73e89bffcc Cleaned up includes. 2017-04-19 08:27:22 +02:00
David PHAM-VAN
b46aaeb973 Fix memory leaks, Mixed declarations 2017-03-27 11:15:22 -07:00
David PHAM-VAN
5a66fe841a Misc Fixes 2017-03-17 14:07:33 -07:00
David PHAM-VAN
459d3a0473 Fix Windows build 2017-03-16 16:20:48 -07:00
David PHAM-VAN
9c596b70a6 Fix Android build 2017-03-14 10:48:10 -07:00
David PHAM-VAN
9a76a43088 Add specific Xrdp workarounds
This reverts commit 36d95d73715bd081019538c55f74294aa9faffba.
2017-03-13 14:18:50 -07:00
David PHAM-VAN
c7924b554d Rewrite drive channel using WinPR functions 2017-03-13 14:18:46 -07:00
Armin Novak
b2c29158be Scanbuild warning, argument checks and leak fixes.
* Added Stream_GetRemainingCapacity to check remaining stream size
  before writes.
* Fixed shadow server memory leak.
* Fixed lots of scanbuild warnings
* Added missing argument checks in many functions
* Added missing static function declarations
2017-03-02 18:13:43 +01:00
Norbert Federa
f71b6b46e8 fix string format specifiers
- fixed invalid, missing or additional arguments
- removed all type casts from arguments
- added missing (void*) typecasts for %p arguments
- use inttypes defines where appropriate
2016-12-16 13:48:43 +01:00
Norbert Federa
c6e6b44143 countless WLog/printf format specifier fixes 2016-11-25 17:06:25 +01:00
Marc-André Moreau
915b9a15b1 Merge branch 'master' of github.com:FreeRDP/FreeRDP
Conflicts:
	winpr/libwinpr/bcrypt/CMakeLists.txt
2016-05-11 11:05:17 -04:00
Marc-André Moreau
4d629a7999 freerdp: UWP porting 2016-03-29 16:03:15 -04:00
Armin Novak
43b13ffcd2 Replace SetFilePointerEx with SetFilePointer. 2016-03-17 09:34:24 +01:00
David PHAM-VAN
2f28b6c38b Improve code using more winpr functions 2016-03-02 10:01:51 -08:00
David PHAM-VAN
a20950faa0 Implement FileAllocationInformation 2016-03-02 10:01:51 -08:00
Armin Novak
1cedbd5cd1 Fixed memory leak. 2015-08-28 11:01:34 +02:00
Martin Haimberger
d3d60520e5 hardend channel drive 2015-06-18 03:04:32 -07:00
Bernhard Miklautz
74c8400789 coding style fixes
Add missing space after if
2015-03-30 17:15:45 +02:00
Bernhard Miklautz
f469e069dc stream: Stream_Ensure*Capacity: change return type
Change the return type of Stream_Ensure*Capacity from void to BOOL to be
able to detect realloc problems easily. Otherwise the only way to detect
this was to check if the capacity after the call was >= the required
size.
In case Stream_Ensure*Capacity fails the old memory is still available
and need to freed outside.

This commit also adds checks to most calls of Stream_Ensure*Capacity to
check if the call was successful.
2015-03-30 16:33:48 +02:00
Petr Sumbera
17df42e4b5 Fixes some build issues on Solaris 11. 2015-02-02 08:48:54 -08:00
Norbert Federa
e393499ff8 rdpdr/drive: fixes for hung peers & info requests
drive_file_init: only allow directories and regular files
This is fixes issue #2071

Even if the server is only interested in getting a file's or directory's
attributes FreeRDP still tries to open the object with read permissions.
If the FreeRDP client has no read permissions for this object the call will
fail which forces the server to perform some expensive workarounds (e.g.
getting to the stat buffers via a directory enumeration request).

On Linux we can try to open the file or directory with the O_PATH flag in
order to obtain a file descriptor who's only purpose is to perform operations
that act purely at the file descriptor level.
2014-09-02 15:42:44 +02:00
Marc-André Moreau
f30d7cf66a Merge pull request #2024 from repzilon/master
uclibc build fixes and recompressed images
2014-08-18 13:08:52 -04:00
Zhang Zhaolong
60f283cffb drive: fix contents lost when cut-paste a folder. 2014-08-18 16:00:34 +08:00
Rene Rheaume
0d2a3d2e2f Fixed a typo for conditional compilation 2014-08-07 07:11:04 -04:00
Rene Rheaume
223a9f6124 futimens, while being POSIX-compliant, does not exist on Mac OS X. Added futimes back to address this. 2014-08-07 06:47:33 -04:00
Rene Rheaume
5f9c36da5d * Use futimens that is POSIX-compliant and compatible with uclibc instead of futimes.
* Borrowed eventfd_read and eventfd_write from bionic for uclibc compatibility (uclibc headers are broken unfortunately). Bionic and
FreeRDP are both under the Apache 2.0 license.
2014-08-06 22:06:01 -04:00
Marc-André Moreau
ee282a931b freerdp: fix build warnings on Windows 2014-05-10 09:50:36 -04:00
Marc-André Moreau
951368a1ce Merge branch 'master' of github.com:FreeRDP/FreeRDP 2014-02-27 13:58:29 -05:00
Zhang Zhaolong
b1fe93bf4b drive: win: add file rename support. 2014-02-12 18:13:42 +08:00
Zhang Zhaolong
0adb22f305 drive: win: add 64 bits support. 2014-02-12 17:52:28 +08:00
Zhang Zhaolong
f67fa72386 drive: win: fix file open flag. 2014-02-12 17:45:17 +08:00
Zhang Zhaolong
5157555d5b drive: minor code formatting. 2014-02-12 11:34:33 +08:00
Marc-André Moreau
5ff847a6e6 wfreerdp: fix multiple warnings 2014-02-10 01:06:11 -05:00