akallabeth
1b177eeda9
[core,security] fix assertion
...
The assert for the buffer size required too many bytes in the output
buffer.
2024-10-31 13:11:57 +01:00
akallabeth
d06a6d78cb
[file,namedpipe] clean up NamedPipeClientCreateFileA
...
simplify and improve error handling
2024-10-31 11:42:36 +01:00
akallabeth
a58a390726
[gdi,shape] fix logically dead code
2024-10-31 11:42:34 +01:00
akallabeth
7f44ef8114
[cache,glyph] eliminate logically dead code
2024-10-31 11:42:31 +01:00
akallabeth
4ec28e1f82
[warnings] fix -Wimplicit-int-conversion
2024-10-31 11:42:29 +01:00
akallabeth
b6e051f16c
[warnings] fix float-conversion
2024-10-31 11:42:26 +01:00
akallabeth
dcf5a8e28c
[warnings] fix -Wswitch-default
2024-10-31 11:42:24 +01:00
akallabeth
63121583eb
Merge pull request #10802 from akallabeth/compile-fix
...
[utils,helpers] revert removed define
2024-10-31 09:10:48 +01:00
akallabeth
6b6ae5fa9d
[utils,helpers] revert removed define
...
the define was conditionally unused. guard it now so it does not show up
as unused
2024-10-31 08:51:55 +01:00
akallabeth
2bdb059644
Merge pull request #10799 from akallabeth/generic-cleanups
...
[warnings] fix some compiler warnings
2024-10-30 19:32:22 +01:00
akallabeth
a5b64effab
[winpr,stream] add functions to write INT16_BE and INT32_BE
2024-10-30 19:18:04 +01:00
akallabeth
8bb5d598fc
[winpr,stream] fix missing comma
2024-10-30 17:10:03 +01:00
akallabeth
d232037e18
[winpr,asn1] fix writing integers
...
ASN1 integers are signed.
2024-10-30 16:55:56 +01:00
akallabeth
dc76879e0b
[warnings] fix some compiler warnings
...
* fix compiler warnings found in a lot of places
* add missing enum type for clipboard channel
* mark deallocator for winpr image function
2024-10-30 16:12:20 +01:00
akallabeth
d11be9025d
Merge pull request #10794 from akallabeth/internal-rc4
...
Internal rc4
2024-10-30 13:46:01 +01:00
akallabeth
8e33854c62
[tests] improve TestCommonAssistance
...
Compare encrypted passwords against reference values to ensure the
encryption routines work as expected
2024-10-30 13:22:59 +01:00
akallabeth
555d46f7e2
[winpr,crypto] deactivate key and IV lenght checks
...
OpenSSL does not support that in older versions, deactivate for the time
being.
2024-10-30 13:22:57 +01:00
akallabeth
2a41730f70
[common,assistance] replace winpr_Cipher_New
...
* use winpr_Cipher_NewEx where possible
* use winpr_RC4_New where RC4 is used
2024-10-30 13:22:55 +01:00
akallabeth
3ae0a10142
[core] replace usage of winpr_Cipher_New
...
prefer winpr_CipherNewEx to be on the safe side.
2024-10-30 13:22:52 +01:00
akallabeth
2b0b52be9e
[core,rdp] adjust warning for RC4
...
RC4 is not supported by winpr_Cipher_New but only by explicitly calling
winpr_RC4_New. Adjust the availability test to use the correct
functions.
2024-10-30 13:22:50 +01:00
akallabeth
1eac8fa15e
[winpr,crypto] deprecate winpr_Cipher_New
...
Deprecate function in favor of new winpr_CipherNewEx with explict key
and IV length parameters, adjust test cases to test both.
2024-10-30 13:22:45 +01:00
akallabeth
9db7deb30b
[warnings] initialize ULARGE_INTEGER
2024-10-30 10:20:41 +01:00
akallabeth
a7638bb0e4
Merge pull request #10798 from akallabeth/kbd-remap-fix
...
[utils,string] fix freerdp_extract_key_value
2024-10-29 17:20:52 +01:00
akallabeth
24ab4b297f
[utils,string] fix freerdp_extract_key_value
...
reset errno before strtoul to avoid aborting due to a previous errno
value from a different function call
2024-10-29 16:50:00 +01:00
akallabeth
566d4cf637
[stream] fix sign issues with stream API use
2024-10-29 15:50:07 +01:00
akallabeth
10e7acdd49
[winpr,stream] add functions to write INT16_BE and INT32_BE
2024-10-29 15:50:05 +01:00
akallabeth
8aa49c3e93
[warnings] fix C23 extension warnings
2024-10-29 15:50:02 +01:00
akallabeth
2b95757a7a
[warnings] fix redundant casts
2024-10-29 15:49:59 +01:00
akallabeth
8ee84ff054
[client,sdl] fix empty catch
2024-10-29 15:49:57 +01:00
akallabeth
3c9a45e9d0
[client,sdl] fix move constructors
...
use default implementation to avoid use after move
2024-10-29 15:49:54 +01:00
akallabeth
6548f1f9dd
[compiler] disable unknown pragma warnings
...
we compile with different compilers/checkers whith their own #pragma
do not warn us about that, we already know
2024-10-29 15:49:51 +01:00
akallabeth
aa954d9be9
[warnings] fix various compiler warnings
2024-10-29 15:49:43 +01:00
akallabeth
4078b0d5b9
[clang,tidy] disable readability-math-missing-parentheses
2024-10-29 12:32:38 +01:00
akallabeth
e9b942f612
Merge pull request #10791 from akallabeth/vmconnect
...
[client,common] tighten /vmconnect checks
2024-10-28 10:04:54 +01:00
akallabeth
f0d0105d50
[client,common] tighten /vmconnect checks
...
Fixes #5300 :
* abort if +/-nego is used, /vmconnect overrides these.
* only set custom port if no /port or /v:host:port is in use allowing
overriding default port
2024-10-28 09:44:21 +01:00
Martin Fleisz
fa71cb18f0
Merge pull request #10793 from akallabeth/ntlm-fixes
...
[winpr,sspi] fix NULL NTLM password handling
2024-10-28 09:44:20 +01:00
akallabeth
882060031f
Merge pull request #10787 from akallabeth/proxy-arg-check
...
[server,proxy] stricter argument parsing
2024-10-28 09:32:30 +01:00
akallabeth
98335b7dde
Merge pull request #10792 from akallabeth/cov-assert-silence
...
[ci,assert] silence coverity on WINPR_ASSERT
2024-10-28 09:22:54 +01:00
akallabeth
c9a946f272
[winpr,sspi] fix NULL NTLM password handling
...
* Pass through the NULL, but fail as the hash matches the NULL hash
2024-10-28 09:09:56 +01:00
Martin Fleisz
56786ea606
Merge pull request #10786 from akallabeth/ntlm-fixes
...
Ntlm fixes
2024-10-28 09:04:57 +01:00
akallabeth
c513886914
[ci,assert] silence coverity on WINPR_ASSERT
...
silence covertiy NO_EFFECT with _Pragma when using WINPR_ASSERT.
We´ve got a lot of situations where a check is mostly useless when
functions are called correctly, but the check triggers on common errors.
So silence this warning on our perfectly fine usage situations
2024-10-28 08:36:23 +01:00
akallabeth
259b4f40c8
Merge pull request #10790 from akallabeth/ci
...
[compiler,macros] fix pragma by compiler support
2024-10-27 22:36:35 +01:00
akallabeth
a60ac2321d
[compiler,macros] fix pragma by compiler support
2024-10-27 21:58:58 +01:00
akallabeth
42178b6191
Merge pull request #10789 from akallabeth/ci
...
Ci
2024-10-27 20:35:11 +01:00
akallabeth
fd1c850c62
[ci,preloads] fix CMAKE_BUILD_TYPE
2024-10-27 20:07:41 +01:00
akallabeth
7adb9517fc
[ci,alt-arch] use v2.8.1 of alt-architecture build
2024-10-27 20:07:33 +01:00
akallabeth
a0cb7ce166
Merge pull request #10788 from akarl10/websocket-negotiate-non-plain-ntlm-fix
...
[rdg,websockets] Fix Http Negotiate for Websocket
2024-10-27 19:17:09 +01:00
akarl10
1ea08b776f
Fix Http Negotiate for Websocket
...
When using negotiate in non direct NTLM mode the success response
contains an aditional token for the authentication layer.
Add HTTP_STATUS_SWITCH_PROTOCOLS to the list of valid HTTP status codes
where to extract the last auth token
2024-10-26 23:43:37 +02:00
akallabeth
940d067f52
[server,proxy] stricter argument parsing
...
* Check number of arguments is valid (don't allow additional ones)
* Replace exit() with normal return for helper functions
2024-10-26 19:53:36 +02:00
akallabeth
d2ec568d39
[winpr,sspi] improve NTLM unit test
...
* Test empty passwords as well
* Improve return value checks
2024-10-26 15:18:29 +02:00
